2023-11-30 17:19:22

by Johan Hovold

Subject: [PATCH] dt-bindings: leds: qcom,spmi-flash-led: fix example node name

The led controller is a child of an SPMI PMIC, which in turn sits on an
SPMI bus.

While at it, add some newline separators to improve readability.

Fixes: 1aeff6216891 ("dt-bindings: leds: Add QCOM flash LED controller")
Signed-off-by: Johan Hovold <[email protected]>
---
.../devicetree/bindings/leds/qcom,spmi-flash-led.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
index a8736fd5a539..1ba607685f5f 100644
--- a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
+++ b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
@@ -89,9 +89,11 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/leds/common.h>
- spmi {
+
+ pmic {
#address-cells = <1>;
#size-cells = <0>;
+
led-controller@ee00 {
compatible = "qcom,pm8350c-flash-led", "qcom,spmi-flash-led";
reg = <0xee00>;
--
2.41.0

2023-12-01 08:42:24

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: leds: qcom,spmi-flash-led: fix example node name

On 30/11/2023 18:19, Johan Hovold wrote:
> The led controller is a child of an SPMI PMIC, which in turn sits on an
> SPMI bus.
>
> While at it, add some newline separators to improve readability.
>
> Fixes: 1aeff6216891 ("dt-bindings: leds: Add QCOM flash LED controller")

Nothing to fix here, just an example code.

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-12-01 09:38:29

by Johan Hovold

Subject: Re: [PATCH] dt-bindings: leds: qcom,spmi-flash-led: fix example node name

On Fri, Dec 01, 2023 at 09:42:02AM +0100, Krzysztof Kozlowski wrote:
> On 30/11/2023 18:19, Johan Hovold wrote:
> > The led controller is a child of an SPMI PMIC, which in turn sits on an
> > SPMI bus.
> >
> > While at it, add some newline separators to improve readability.
> >
> > Fixes: 1aeff6216891 ("dt-bindings: leds: Add QCOM flash LED controller")
>
> Nothing to fix here, just an example code.

I'll just refer to my reply here for completeness:

https://lore.kernel.org/all/[email protected]/

Johan

2023-12-07 15:27:06

by Lee Jones

Subject: Re: (subset) [PATCH] dt-bindings: leds: qcom,spmi-flash-led: fix example node name

On Thu, 30 Nov 2023 18:19:40 +0100, Johan Hovold wrote:
> The led controller is a child of an SPMI PMIC, which in turn sits on an
> SPMI bus.
>
> While at it, add some newline separators to improve readability.
>
>

Applied, thanks!

[1/1] dt-bindings: leds: qcom,spmi-flash-led: fix example node name
commit: e9a3374e5c545e5eade4623098b958d2f4073455

--
Lee Jones [李琼斯]