The example regulator child nodes do not have unit addresses so drop the
incorrect '#address-cells' and '#size-cells' properties from the parent
node.
Signed-off-by: Johan Hovold <[email protected]>
---
.../devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
index e36e5ce58136..60d5e6b3de33 100644
--- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
@@ -77,9 +77,6 @@ examples:
interrupts = <0 0>;
regulators {
- #address-cells = <1>;
- #size-cells = <0>;
-
ldo3: ldo3 {
regulator-name = "ldo3";
regulator-min-microvolt = <1500000>;
--
2.41.0
On 30/11/2023 18:25, Johan Hovold wrote:
> The example regulator child nodes do not have unit addresses so drop the
> incorrect '#address-cells' and '#size-cells' properties from the parent
> node.
>
> Signed-off-by: Johan Hovold <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On Thu, Nov 30, 2023 at 06:25:45PM +0100, Johan Hovold wrote:
> The example regulator child nodes do not have unit addresses so drop the
> incorrect '#address-cells' and '#size-cells' properties from the parent
> node.
>
> Signed-off-by: Johan Hovold <[email protected]>
> ---
> .../devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
> index e36e5ce58136..60d5e6b3de33 100644
> --- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
> @@ -77,9 +77,6 @@ examples:
> interrupts = <0 0>;
>
> regulators {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
It's the right fix, but I have to wonder why these are not schema
errors? Seems like something in the schemas needs fixing.
> ldo3: ldo3 {
> regulator-name = "ldo3";
> regulator-min-microvolt = <1500000>;
> --
> 2.41.0
>
On 01/12/2023 15:40, Rob Herring wrote:
> On Thu, Nov 30, 2023 at 06:25:45PM +0100, Johan Hovold wrote:
>> The example regulator child nodes do not have unit addresses so drop the
>> incorrect '#address-cells' and '#size-cells' properties from the parent
>> node.
>>
>> Signed-off-by: Johan Hovold <[email protected]>
>> ---
>> .../devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
>> index e36e5ce58136..60d5e6b3de33 100644
>> --- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
>> @@ -77,9 +77,6 @@ examples:
>> interrupts = <0 0>;
>>
>> regulators {
>> - #address-cells = <1>;
>> - #size-cells = <0>;
>> -
>
> It's the right fix, but I have to wonder why these are not schema
> errors? Seems like something in the schemas needs fixing.
>
Good point. The fix is just not sufficient. This binding explicitly
allow it, so it should be removed there as well.
I retract my Ack/Review. :)
Best regards,
Krzysztof
On Fri, Dec 01, 2023 at 03:42:38PM +0100, Krzysztof Kozlowski wrote:
> On 01/12/2023 15:40, Rob Herring wrote:
> > On Thu, Nov 30, 2023 at 06:25:45PM +0100, Johan Hovold wrote:
> >> The example regulator child nodes do not have unit addresses so drop the
> >> incorrect '#address-cells' and '#size-cells' properties from the parent
> >> node.
> >> regulators {
> >> - #address-cells = <1>;
> >> - #size-cells = <0>;
> >> -
> >
> > It's the right fix, but I have to wonder why these are not schema
> > errors? Seems like something in the schemas needs fixing.
>
> Good point. The fix is just not sufficient. This binding explicitly
> allow it, so it should be removed there as well.
Ah, I missed that. Now fixed up in v2.
Johan