2023-12-01 10:27:59

by Pin-yen Lin

[permalink] [raw]
Subject: [PATCH v3] mmc: mtk-sd: Increase the verbosity of msdc_track_cmd_data

This log message is necessary for debugging, so enable it by default to
debug issues that are hard to reproduce locally.

Signed-off-by: Pin-yen Lin <[email protected]>

---

Changes in v3:
- Only print the warning when -ETIMEDOUT or not in tuning process

Changes in v2:
- Use dev_warn() instead of dev_err()

drivers/mmc/host/mtk-sd.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 97f7c3d4be6e..6ae5e0a9fca9 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1149,9 +1149,11 @@ static void msdc_recheck_sdio_irq(struct msdc_host *host)

static void msdc_track_cmd_data(struct msdc_host *host, struct mmc_command *cmd)
{
- if (host->error)
- dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n",
- __func__, cmd->opcode, cmd->arg, host->error);
+ if (host->error &&
+ ((!mmc_op_tuning(cmd->opcode) && !host->hs400_tuning) ||
+ cmd->error == -ETIMEDOUT))
+ dev_warn(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n",
+ __func__, cmd->opcode, cmd->arg, host->error);
}

static void msdc_request_done(struct msdc_host *host, struct mmc_request *mrq)
--
2.43.0.rc2.451.g8631bc7472-goog


2023-12-02 02:08:37

by Wenbin Mei (梅文彬)

[permalink] [raw]
Subject: Re: [PATCH v3] mmc: mtk-sd: Increase the verbosity of msdc_track_cmd_data

On Fri, 2023-12-01 at 18:26 +0800, Pin-yen Lin wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> This log message is necessary for debugging, so enable it by default
> to
> debug issues that are hard to reproduce locally.
>
> Signed-off-by: Pin-yen Lin <[email protected]>
>
Reviewed-by: Wenbin Mei <[email protected]>
> ---
>
> Changes in v3:
> - Only print the warning when -ETIMEDOUT or not in tuning process
>
> Changes in v2:
> - Use dev_warn() instead of dev_err()
>
> drivers/mmc/host/mtk-sd.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 97f7c3d4be6e..6ae5e0a9fca9 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1149,9 +1149,11 @@ static void msdc_recheck_sdio_irq(struct
> msdc_host *host)
>
> static void msdc_track_cmd_data(struct msdc_host *host, struct
> mmc_command *cmd)
> {
> - if (host->error)
> - dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host-
> >error=0x%08X\n",
> - __func__, cmd->opcode, cmd->arg, host->error);
> + if (host->error &&
> + ((!mmc_op_tuning(cmd->opcode) && !host->hs400_tuning) ||
> + cmd->error == -ETIMEDOUT))
> + dev_warn(host->dev, "%s: cmd=%d arg=%08X; host-
> >error=0x%08X\n",
> + __func__, cmd->opcode, cmd->arg, host->error);
> }
>
> static void msdc_request_done(struct msdc_host *host, struct
> mmc_request *mrq)
> --
> 2.43.0.rc2.451.g8631bc7472-goog
>

Subject: Re: [PATCH v3] mmc: mtk-sd: Increase the verbosity of msdc_track_cmd_data

Il 01/12/23 11:26, Pin-yen Lin ha scritto:
> This log message is necessary for debugging, so enable it by default to
> debug issues that are hard to reproduce locally.
>
> Signed-off-by: Pin-yen Lin <[email protected]>
>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>


2023-12-07 14:02:11

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH v3] mmc: mtk-sd: Increase the verbosity of msdc_track_cmd_data

On Fri, 1 Dec 2023 at 11:27, Pin-yen Lin <[email protected]> wrote:
>
> This log message is necessary for debugging, so enable it by default to
> debug issues that are hard to reproduce locally.
>
> Signed-off-by: Pin-yen Lin <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


>
> ---
>
> Changes in v3:
> - Only print the warning when -ETIMEDOUT or not in tuning process
>
> Changes in v2:
> - Use dev_warn() instead of dev_err()
>
> drivers/mmc/host/mtk-sd.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 97f7c3d4be6e..6ae5e0a9fca9 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1149,9 +1149,11 @@ static void msdc_recheck_sdio_irq(struct msdc_host *host)
>
> static void msdc_track_cmd_data(struct msdc_host *host, struct mmc_command *cmd)
> {
> - if (host->error)
> - dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n",
> - __func__, cmd->opcode, cmd->arg, host->error);
> + if (host->error &&
> + ((!mmc_op_tuning(cmd->opcode) && !host->hs400_tuning) ||
> + cmd->error == -ETIMEDOUT))
> + dev_warn(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n",
> + __func__, cmd->opcode, cmd->arg, host->error);
> }
>
> static void msdc_request_done(struct msdc_host *host, struct mmc_request *mrq)
> --
> 2.43.0.rc2.451.g8631bc7472-goog
>