LinuxLists.cc - Non-existing CONFIG_ options are used in source code

2023-09-13 09:29:55

Subject: Non-existing CONFIG_ options are used in source code

The following configuration options are not defined
(they may have been deleted or not yet added)
but are used in the source files.

Is there something in these that might need fixing?

===============================================
1. CONFIG_NETFS_DEBUG
fs/netfs/internal.h:122:#elif defined(CONFIG_NETFS_DEBUG)

2. CONFIG_SSB_DEBUG
include/linux/ssb/ssb.h:626:#ifdef CONFIG_SSB_DEBUG

3. CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
drivers/crypto/aspeed/aspeed-hace-crypto.c:19:#ifdef CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
===============================================

Best regards,
Yanjie Ren
Ying Sun

2023-12-01 18:11:03

by Michael Büsch

[permalink] [raw]

Subject: Re: Non-existing CONFIG_ options are used in source code

On Mon, 13 Nov 2023 20:52:03 -0800
Randy Dunlap <[email protected]> wrote:

> On 9/13/23 02:29, [email protected] wrote:
> > The following configuration options are not defined
> > (they may have been deleted or not yet added)
> > but are used in the source files.
> >
> > Is there something in these that might need fixing?
> >
> > ===============================================
> > 1. CONFIG_NETFS_DEBUG
> > fs/netfs/internal.h:122:#elif defined(CONFIG_NETFS_DEBUG)
> >
> > 2. CONFIG_SSB_DEBUG
> > include/linux/ssb/ssb.h:626:#ifdef CONFIG_SSB_DEBUG
> >
> > 3. CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
> > drivers/crypto/aspeed/aspeed-hace-crypto.c:19:#ifdef
> > CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
> > ===============================================
>
> Yes, please send separate patches to remove each of them.

I agree for CONFIG_SSB_DEBUG.

The function __ssb_dma_not_implemented() where CONFIG_SSB_DEBUG is used
can be removed and the switch-default where __ssb_dma_not_implemented()
is called can also be removed.

--
Michael Büsch
https://bues.ch/

Attachments:

(No filename) (849.00 B)
OpenPGP digital signature