2023-12-01 19:29:45

by Jason Gunthorpe

[permalink] [raw]
Subject: Re: [PATCH v7 09/12] iommu: Make iommu_queue_iopf() more generic

On Wed, Nov 15, 2023 at 11:02:23AM +0800, Lu Baolu wrote:
> Make iommu_queue_iopf() more generic by making the iopf_group a minimal
> set of iopf's that an iopf handler of domain should handle and respond
> to. Add domain parameter to struct iopf_group so that the handler can
> retrieve and use it directly.
>
> Change iommu_queue_iopf() to forward groups of iopf's to the domain's
> iopf handler. This is also a necessary step to decouple the sva iopf
> handling code from this interface.
>
> Signed-off-by: Lu Baolu <[email protected]>
> Reviewed-by: Kevin Tian <[email protected]>
> Tested-by: Yan Zhao <[email protected]>
> ---
> include/linux/iommu.h | 4 +--
> drivers/iommu/iommu-sva.h | 6 ++---
> drivers/iommu/io-pgfault.c | 55 +++++++++++++++++++++++++++++---------
> drivers/iommu/iommu-sva.c | 3 +--
> 4 files changed, 48 insertions(+), 20 deletions(-)

Reviewed-by: Jason Gunthorpe <[email protected]>

Jason