The dtschema treats now properties with '-pascal' suffix as standard one
and already defines $ref for them, thus the $ref should be dropped from
the bindings.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
dtschema change was merged:
https://github.com/devicetree-org/dt-schema/commit/2a1708dcf4ff0b25c4ec46304d6d6cc655c3e635
but not yet released as new dtschema version.
This change should be applied once new dtschema version is released or
Rob says otherwise.
---
.../devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml | 2 --
1 file changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
index b31f8120f14e..d9e903fbfd99 100644
--- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
+++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
@@ -53,12 +53,10 @@ properties:
honeywell,pmin-pascal:
description:
Minimum pressure value the sensor can measure in pascal.
- $ref: /schemas/types.yaml#/definitions/uint32
honeywell,pmax-pascal:
description:
Maximum pressure value the sensor can measure in pascal.
- $ref: /schemas/types.yaml#/definitions/uint32
honeywell,transfer-function:
description: |
--
2.34.1
On Wed, 29 Nov 2023 12:10:41 +0100, Krzysztof Kozlowski wrote:
> The dtschema treats now properties with '-pascal' suffix as standard one
> and already defines $ref for them, thus the $ref should be dropped from
> the bindings.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> dtschema change was merged:
> https://github.com/devicetree-org/dt-schema/commit/2a1708dcf4ff0b25c4ec46304d6d6cc655c3e635
> but not yet released as new dtschema version.
>
> This change should be applied once new dtschema version is released or
> Rob says otherwise.
> ---
> .../devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml: honeywell,pmin-pascal: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml: honeywell,pmax-pascal: missing type definition
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
On 29/11/2023 13:27, Rob Herring wrote:
>
> On Wed, 29 Nov 2023 12:10:41 +0100, Krzysztof Kozlowski wrote:
>> The dtschema treats now properties with '-pascal' suffix as standard one
>> and already defines $ref for them, thus the $ref should be dropped from
>> the bindings.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>
>> ---
>>
>> dtschema change was merged:
>> https://github.com/devicetree-org/dt-schema/commit/2a1708dcf4ff0b25c4ec46304d6d6cc655c3e635
>> but not yet released as new dtschema version.
>>
>> This change should be applied once new dtschema version is released or
>> Rob says otherwise.
>> ---
>> .../devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml | 2 --
>> 1 file changed, 2 deletions(-)
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml: honeywell,pmin-pascal: missing type definition
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml: honeywell,pmax-pascal: missing type definition
>
That's expected, depends on the dtschema change.
Best regards,
Krzysztof
On Wed, Nov 29, 2023 at 6:29 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 29/11/2023 13:27, Rob Herring wrote:
> >
> > On Wed, 29 Nov 2023 12:10:41 +0100, Krzysztof Kozlowski wrote:
> >> The dtschema treats now properties with '-pascal' suffix as standard one
> >> and already defines $ref for them, thus the $ref should be dropped from
> >> the bindings.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> >>
> >> ---
> >>
> >> dtschema change was merged:
> >> https://github.com/devicetree-org/dt-schema/commit/2a1708dcf4ff0b25c4ec46304d6d6cc655c3e635
> >> but not yet released as new dtschema version.
> >>
> >> This change should be applied once new dtschema version is released or
> >> Rob says otherwise.
> >> ---
> >> .../devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml | 2 --
> >> 1 file changed, 2 deletions(-)
> >>
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml: honeywell,pmin-pascal: missing type definition
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml: honeywell,pmax-pascal: missing type definition
> >
>
> That's expected, depends on the dtschema change.
Well, it wasn't because dtschema version used is git tree. However,
the CI job was using master rather than main branch. master falls
behind when I use the web interface... Now fixed the CI job to use
main.
Rob
On Wed, Nov 29, 2023 at 12:10:41PM +0100, Krzysztof Kozlowski wrote:
> The dtschema treats now properties with '-pascal' suffix as standard one
> and already defines $ref for them, thus the $ref should be dropped from
> the bindings.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> dtschema change was merged:
> https://github.com/devicetree-org/dt-schema/commit/2a1708dcf4ff0b25c4ec46304d6d6cc655c3e635
> but not yet released as new dtschema version.
>
> This change should be applied once new dtschema version is released or
> Rob says otherwise.
I've made a release, so go ahead and apply this.
Acked-by: Rob Herring <[email protected]>
On Fri, 1 Dec 2023 16:35:47 -0600
Rob Herring <[email protected]> wrote:
> On Wed, Nov 29, 2023 at 12:10:41PM +0100, Krzysztof Kozlowski wrote:
> > The dtschema treats now properties with '-pascal' suffix as standard one
> > and already defines $ref for them, thus the $ref should be dropped from
> > the bindings.
> >
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
> >
> > ---
> >
> > dtschema change was merged:
> > https://github.com/devicetree-org/dt-schema/commit/2a1708dcf4ff0b25c4ec46304d6d6cc655c3e635
> > but not yet released as new dtschema version.
> >
> > This change should be applied once new dtschema version is released or
> > Rob says otherwise.
>
> I've made a release, so go ahead and apply this.
>
> Acked-by: Rob Herring <[email protected]>
Applied to the togreg branch of iio.git and initially pushed out as testing for 0-day
etc to poke at it
Thanks,
Jonathan