2023-12-05 09:44:02

by Yunshui Jiang

Subject: [PATCH] ocxl: fix driver function comment typo

Reported-by: k2ci <[email protected]>
Signed-off-by: yunshui <[email protected]>
---
include/misc/ocxl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/misc/ocxl.h b/include/misc/ocxl.h
index 3ed736da02c8..ef7d26009a36 100644
--- a/include/misc/ocxl.h
+++ b/include/misc/ocxl.h
@@ -324,7 +324,7 @@ int ocxl_global_mmio_clear32(struct ocxl_afu *afu, size_t offset,
int ocxl_global_mmio_clear64(struct ocxl_afu *afu, size_t offset,
enum ocxl_endian endian, u64 mask);

-// Functions left here are for compatibility with the cxlflash driver
+// Functions left here are for compatibility with the ocxlflash driver

/*
* Read the configuration space of a function for the AFU specified by
--
2.25.1

2023-12-05 11:00:28

by Christophe Leroy

Subject: Re: [PATCH] ocxl: fix driver function comment typo

Please add a description explaining why you want to do that change.

When I grep I see cxlflash driver, I don't know what ocxlflash driver is:

$ git grep ocxl_config_read_afu
...
drivers/scsi/cxlflash/ocxl_hw.c: rc = ocxl_config_read_afu(pdev,
fcfg, acfg, 0);
drivers/scsi/cxlflash/ocxl_hw.c: dev_err(dev, "%s:
ocxl_config_read_afu failed rc=%d\n",
include/misc/ocxl.h:int ocxl_config_read_afu(struct pci_dev *dev,

Christophe


Le 05/12/2023 à 10:43, jiangyunshui a écrit :
> [Vous ne recevez pas souvent de courriers de [email protected]. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> Reported-by: k2ci <[email protected]>
> Signed-off-by: yunshui <[email protected]>
> ---
> include/misc/ocxl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/misc/ocxl.h b/include/misc/ocxl.h
> index 3ed736da02c8..ef7d26009a36 100644
> --- a/include/misc/ocxl.h
> +++ b/include/misc/ocxl.h
> @@ -324,7 +324,7 @@ int ocxl_global_mmio_clear32(struct ocxl_afu *afu, size_t offset,
> int ocxl_global_mmio_clear64(struct ocxl_afu *afu, size_t offset,
> enum ocxl_endian endian, u64 mask);
>
> -// Functions left here are for compatibility with the cxlflash driver
> +// Functions left here are for compatibility with the ocxlflash driver
>
> /*
> * Read the configuration space of a function for the AFU specified by
> --
> 2.25.1
>

2023-12-07 01:43:50

by Yunshui Jiang

Subject: Re: [PATCH] ocxl: fix driver function comment typo

> Date: Tue, 5 Dec 2023 11:00:16 +0000 [thread overview]
> Message-ID: <[email protected]> (raw)
> In-Reply-To: <[email protected]>

> Please add a description explaining why you want to do that change.

> When I grep I see cxlflash driver, I don't know what ocxlflash driver is:

> $ git grep ocxl_config_read_afu
> ...
> drivers/scsi/cxlflash/ocxl_hw.c: rc = ocxl_config_read_afu(pdev,
> fcfg, acfg, 0);
> drivers/scsi/cxlflash/ocxl_hw.c: dev_err(dev, "%s:
> ocxl_config_read_afu failed rc=%d\n",
> include/misc/ocxl.h:int ocxl_config_read_afu(struct pci_dev *dev,

> Christophe

I checked my commit again and found I'd mismatched the driver's name with other things.
As you said it doesn't make sense to change cxlflash to ocxlflash.
Sorry for the inconvenience, you could just drop my commit please.
Thanks,

Yunshui

> ---
> Reported-by: k2ci <[email protected]>
> Signed-off-by: yunshui <[email protected]>
> ---
> include/misc/ocxl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/misc/ocxl.h b/include/misc/ocxl.h
> index 3ed736da02c8..ef7d26009a36 100644
> --- a/include/misc/ocxl.h
> +++ b/include/misc/ocxl.h
> @@ -324,7 +324,7 @@ int ocxl_global_mmio_clear32(struct ocxl_afu *afu, size_t offset,
> int ocxl_global_mmio_clear64(struct ocxl_afu *afu, size_t offset,
> enum ocxl_endian endian, u64 mask);
>
> -// Functions left here are for compatibility with the cxlflash driver
> +// Functions left here are for compatibility with the ocxlflash driver
>
> /*
> * Read the configuration space of a function for the AFU specified by
> --
> 2.25.1
>