2023-12-05 16:02:34

by Zenghui Yu

[permalink] [raw]
Subject: [PATCH] arm64: Delete the zero_za macro

zero_za was introduced in commit ca8a4ebcff44 ("arm64/sme: Manually encode
SME instructions") but doesn't appear to have any in kernel user. Drop it.

Signed-off-by: Zenghui Yu <[email protected]>
---
arch/arm64/include/asm/fpsimdmacros.h | 8 --------
1 file changed, 8 deletions(-)

diff --git a/arch/arm64/include/asm/fpsimdmacros.h b/arch/arm64/include/asm/fpsimdmacros.h
index cdf6a35e3994..cda81d009c9b 100644
--- a/arch/arm64/include/asm/fpsimdmacros.h
+++ b/arch/arm64/include/asm/fpsimdmacros.h
@@ -242,14 +242,6 @@
| (\nx << 5)
.endm

-/*
- * Zero the entire ZA array
- * ZERO ZA
- */
-.macro zero_za
- .inst 0xc00800ff
-.endm
-
.macro __for from:req, to:req
.if (\from) == (\to)
_for__body %\from
--
2.33.0


2023-12-05 16:57:34

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] arm64: Delete the zero_za macro

On Wed, Dec 06, 2023 at 12:01:40AM +0800, Zenghui Yu wrote:
> zero_za was introduced in commit ca8a4ebcff44 ("arm64/sme: Manually encode
> SME instructions") but doesn't appear to have any in kernel user. Drop it.
>
> Signed-off-by: Zenghui Yu <[email protected]>

You're right that this isn't used, though OTOH it's not exactly doing
any harm either and as a macro doesn't inflate the image or anything.

Acked-by: Mark Brown <[email protected]>


Attachments:
(No filename) (462.00 B)
signature.asc (499.00 B)
Download all attachments

2023-12-11 20:28:24

by Will Deacon

[permalink] [raw]
Subject: Re: [PATCH] arm64: Delete the zero_za macro

On Wed, 6 Dec 2023 00:01:40 +0800, Zenghui Yu wrote:
> zero_za was introduced in commit ca8a4ebcff44 ("arm64/sme: Manually encode
> SME instructions") but doesn't appear to have any in kernel user. Drop it.
>
>

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: Delete the zero_za macro
https://git.kernel.org/arm64/c/86d1921c9d5a

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev