2023-12-06 03:14:31

by Zhao Mengmeng

Subject: [PATCH v1] selftests/sgx: Skip non X86_64 platform

From: Zhao Mengmeng <[email protected]>

When building whole selftests on arm64, rsync gives an erorr about sgx:

rsync: [sender] link_stat "/root/linux-next/tools/testing/selftests/sgx/test_encl.elf" failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1327) [sender=3.2.5]

The root casue is sgx only used on X86_64, and shall be skipped on other
platforms.

Fix this by moving TEST_CUSTOM_PROGS and TEST_FILES inside the if check,
then the build result will be "Skipping non-existent dir: sgx".

Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX")
Signed-off-by: Zhao Mengmeng <[email protected]>
---
tools/testing/selftests/sgx/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/sgx/Makefile b/tools/testing/selftests/sgx/Makefile
index 50aab6b57da3..01abe4969b0f 100644
--- a/tools/testing/selftests/sgx/Makefile
+++ b/tools/testing/selftests/sgx/Makefile
@@ -16,10 +16,10 @@ HOST_CFLAGS := -Wall -Werror -g $(INCLUDES) -fPIC -z noexecstack
ENCL_CFLAGS := -Wall -Werror -static -nostdlib -nostartfiles -fPIC \
-fno-stack-protector -mrdrnd $(INCLUDES)

+ifeq ($(CAN_BUILD_X86_64), 1)
TEST_CUSTOM_PROGS := $(OUTPUT)/test_sgx
TEST_FILES := $(OUTPUT)/test_encl.elf

-ifeq ($(CAN_BUILD_X86_64), 1)
all: $(TEST_CUSTOM_PROGS) $(OUTPUT)/test_encl.elf
endif

--
2.38.1

2023-12-07 04:32:23

by Jarkko Sakkinen

Subject: Re: [PATCH v1] selftests/sgx: Skip non X86_64 platform

On Tue, 2023-12-05 at 21:56 -0500, Zhao Mengmeng wrote:
> From: Zhao Mengmeng <[email protected]>
>
> When building whole selftests on arm64, rsync gives an erorr about
> sgx:
>
> rsync: [sender] link_stat "/root/linux-
> next/tools/testing/selftests/sgx/test_encl.elf" failed: No such file
> or directory (2)
> rsync error: some files/attrs were not transferred (see previous
> errors) (code 23) at main.c(1327) [sender=3.2.5]
>
> The root casue is sgx only used on X86_64, and shall be skipped on
> other
> platforms.
>
> Fix this by moving TEST_CUSTOM_PROGS and TEST_FILES inside the if
> check,
> then the build result will be "Skipping non-existent dir: sgx".
>
> Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX")
> Signed-off-by: Zhao Mengmeng <[email protected]>
> ---
>  tools/testing/selftests/sgx/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/sgx/Makefile
> b/tools/testing/selftests/sgx/Makefile
> index 50aab6b57da3..01abe4969b0f 100644
> --- a/tools/testing/selftests/sgx/Makefile
> +++ b/tools/testing/selftests/sgx/Makefile
> @@ -16,10 +16,10 @@ HOST_CFLAGS := -Wall -Werror -g $(INCLUDES) -fPIC
> -z noexecstack
>  ENCL_CFLAGS := -Wall -Werror -static -nostdlib -nostartfiles -fPIC \
>          -fno-stack-protector -mrdrnd $(INCLUDES)
>  
> +ifeq ($(CAN_BUILD_X86_64), 1)
>  TEST_CUSTOM_PROGS := $(OUTPUT)/test_sgx
>  TEST_FILES := $(OUTPUT)/test_encl.elf
>  
> -ifeq ($(CAN_BUILD_X86_64), 1)
>  all: $(TEST_CUSTOM_PROGS) $(OUTPUT)/test_encl.elf
>  endif
>  

Reviewed-by: Jarkko Sakkinen <[email protected]>

BR, Jarkko