Hello All,
There has been ongoing discussion[1] surrounding the issue of having K3
prefix included in the compatible for dt bindings. This series removes this
prefix from both the device tree binding as well as the driver. Updating
the binding will not break the ABI at this point as the driver is still
only in linux-next.
Changes in v2:
- Include more context surrounding patch
- Fix style issues addressed by Krzysztof
[1] https://lore.kernel.org/all/20231201063309.tingjc3cjhsqb6r7@confusing/
Brandon Brnich (2):
dt-bindings: media: Remove K3 Family Prefix from Compatible
media: chips-media: wave5: Remove K3 References
Documentation/devicetree/bindings/media/cnm,wave521c.yaml | 2 +-
drivers/media/platform/chips-media/wave5/wave5-vpu.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.34.1
Change compatible string to match dt bindings for TI devices. K3 family
prefix should not be included as it deviates from naming convention.
Fixes: 9707a6254a8a ("media: chips-media: wave5: Add the v4l2 layer")
Reported-by: Geert Uytterhoeven <[email protected]>
Closes: https://lore.kernel.org/all/CAMuHMdUYOq=q1j=d+Eac28hthOUAaNUkuvxmRu-mUN1pLKq69g@mail.gmail.com/
Signed-off-by: Brandon Brnich <[email protected]>
---
V1 -> V2: Fix style issues in commit message
drivers/media/platform/chips-media/wave5/wave5-vpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu.c b/drivers/media/platform/chips-media/wave5/wave5-vpu.c
index bfe4caa79cc9..0d90b5820bef 100644
--- a/drivers/media/platform/chips-media/wave5/wave5-vpu.c
+++ b/drivers/media/platform/chips-media/wave5/wave5-vpu.c
@@ -272,7 +272,7 @@ static const struct wave5_match_data ti_wave521c_data = {
};
static const struct of_device_id wave5_dt_ids[] = {
- { .compatible = "ti,k3-j721s2-wave521c", .data = &ti_wave521c_data },
+ { .compatible = "ti,j721s2-wave521c", .data = &ti_wave521c_data },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, wave5_dt_ids);
--
2.34.1
As this is a DT call made by TI, there is not much to review.
Le mercredi 06 décembre 2023 à 12:52 -0600, Brandon Brnich a écrit :
> Change compatible string to match dt bindings for TI devices. K3 family
> prefix should not be included as it deviates from naming convention.
>
> Fixes: 9707a6254a8a ("media: chips-media: wave5: Add the v4l2 layer")
> Reported-by: Geert Uytterhoeven <[email protected]>
> Closes: https://lore.kernel.org/all/CAMuHMdUYOq=q1j=d+Eac28hthOUAaNUkuvxmRu-mUN1pLKq69g@mail.gmail.com/
> Signed-off-by: Brandon Brnich <[email protected]>
This should just be picked.
Acked-by: Nicolas Dufresne <[email protected]>
> ---
> V1 -> V2: Fix style issues in commit message
>
> drivers/media/platform/chips-media/wave5/wave5-vpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu.c b/drivers/media/platform/chips-media/wave5/wave5-vpu.c
> index bfe4caa79cc9..0d90b5820bef 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-vpu.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu.c
> @@ -272,7 +272,7 @@ static const struct wave5_match_data ti_wave521c_data = {
> };
>
> static const struct of_device_id wave5_dt_ids[] = {
> - { .compatible = "ti,k3-j721s2-wave521c", .data = &ti_wave521c_data },
> + { .compatible = "ti,j721s2-wave521c", .data = &ti_wave521c_data },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, wave5_dt_ids);
On 12:52-20231206, Brandon Brnich wrote:
> Change compatible string to match dt bindings for TI devices. K3 family
> prefix should not be included as it deviates from naming convention.
>
> Fixes: 9707a6254a8a ("media: chips-media: wave5: Add the v4l2 layer")
> Reported-by: Geert Uytterhoeven <[email protected]>
> Closes: https://lore.kernel.org/all/CAMuHMdUYOq=q1j=d+Eac28hthOUAaNUkuvxmRu-mUN1pLKq69g@mail.gmail.com/
> Signed-off-by: Brandon Brnich <[email protected]>
> ---
> V1 -> V2: Fix style issues in commit message
>
> drivers/media/platform/chips-media/wave5/wave5-vpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu.c b/drivers/media/platform/chips-media/wave5/wave5-vpu.c
> index bfe4caa79cc9..0d90b5820bef 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-vpu.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu.c
> @@ -272,7 +272,7 @@ static const struct wave5_match_data ti_wave521c_data = {
> };
>
> static const struct of_device_id wave5_dt_ids[] = {
> - { .compatible = "ti,k3-j721s2-wave521c", .data = &ti_wave521c_data },
> + { .compatible = "ti,j721s2-wave521c", .data = &ti_wave521c_data },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, wave5_dt_ids);
> --
> 2.34.1
>
Reviewed-by: Nishanth Menon <[email protected]>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D