2023-11-28 21:36:02

by Sjoerd Simons

Subject: [PATCH v2 2/3] bus: moxtet: Add spi device table

The moxtet module fails to auto-load on. Add a SPI id table to
allow it to do so.

Signed-off-by: Sjoerd Simons <[email protected]>
Cc: [email protected]

---

(no changes since v1)

drivers/bus/moxtet.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c
index 48c18f95660a..e384fbc6c1d9 100644
--- a/drivers/bus/moxtet.c
+++ b/drivers/bus/moxtet.c
@@ -830,6 +830,12 @@ static void moxtet_remove(struct spi_device *spi)
mutex_destroy(&moxtet->lock);
}

+static const struct spi_device_id moxtet_spi_ids[] = {
+ { "moxtet" },
+ { },
+};
+MODULE_DEVICE_TABLE(spi, moxtet_spi_ids);
+
static const struct of_device_id moxtet_dt_ids[] = {
{ .compatible = "cznic,moxtet" },
{},
@@ -841,6 +847,7 @@ static struct spi_driver moxtet_spi_driver = {
.name = "moxtet",
.of_match_table = moxtet_dt_ids,
},
+ .id_table = moxtet_spi_ids,
.probe = moxtet_probe,
.remove = moxtet_remove,
};
--
2.43.0

2023-12-07 14:43:39

by Marek Behún

Subject: Re: [PATCH v2 2/3] bus: moxtet: Add spi device table

On Tue, 28 Nov 2023 22:35:05 +0100
Sjoerd Simons <[email protected]> wrote:

> The moxtet module fails to auto-load on. Add a SPI id table to
> allow it to do so.
>
> Signed-off-by: Sjoerd Simons <[email protected]>
> Cc: [email protected]
>
> ---
>
> (no changes since v1)
>
> drivers/bus/moxtet.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c
> index 48c18f95660a..e384fbc6c1d9 100644
> --- a/drivers/bus/moxtet.c
> +++ b/drivers/bus/moxtet.c
> @@ -830,6 +830,12 @@ static void moxtet_remove(struct spi_device *spi)
> mutex_destroy(&moxtet->lock);
> }
>
> +static const struct spi_device_id moxtet_spi_ids[] = {
> + { "moxtet" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(spi, moxtet_spi_ids);
> +
> static const struct of_device_id moxtet_dt_ids[] = {
> { .compatible = "cznic,moxtet" },
> {},
> @@ -841,6 +847,7 @@ static struct spi_driver moxtet_spi_driver = {
> .name = "moxtet",
> .of_match_table = moxtet_dt_ids,
> },
> + .id_table = moxtet_spi_ids,
> .probe = moxtet_probe,
> .remove = moxtet_remove,
> };

Reviewed-by: Marek Behún <[email protected]>