2023-12-08 01:58:09

by Baolu Lu

Subject: [PATCH v2] iommu: Set owner token to SVA domain

Commit a9c362db3920 ("iommu: Validate that devices match domains") added
an owner token to the iommu_domain. This token is checked during domain
attachment to RID or PASID through the generic iommu interfaces.

The SVA domains are attached to PASIDs through those iommu interfaces.
Therefore, they require the owner token to be set during allocation.
Otherwise, they fail to attach.

Set the owner token for SVA domains.

Fixes: a9c362db3920 ("iommu: Validate that devices match domains")
Cc: Robin Murphy <[email protected]>
Signed-off-by: Lu Baolu <[email protected]>
---
drivers/iommu/iommu.c | 1 +
1 file changed, 1 insertion(+)

Change log:
v2:
- The user domain allocation path does the right thing. Hence no need
to fix anything.
v1:
- https://lore.kernel.org/linux-iommu/[email protected]/

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 0d25468d53a6..d0a28667479a 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -3617,6 +3617,7 @@ struct iommu_domain *iommu_sva_domain_alloc(struct device *dev,
domain->type = IOMMU_DOMAIN_SVA;
mmgrab(mm);
domain->mm = mm;
+ domain->owner = ops;
domain->iopf_handler = iommu_sva_handle_iopf;
domain->fault_data = mm;

--
2.34.1

2023-12-08 11:16:18

by Robin Murphy

Subject: Re: [PATCH v2] iommu: Set owner token to SVA domain

On 08/12/2023 1:53 am, Lu Baolu wrote:
> Commit a9c362db3920 ("iommu: Validate that devices match domains") added
> an owner token to the iommu_domain. This token is checked during domain
> attachment to RID or PASID through the generic iommu interfaces.
>
> The SVA domains are attached to PASIDs through those iommu interfaces.
> Therefore, they require the owner token to be set during allocation.
> Otherwise, they fail to attach.
>
> Set the owner token for SVA domains.

Reviewed-by: Robin Murphy <[email protected]>

> Fixes: a9c362db3920 ("iommu: Validate that devices match domains")
> Cc: Robin Murphy <[email protected]>
> Signed-off-by: Lu Baolu <[email protected]>
> ---
> drivers/iommu/iommu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Change log:
> v2:
> - The user domain allocation path does the right thing. Hence no need
> to fix anything.
> v1:
> - https://lore.kernel.org/linux-iommu/[email protected]/
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 0d25468d53a6..d0a28667479a 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -3617,6 +3617,7 @@ struct iommu_domain *iommu_sva_domain_alloc(struct device *dev,
> domain->type = IOMMU_DOMAIN_SVA;
> mmgrab(mm);
> domain->mm = mm;
> + domain->owner = ops;
> domain->iopf_handler = iommu_sva_handle_iopf;
> domain->fault_data = mm;
>

2023-12-08 13:40:39

by Jason Gunthorpe

Subject: Re: [PATCH v2] iommu: Set owner token to SVA domain

On Fri, Dec 08, 2023 at 09:53:14AM +0800, Lu Baolu wrote:
> Commit a9c362db3920 ("iommu: Validate that devices match domains") added
> an owner token to the iommu_domain. This token is checked during domain
> attachment to RID or PASID through the generic iommu interfaces.
>
> The SVA domains are attached to PASIDs through those iommu interfaces.
> Therefore, they require the owner token to be set during allocation.
> Otherwise, they fail to attach.
>
> Set the owner token for SVA domains.
>
> Fixes: a9c362db3920 ("iommu: Validate that devices match domains")
> Cc: Robin Murphy <[email protected]>
> Signed-off-by: Lu Baolu <[email protected]>
> ---
> drivers/iommu/iommu.c | 1 +
> 1 file changed, 1 insertion(+)

Reviewed-by: Jason Gunthorpe <[email protected]>

Jason

2023-12-12 09:17:14

by Joerg Roedel

Subject: Re: [PATCH v2] iommu: Set owner token to SVA domain

On Fri, Dec 08, 2023 at 09:53:14AM +0800, Lu Baolu wrote:
> drivers/iommu/iommu.c | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.