2023-12-08 13:49:16

by Ilpo Järvinen

Subject: [PATCH 1/1] platform/x86: ips: Remove unused debug code

Remove unused debug code inside #if 0 ... #endif.

Signed-off-by: Ilpo Järvinen <[email protected]>
---
drivers/platform/x86/intel_ips.c | 33 --------------------------------
1 file changed, 33 deletions(-)

diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
index 4dfdbfca6841..e26e7e14c44c 100644
--- a/drivers/platform/x86/intel_ips.c
+++ b/drivers/platform/x86/intel_ips.c
@@ -1105,39 +1105,6 @@ static int ips_monitor(void *data)
return 0;
}

-#if 0
-#define THM_DUMPW(reg) \
- { \
- u16 val = thm_readw(reg); \
- dev_dbg(ips->dev, #reg ": 0x%04x\n", val); \
- }
-#define THM_DUMPL(reg) \
- { \
- u32 val = thm_readl(reg); \
- dev_dbg(ips->dev, #reg ": 0x%08x\n", val); \
- }
-#define THM_DUMPQ(reg) \
- { \
- u64 val = thm_readq(reg); \
- dev_dbg(ips->dev, #reg ": 0x%016x\n", val); \
- }
-
-static void dump_thermal_info(struct ips_driver *ips)
-{
- u16 ptl;
-
- ptl = thm_readw(THM_PTL);
- dev_dbg(ips->dev, "Processor temp limit: %d\n", ptl);
-
- THM_DUMPW(THM_CTA);
- THM_DUMPW(THM_TRC);
- THM_DUMPW(THM_CTV1);
- THM_DUMPL(THM_STS);
- THM_DUMPW(THM_PTV);
- THM_DUMPQ(THM_MGTV);
-}
-#endif
-
/**
* ips_irq_handler - handle temperature triggers and other IPS events
* @irq: irq number
--
2.30.2

2023-12-11 10:11:44

by Hans de Goede

Subject: Re: [PATCH 1/1] platform/x86: ips: Remove unused debug code

Hi,

On 12/8/23 14:48, Ilpo Järvinen wrote:
> Remove unused debug code inside #if 0 ... #endif.
>
> Signed-off-by: Ilpo Järvinen <[email protected]>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
> drivers/platform/x86/intel_ips.c | 33 --------------------------------
> 1 file changed, 33 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
> index 4dfdbfca6841..e26e7e14c44c 100644
> --- a/drivers/platform/x86/intel_ips.c
> +++ b/drivers/platform/x86/intel_ips.c
> @@ -1105,39 +1105,6 @@ static int ips_monitor(void *data)
> return 0;
> }
>
> -#if 0
> -#define THM_DUMPW(reg) \
> - { \
> - u16 val = thm_readw(reg); \
> - dev_dbg(ips->dev, #reg ": 0x%04x\n", val); \
> - }
> -#define THM_DUMPL(reg) \
> - { \
> - u32 val = thm_readl(reg); \
> - dev_dbg(ips->dev, #reg ": 0x%08x\n", val); \
> - }
> -#define THM_DUMPQ(reg) \
> - { \
> - u64 val = thm_readq(reg); \
> - dev_dbg(ips->dev, #reg ": 0x%016x\n", val); \
> - }
> -
> -static void dump_thermal_info(struct ips_driver *ips)
> -{
> - u16 ptl;
> -
> - ptl = thm_readw(THM_PTL);
> - dev_dbg(ips->dev, "Processor temp limit: %d\n", ptl);
> -
> - THM_DUMPW(THM_CTA);
> - THM_DUMPW(THM_TRC);
> - THM_DUMPW(THM_CTV1);
> - THM_DUMPL(THM_STS);
> - THM_DUMPW(THM_PTV);
> - THM_DUMPQ(THM_MGTV);
> -}
> -#endif
> -
> /**
> * ips_irq_handler - handle temperature triggers and other IPS events
> * @irq: irq number