2023-12-12 00:16:46

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build warning after merge of the sound-asoc tree

---

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/cs42l43.c:142:6: warning: no previous prototype for 'cs42l43_hp_ilimit_clear_work' [-Wmissing-prototypes]
142 | void cs42l43_hp_ilimit_clear_work(struct work_struct *work)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/cs42l43.c:159:6: warning: no previous prototype for 'cs42l43_hp_ilimit_work' [-Wmissing-prototypes]
159 | void cs42l43_hp_ilimit_work(struct work_struct *work)
| ^~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

bbbc18d8c27c ("ASoC: cs42l43: Allow HP amp to cool off after current limit")

Maybe they should just be static?

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2023-12-12 09:35:45

by Charles Keepax

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the sound-asoc tree

---

On Tue, Dec 12, 2023 at 11:16:25AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> sound/soc/codecs/cs42l43.c:142:6: warning: no previous prototype for 'cs42l43_hp_ilimit_clear_work' [-Wmissing-prototypes]
> 142 | void cs42l43_hp_ilimit_clear_work(struct work_struct *work)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/codecs/cs42l43.c:159:6: warning: no previous prototype for 'cs42l43_hp_ilimit_work' [-Wmissing-prototypes]
> 159 | void cs42l43_hp_ilimit_work(struct work_struct *work)
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> bbbc18d8c27c ("ASoC: cs42l43: Allow HP amp to cool off after current limit")
>
> Maybe they should just be static?
>

Yeah they should be static sorry, will send a patch today.

Thanks,
Charles