2023-12-13 21:54:38

by Jerry Hoemann

Subject: [PATCH v2 3/3] watchdog/hpwdt: Remove unused variable

Remove the unused variable ilo5.

Signed-off-by: Jerry Hoemann <[email protected]>
---
drivers/watchdog/hpwdt.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index d5c0aa3ef069..138dc8d8ca3d 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -33,7 +33,6 @@
#define DEFAULT_MARGIN 30
#define PRETIMEOUT_SEC 9

-static bool ilo5;
static unsigned int soft_margin = DEFAULT_MARGIN; /* in seconds */
static bool nowayout = WATCHDOG_NOWAYOUT;
static bool pretimeout = IS_ENABLED(CONFIG_HPWDT_NMI_DECODING);
@@ -360,9 +359,6 @@ static int hpwdt_init_one(struct pci_dev *dev,
pretimeout ? "on" : "off");
dev_info(&dev->dev, "kdumptimeout: %d.\n", kdumptimeout);

- if (dev->subsystem_vendor == PCI_VENDOR_ID_HP_3PAR)
- ilo5 = true;
-
return 0;

error_wd_register:
--
2.41.0

2023-12-13 22:14:43

by Guenter Roeck

Subject: Re: [PATCH v2 3/3] watchdog/hpwdt: Remove unused variable

On Wed, Dec 13, 2023 at 02:53:40PM -0700, Jerry Hoemann wrote:
> Remove the unused variable ilo5.
>
> Signed-off-by: Jerry Hoemann <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> drivers/watchdog/hpwdt.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index d5c0aa3ef069..138dc8d8ca3d 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -33,7 +33,6 @@
> #define DEFAULT_MARGIN 30
> #define PRETIMEOUT_SEC 9
>
> -static bool ilo5;
> static unsigned int soft_margin = DEFAULT_MARGIN; /* in seconds */
> static bool nowayout = WATCHDOG_NOWAYOUT;
> static bool pretimeout = IS_ENABLED(CONFIG_HPWDT_NMI_DECODING);
> @@ -360,9 +359,6 @@ static int hpwdt_init_one(struct pci_dev *dev,
> pretimeout ? "on" : "off");
> dev_info(&dev->dev, "kdumptimeout: %d.\n", kdumptimeout);
>
> - if (dev->subsystem_vendor == PCI_VENDOR_ID_HP_3PAR)
> - ilo5 = true;
> -
> return 0;
>
> error_wd_register:
> --
> 2.41.0
>