2023-12-13 22:18:47

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the mm-hotfixes tree

---

Hi all,

After merging the mm-hotfixes tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

lib/maple_tree.c: In function 'mas_preallocate':
lib/maple_tree.c:5506:30: error: 'struct ma_state' has no member named 'end'
5506 | if ((node_size == mas->end) && ((!mt_in_rcu(mas->tree))
| ^~

Caused by commit

84bda0b24555 ("maple_tree: do not preallocate nodes for slot stores")

I have reverted that commit for today.

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2023-12-13 23:32:00

by Liam R. Howlett

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the mm-hotfixes tree

---

* Stephen Rothwell <[email protected]> [231213 17:18]:
> Hi all,
>
> After merging the mm-hotfixes tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> lib/maple_tree.c: In function 'mas_preallocate':
> lib/maple_tree.c:5506:30: error: 'struct ma_state' has no member named 'end'
> 5506 | if ((node_size == mas->end) && ((!mt_in_rcu(mas->tree))
> | ^~
>
> Caused by commit
>
> 84bda0b24555 ("maple_tree: do not preallocate nodes for slot stores")
>
> I have reverted that commit for today.


No harm in leaving it, but akpm made a 'fixlet' for this [1]. The word
fixlet made my day. I assume this will be fix(let)ed tomorrow.

Cheers,
Liam

[1] https://lore.kernel.org/linux-mm/[email protected]/