On Thu, Dec 14, 2023 at 03:47:51PM +0100, Ante Knezic wrote:
> Indeed I do have a custom implementation for the mv88e6xxx chip, but its not
> come to state to be posted because of test/chip specifics.
>
> > I didn't notice when the selftest support was added that there is no
> > implementation in DSA drivers of custom ds->ops->self_test(). Adding
> > interfaces with no users is frowned upon, precisely because it doesn't
> > show the big picture.
>
> I was not aware of this, I apologize. If this is the case, perhaps this patch
> should wait for the first custom self test implementation and be reposted as
> a part of bigger series.
>
> Thanks,
> Ante
>
I agree this should be resubmitted with a user of the API. Looking
forward to seeing it. Thanks for the understanding.
The only thing I would want to comment on the patch as it is is to avoid
the pattern of:
if (a)
return x;
else
return y;
and formulate it as:
if (a)
return x;
return y;
instead. The "else" is redundant for an "if" that ends with a return statement.
---
pw-bot: changes-requested