2023-12-15 05:30:53

by Ghanshyam Agrawal

[permalink] [raw]
Subject: [PATCH] drivers: gpu: drm: vmwgfx: fixed typos

Fixed some typos in vmwgfx_execbuf.c

Signed-off-by: Ghanshyam Agrawal <[email protected]>
---
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
index 36987ef3fc30..272141b6164c 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
@@ -621,10 +621,10 @@ static int vmw_resources_reserve(struct vmw_sw_context *sw_context)
* @sw_context: Pointer to the software context.
* @res_type: Resource type.
* @dirty: Whether to change dirty status.
- * @converter: User-space visisble type specific information.
+ * @converter: User-space visible type specific information.
* @id_loc: Pointer to the location in the command buffer currently being parsed
* from where the user-space resource id handle is located.
- * @p_res: Pointer to pointer to resource validalidation node. Populated on
+ * @p_res: Pointer to pointer to resource validation node. Populated on
* exit.
*/
static int
--
2.25.1



2023-12-15 05:36:00

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] drivers: gpu: drm: vmwgfx: fixed typos



On 12/14/23 21:30, Ghanshyam Agrawal wrote:
> Fixed some typos in vmwgfx_execbuf.c
>
> Signed-off-by: Ghanshyam Agrawal <[email protected]>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 36987ef3fc30..272141b6164c 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -621,10 +621,10 @@ static int vmw_resources_reserve(struct vmw_sw_context *sw_context)
> * @sw_context: Pointer to the software context.
> * @res_type: Resource type.
> * @dirty: Whether to change dirty status.
> - * @converter: User-space visisble type specific information.
> + * @converter: User-space visible type specific information.

ack.

> * @id_loc: Pointer to the location in the command buffer currently being parsed
> * from where the user-space resource id handle is located.
> - * @p_res: Pointer to pointer to resource validalidation node. Populated on
> + * @p_res: Pointer to pointer to resource validation node. Populated on
> * exit.

ack.

> */
> static int

Please also fix this one:
vmwgfx_execbuf.c:1072: asynchronus ==> asynchronous

I suggest that you try codespell.

Thanks.
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html

2023-12-15 05:54:44

by Ghanshyam Agrawal

[permalink] [raw]
Subject: Re: [PATCH] drivers: gpu: drm: vmwgfx: fixed typos

On Fri, Dec 15, 2023 at 11:05 AM Randy Dunlap <[email protected]> wrote:
>
>
>
> On 12/14/23 21:30, Ghanshyam Agrawal wrote:
> > Fixed some typos in vmwgfx_execbuf.c
> >
> > Signed-off-by: Ghanshyam Agrawal <[email protected]>
> > ---
> > drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> > index 36987ef3fc30..272141b6164c 100644
> > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> > @@ -621,10 +621,10 @@ static int vmw_resources_reserve(struct vmw_sw_context *sw_context)
> > * @sw_context: Pointer to the software context.
> > * @res_type: Resource type.
> > * @dirty: Whether to change dirty status.
> > - * @converter: User-space visisble type specific information.
> > + * @converter: User-space visible type specific information.
>
> ack.
>
> > * @id_loc: Pointer to the location in the command buffer currently being parsed
> > * from where the user-space resource id handle is located.
> > - * @p_res: Pointer to pointer to resource validalidation node. Populated on
> > + * @p_res: Pointer to pointer to resource validation node. Populated on
> > * exit.
>
> ack.
>
> > */
> > static int
>
> Please also fix this one:
> vmwgfx_execbuf.c:1072: asynchronus ==> asynchronous
>
> I suggest that you try codespell.
>
> Thanks.
> --
> #Randy
> https://people.kernel.org/tglx/notes-about-netiquette
> https://subspace.kernel.org/etiquette.html

Hi Randy,

Thanks for your acknowledgements and feedback. Codespell did suggest one
more change but I am not sure if it should be applied. Let me ask someone.
I will make changes and resend the second patch.

Thanks & Regards,
Ghanshyam Agrawal