2023-12-15 13:19:07

by Paul Cercueil

[permalink] [raw]
Subject: [PATCH v2 0/5] axi-dmac: Add support for scatter-gather

Hi Vinod,

V2 of my patchset which introduces scatter-gather transfers support to
the axi-dmac driver.

I updated patch [1/5] with your feedback. Patch [4/5] was updated as
well, so that cyclic transfers are restarted properly in the EOT. This
was a bug in my V1, but it was fixed here just for bisectability, as the
new patch [5/5] will improve cyclic transfers by linking the last
descriptor to the first one in a SG chain, which means that the EOT IRQ
only needs to call the callback associated with the cyclic transfer, and
the EOT IRQ can be masked if there is no callback associated with it.

Cheers,
-Paul

drivers/dma/dma-axi-dmac.c | 280 +++++++++++++++++++++++++------------
1 file changed, 191 insertions(+), 89 deletions(-)

--
2.42.0



2023-12-21 16:30:41

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH v2 0/5] axi-dmac: Add support for scatter-gather


On Fri, 15 Dec 2023 14:13:08 +0100, Paul Cercueil wrote:
> V2 of my patchset which introduces scatter-gather transfers support to
> the axi-dmac driver.
>
> I updated patch [1/5] with your feedback. Patch [4/5] was updated as
> well, so that cyclic transfers are restarted properly in the EOT. This
> was a bug in my V1, but it was fixed here just for bisectability, as the
> new patch [5/5] will improve cyclic transfers by linking the last
> descriptor to the first one in a SG chain, which means that the EOT IRQ
> only needs to call the callback associated with the cyclic transfer, and
> the EOT IRQ can be masked if there is no callback associated with it.
>
> [...]

Applied, thanks!

[1/5] dmaengine: axi-dmac: Small code cleanup
commit: a2ab7045389feab1c26ebab105a8ad6bce74a4a7
[2/5] dmaengine: axi-dmac: Allocate hardware descriptors
commit: 3f8fd25936ee5f52596f10d420f650c5b5e3285f
[3/5] dmaengine: axi-dmac: Add support for scatter-gather transfers
commit: e97dc7435972d28ac7d96d199d4aedb868d04fd8
[4/5] dmaengine: axi-dmac: Use only EOT interrupts when doing scatter-gather
commit: 238f68a08e19a612b8912c8697901e9982f97811
[5/5] dmaengine: axi-dmac: Improve cyclic DMA transfers in SG mode
commit: f60dfe0c561a8f1b8e30d3770997cbaa636f57f9

Best regards,
--
~Vinod