2023-12-15 08:46:19

by Wang Jinchao

Subject: [PATCH] gpiolib: cleanup for duplicated including

rm second `#include <linux/err.h>`

Signed-off-by: Wang Jinchao <[email protected]>
---
include/linux/gpio/driver.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 0aed62f0c633..d659ba63bc20 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -789,8 +789,6 @@ int gpio_device_get_base(struct gpio_device *gdev);

#else /* CONFIG_GPIOLIB */

-#include <linux/err.h>
-
#include <asm/bug.h>

static inline struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc)
--
2.40.0

2023-12-15 15:48:06

by Andy Shevchenko

Subject: Re: [PATCH] gpiolib: cleanup for duplicated including

On Fri, Dec 15, 2023 at 04:46:04PM +0800, Wang Jinchao wrote:
> rm second `#include <linux/err.h>`

rm --> Remove

Missing period at the end of the sentence.

Please, drop also asm/errno.h as they are guaranteed by the global err.h
inclusion.

--
With Best Regards,
Andy Shevchenko