2023-12-15 10:25:29

by Wang Jinchao

Subject: [PATCH] xfs/health: cleanup, remove duplicated including

remove the second ones:
\#include "xfs_trans_resv.h"
\#include "xfs_mount.h"

Signed-off-by: Wang Jinchao <[email protected]>
---
fs/xfs/scrub/health.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/xfs/scrub/health.c b/fs/xfs/scrub/health.c
index 5e2b09ed6e29..289f1d4ea6ef 100644
--- a/fs/xfs/scrub/health.c
+++ b/fs/xfs/scrub/health.c
@@ -10,8 +10,6 @@
#include "xfs_trans_resv.h"
#include "xfs_mount.h"
#include "xfs_btree.h"
-#include "xfs_trans_resv.h"
-#include "xfs_mount.h"
#include "xfs_ag.h"
#include "xfs_health.h"
#include "scrub/scrub.h"
--
2.40.0

2023-12-15 17:32:54

by Darrick J. Wong

Subject: Re: [PATCH] xfs/health: cleanup, remove duplicated including

On Fri, Dec 15, 2023 at 06:24:34PM +0800, Wang Jinchao wrote:
> remove the second ones:
> \#include "xfs_trans_resv.h"
> \#include "xfs_mount.h"
>
> Signed-off-by: Wang Jinchao <[email protected]>

Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> fs/xfs/scrub/health.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/xfs/scrub/health.c b/fs/xfs/scrub/health.c
> index 5e2b09ed6e29..289f1d4ea6ef 100644
> --- a/fs/xfs/scrub/health.c
> +++ b/fs/xfs/scrub/health.c
> @@ -10,8 +10,6 @@
> #include "xfs_trans_resv.h"
> #include "xfs_mount.h"
> #include "xfs_btree.h"
> -#include "xfs_trans_resv.h"
> -#include "xfs_mount.h"
> #include "xfs_ag.h"
> #include "xfs_health.h"
> #include "scrub/scrub.h"
> --
> 2.40.0
>
>