2023-12-16 00:52:01

by rjingar

Subject: [PATCH] platform/x86/intel/vsec: Add support for Lunar Lake M

From: Rajvi Jingar <[email protected]>

Add Lunar Lake M PMT telemetry support.

Signed-off-by: Rajvi Jingar <[email protected]>
---
drivers/platform/x86/intel/vsec.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c
index c1f9e4471b28..3567dba57781 100644
--- a/drivers/platform/x86/intel/vsec.c
+++ b/drivers/platform/x86/intel/vsec.c
@@ -421,6 +421,11 @@ static const struct intel_vsec_platform_info tgl_info = {
.quirks = VSEC_QUIRK_TABLE_SHIFT | VSEC_QUIRK_EARLY_HW,
};

+/* LNL info */
+static const struct intel_vsec_platform_info lnl_info = {
+ .caps = VSEC_CAP_TELEMETRY | VSEC_CAP_WATCHER,
+};
+
#define PCI_DEVICE_ID_INTEL_VSEC_ADL 0x467d
#define PCI_DEVICE_ID_INTEL_VSEC_DG1 0x490e
#define PCI_DEVICE_ID_INTEL_VSEC_MTL_M 0x7d0d
@@ -428,6 +433,7 @@ static const struct intel_vsec_platform_info tgl_info = {
#define PCI_DEVICE_ID_INTEL_VSEC_OOBMSM 0x09a7
#define PCI_DEVICE_ID_INTEL_VSEC_RPL 0xa77d
#define PCI_DEVICE_ID_INTEL_VSEC_TGL 0x9a0d
+#define PCI_DEVICE_ID_INTEL_VSEC_LNL_M 0x647d
static const struct pci_device_id intel_vsec_pci_ids[] = {
{ PCI_DEVICE_DATA(INTEL, VSEC_ADL, &tgl_info) },
{ PCI_DEVICE_DATA(INTEL, VSEC_DG1, &dg1_info) },
@@ -436,6 +442,7 @@ static const struct pci_device_id intel_vsec_pci_ids[] = {
{ PCI_DEVICE_DATA(INTEL, VSEC_OOBMSM, &oobmsm_info) },
{ PCI_DEVICE_DATA(INTEL, VSEC_RPL, &tgl_info) },
{ PCI_DEVICE_DATA(INTEL, VSEC_TGL, &tgl_info) },
+ { PCI_DEVICE_DATA(INTEL, VSEC_LNL_M, &lnl_info) },
{ }
};
MODULE_DEVICE_TABLE(pci, intel_vsec_pci_ids);
--
2.34.1

2023-12-18 14:02:29

by Ilpo Järvinen

Subject: Re: [PATCH] platform/x86/intel/vsec: Add support for Lunar Lake M

On Fri, 15 Dec 2023, rjingar wrote:

> From: Rajvi Jingar <[email protected]>
>
> Add Lunar Lake M PMT telemetry support.
>
> Signed-off-by: Rajvi Jingar <[email protected]>
> ---
> drivers/platform/x86/intel/vsec.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c
> index c1f9e4471b28..3567dba57781 100644
> --- a/drivers/platform/x86/intel/vsec.c
> +++ b/drivers/platform/x86/intel/vsec.c
> @@ -421,6 +421,11 @@ static const struct intel_vsec_platform_info tgl_info = {
> .quirks = VSEC_QUIRK_TABLE_SHIFT | VSEC_QUIRK_EARLY_HW,
> };
>
> +/* LNL info */
> +static const struct intel_vsec_platform_info lnl_info = {
> + .caps = VSEC_CAP_TELEMETRY | VSEC_CAP_WATCHER,
> +};
> +
> #define PCI_DEVICE_ID_INTEL_VSEC_ADL 0x467d
> #define PCI_DEVICE_ID_INTEL_VSEC_DG1 0x490e
> #define PCI_DEVICE_ID_INTEL_VSEC_MTL_M 0x7d0d
> @@ -428,6 +433,7 @@ static const struct intel_vsec_platform_info tgl_info = {
> #define PCI_DEVICE_ID_INTEL_VSEC_OOBMSM 0x09a7
> #define PCI_DEVICE_ID_INTEL_VSEC_RPL 0xa77d
> #define PCI_DEVICE_ID_INTEL_VSEC_TGL 0x9a0d
> +#define PCI_DEVICE_ID_INTEL_VSEC_LNL_M 0x647d
> static const struct pci_device_id intel_vsec_pci_ids[] = {
> { PCI_DEVICE_DATA(INTEL, VSEC_ADL, &tgl_info) },
> { PCI_DEVICE_DATA(INTEL, VSEC_DG1, &dg1_info) },
> @@ -436,6 +442,7 @@ static const struct pci_device_id intel_vsec_pci_ids[] = {
> { PCI_DEVICE_DATA(INTEL, VSEC_OOBMSM, &oobmsm_info) },
> { PCI_DEVICE_DATA(INTEL, VSEC_RPL, &tgl_info) },
> { PCI_DEVICE_DATA(INTEL, VSEC_TGL, &tgl_info) },
> + { PCI_DEVICE_DATA(INTEL, VSEC_LNL_M, &lnl_info) },
> { }
> };
> MODULE_DEVICE_TABLE(pci, intel_vsec_pci_ids);

Reviewed-by: Ilpo J?rvinen <[email protected]>


--
i.

2023-12-18 14:03:27

by Hans de Goede

Subject: Re: [PATCH] platform/x86/intel/vsec: Add support for Lunar Lake M

Hi,

On 12/16/23 01:51, rjingar wrote:
> From: Rajvi Jingar <[email protected]>
>
> Add Lunar Lake M PMT telemetry support.
>
> Signed-off-by: Rajvi Jingar <[email protected]>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
> drivers/platform/x86/intel/vsec.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c
> index c1f9e4471b28..3567dba57781 100644
> --- a/drivers/platform/x86/intel/vsec.c
> +++ b/drivers/platform/x86/intel/vsec.c
> @@ -421,6 +421,11 @@ static const struct intel_vsec_platform_info tgl_info = {
> .quirks = VSEC_QUIRK_TABLE_SHIFT | VSEC_QUIRK_EARLY_HW,
> };
>
> +/* LNL info */
> +static const struct intel_vsec_platform_info lnl_info = {
> + .caps = VSEC_CAP_TELEMETRY | VSEC_CAP_WATCHER,
> +};
> +
> #define PCI_DEVICE_ID_INTEL_VSEC_ADL 0x467d
> #define PCI_DEVICE_ID_INTEL_VSEC_DG1 0x490e
> #define PCI_DEVICE_ID_INTEL_VSEC_MTL_M 0x7d0d
> @@ -428,6 +433,7 @@ static const struct intel_vsec_platform_info tgl_info = {
> #define PCI_DEVICE_ID_INTEL_VSEC_OOBMSM 0x09a7
> #define PCI_DEVICE_ID_INTEL_VSEC_RPL 0xa77d
> #define PCI_DEVICE_ID_INTEL_VSEC_TGL 0x9a0d
> +#define PCI_DEVICE_ID_INTEL_VSEC_LNL_M 0x647d
> static const struct pci_device_id intel_vsec_pci_ids[] = {
> { PCI_DEVICE_DATA(INTEL, VSEC_ADL, &tgl_info) },
> { PCI_DEVICE_DATA(INTEL, VSEC_DG1, &dg1_info) },
> @@ -436,6 +442,7 @@ static const struct pci_device_id intel_vsec_pci_ids[] = {
> { PCI_DEVICE_DATA(INTEL, VSEC_OOBMSM, &oobmsm_info) },
> { PCI_DEVICE_DATA(INTEL, VSEC_RPL, &tgl_info) },
> { PCI_DEVICE_DATA(INTEL, VSEC_TGL, &tgl_info) },
> + { PCI_DEVICE_DATA(INTEL, VSEC_LNL_M, &lnl_info) },
> { }
> };
> MODULE_DEVICE_TABLE(pci, intel_vsec_pci_ids);