2023-12-19 04:26:03

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the header_cleanup tree

Hi all,

After merging the header_cleanup tree, today's linux-next build (s390
defconfig) failed like this:

arch/s390/kernel/signal.c: In function 'arch_do_signal_or_restart':
arch/s390/kernel/signal.c:491:17: error: implicit declaration of function 'rseq_signal_deliver' [-Werror=implicit-function-declaration]
491 | rseq_signal_deliver(&ksig, regs);
| ^~~~~~~~~~~~~~~~~~~

Presumably caused by commit

cd1146fc0ad3 ("rseq: Split out rseq.h from sched.h")

I have applied the following patch for today:

From: Stephen Rothwell <[email protected]>
Date: Tue, 19 Dec 2023 15:19:02 +1100
Subject: [PATCH] fixup for s390 and "rseq: Split out rseq.h from sched.h"

Signed-off-by: Stephen Rothwell <[email protected]>
---
arch/s390/kernel/signal.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/s390/kernel/signal.c b/arch/s390/kernel/signal.c
index 27bcc43fe1b7..43e9661cd715 100644
--- a/arch/s390/kernel/signal.c
+++ b/arch/s390/kernel/signal.c
@@ -12,6 +12,7 @@

#include <linux/sched.h>
#include <linux/sched/task_stack.h>
+#include <linux/rseq.h>
#include <linux/mm.h>
#include <linux/smp.h>
#include <linux/kernel.h>
--
2.40.1

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2023-12-19 05:00:01

by Kent Overstreet

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the header_cleanup tree

On Tue, Dec 19, 2023 at 03:25:45PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the header_cleanup tree, today's linux-next build (s390
> defconfig) failed like this:
>
> arch/s390/kernel/signal.c: In function 'arch_do_signal_or_restart':
> arch/s390/kernel/signal.c:491:17: error: implicit declaration of function 'rseq_signal_deliver' [-Werror=implicit-function-declaration]
> 491 | rseq_signal_deliver(&ksig, regs);
> | ^~~~~~~~~~~~~~~~~~~
>
> Presumably caused by commit
>
> cd1146fc0ad3 ("rseq: Split out rseq.h from sched.h")
>
> I have applied the following patch for today:

I've applied the same fixup to my tree.