2023-12-19 15:12:25

by Piro Yang

Subject: [PATCH V3] staging:vme_user:Fix the issue of return the wrong error code

Fix the issue of returning the -ENOSYS error code when an error occurs

The error code of -ENOSYS indicates Invalid system call number, but there is not system call error

Replace -ENOSYS error code by returning -EINVAL error code

Signed-off-by: Piro Yang <[email protected]>
---
v3: change the description and format for the patch

v2: split two different changes,
only fix the issue of wrong error code
---
drivers/staging/vme_user/vme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
index 5c416c31ec57..9bc2d35405af 100644
--- a/drivers/staging/vme_user/vme.c
+++ b/drivers/staging/vme_user/vme.c
@@ -341,7 +341,7 @@ int vme_slave_set(struct vme_resource *resource, int enabled,

if (!bridge->slave_set) {
dev_err(bridge->parent, "Function not supported\n");
- return -ENOSYS;
+ return -EINVAL;
}

if (!(((image->address_attr & aspace) == aspace) &&
--
2.25.1

2023-12-19 15:18:59

by Greg Kroah-Hartman

Subject: Re: [PATCH V3] staging:vme_user:Fix the issue of return the wrong error code

On Tue, Dec 19, 2023 at 11:12:02PM +0800, Piro Yang wrote:
> Fix the issue of returning the -ENOSYS error code when an error occurs
>
> The error code of -ENOSYS indicates Invalid system call number, but there is not system call error

Please wrap your changelog text at 72 columns, like your editor asked
you to.

And use '.' as these are real sentences, right?

And some ' ' in the subject line, like:
staging: vme_user: Fix...

Usually writing the changelog and getting it correct is the hardest part
of getting a change accepted.

thanks,

greg k-h