2023-12-21 03:51:44

by Bjorn Andersson

[permalink] [raw]
Subject: [PATCH 3/8] clk: qcom: gpucc-sc8280xp: Add external supply for GX gdsc

On SA8295P and SA8540P the GFX rail is powered by a dedicated external
regulator, instead of the rpmh-controlled "gfx.lvl".

Define the "vdd-gfx" as the supply regulator for the GDSC, to cause the
gdsc logic to look for, and control, this external power supply.

Signed-off-by: Bjorn Andersson <[email protected]>
---
drivers/clk/qcom/gpucc-sc8280xp.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/gpucc-sc8280xp.c b/drivers/clk/qcom/gpucc-sc8280xp.c
index 8e147ee294ee..e2b3bc000c71 100644
--- a/drivers/clk/qcom/gpucc-sc8280xp.c
+++ b/drivers/clk/qcom/gpucc-sc8280xp.c
@@ -399,6 +399,7 @@ static struct gdsc gx_gdsc = {
},
.pwrsts = PWRSTS_OFF_ON,
.flags = CLAMP_IO | RETAIN_FF_ENABLE,
+ .supply = "vdd-gfx",
};

static struct gdsc *gpu_cc_sc8280xp_gdscs[] = {

--
2.25.1



2023-12-21 07:04:32

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 3/8] clk: qcom: gpucc-sc8280xp: Add external supply for GX gdsc

On Thu, 21 Dec 2023 at 05:51, Bjorn Andersson <[email protected]> wrote:
>
> On SA8295P and SA8540P the GFX rail is powered by a dedicated external
> regulator, instead of the rpmh-controlled "gfx.lvl".
>
> Define the "vdd-gfx" as the supply regulator for the GDSC, to cause the
> gdsc logic to look for, and control, this external power supply.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> drivers/clk/qcom/gpucc-sc8280xp.c | 1 +
> 1 file changed, 1 insertion(+)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry