2023-12-20 17:04:39

by Stefan Binding

[permalink] [raw]
Subject: [PATCH v1 0/3] Support Dell models without _DSD

Add Quirks and driver properties for Dell models.
Driver properties are required since these models do not have _DSD.
Additionally, some laptops, including some of these, have an issue
with their BIOS which causes the SPI speed to be set too slow.
To ensure a decent performance for laptops with this slow speed,
disable firmware loading. Running without firmware results in lower
volume.

Stefan Binding (3):
ALSA: hda: cs35l41: Support additional Dell models without _DSD
ALSA: hda: cs35l41: Prevent firmware load if SPI speed too low
ALSA: hda/realtek: Add quirks for Dell models

sound/pci/hda/cs35l41_hda.c | 25 ++++++++--
sound/pci/hda/cs35l41_hda.h | 12 ++++-
sound/pci/hda/cs35l41_hda_i2c.c | 2 +-
sound/pci/hda/cs35l41_hda_property.c | 74 +++++++++++++++-------------
sound/pci/hda/cs35l41_hda_spi.c | 2 +-
sound/pci/hda/patch_realtek.c | 13 +++++
6 files changed, 87 insertions(+), 41 deletions(-)

--
2.34.1



2023-12-21 09:42:54

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH v1 0/3] Support Dell models without _DSD

On Wed, 20 Dec 2023 17:58:26 +0100,
Stefan Binding wrote:
>
> Add Quirks and driver properties for Dell models.
> Driver properties are required since these models do not have _DSD.
> Additionally, some laptops, including some of these, have an issue
> with their BIOS which causes the SPI speed to be set too slow.
> To ensure a decent performance for laptops with this slow speed,
> disable firmware loading. Running without firmware results in lower
> volume.
>
> Stefan Binding (3):
> ALSA: hda: cs35l41: Support additional Dell models without _DSD
> ALSA: hda: cs35l41: Prevent firmware load if SPI speed too low
> ALSA: hda/realtek: Add quirks for Dell models

The series doesn't seem applied cleanly.
Could you rebase to my for-linus branch and resubmit?

Though, I feel that it's a bit too much for 6.7 at this very late
stage. So, I'll likely skip this series and apply to 6.8.


thanks,

Takashi