Hi,
This patch series renames (5) different variables with
the checkpatch coding style issue, Avoid CamelCase.
Patch 1/5) rename variable HTInitializeBssDesc
Patch 2/5) rename variable HTResetSelfAndSavePeerSetting
Patch 3/5) rename variable HTCCheck
Patch 4/5) rename variable HTSetConnectBwModeCallback
Patch 5/5) rename variable ePeerHTSpecVer
Signed-off-by: Gary Rookard <[email protected]>
Gary Rookard (5):
staging: rtl8192e: rename variable HTInitializeBssDesc
staging: rtl8192e: rename variable HTResetSelfAndSavePeerSetting
staging: rtl8192e: rename variable HTCCheck
staging: rtl8192e: rename variable HTSetConnectBwModeCallback
staging: rtl8192e: rename variable ePeerHTSpecVer
drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 16 ++++++++--------
drivers/staging/rtl8192e/rtllib.h | 6 +++---
drivers/staging/rtl8192e/rtllib_rx.c | 6 +++---
drivers/staging/rtl8192e/rtllib_softmac.c | 6 +++---
5 files changed, 18 insertions(+), 18 deletions(-)
--
2.43.0
Coding style issue, checkpatch Avoid CamelCase,
rename it.
HTResetSelfAndSavePeerSetting -> ht_reset_self_and_save_peer_setting
Signed-off-by: Gary Rookard <[email protected]>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index edfc2c7461ee..a32f3553df93 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -558,7 +558,7 @@ void ht_initialize_bss_desc(struct bss_ht *pBssHT)
pBssHT->rt2rt_ht_mode = (enum rt_ht_capability)0;
}
-void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,
+void ht_reset_self_and_save_peer_setting(struct rtllib_device *ieee,
struct rtllib_network *pNetwork)
{
struct rt_hi_throughput *ht_info = ieee->ht_info;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 193b4a5a7c04..78eae7daa351 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1759,7 +1759,7 @@ void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee,
void ht_on_assoc_rsp(struct rtllib_device *ieee);
void ht_initialize_ht_info(struct rtllib_device *ieee);
void ht_initialize_bss_desc(struct bss_ht *pBssHT);
-void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,
+void ht_reset_self_and_save_peer_setting(struct rtllib_device *ieee,
struct rtllib_network *pNetwork);
void HT_update_self_and_peer_setting(struct rtllib_device *ieee,
struct rtllib_network *pNetwork);
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 9c94c5ceccd5..14f34e6a591a 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -1219,7 +1219,7 @@ inline void rtllib_softmac_new_net(struct rtllib_device *ieee,
ieee->AsocRetryCount = 0;
if ((ieee->current_network.qos_data.supported == 1) &&
ieee->current_network.bssht.bd_support_ht)
- HTResetSelfAndSavePeerSetting(ieee,
+ ht_reset_self_and_save_peer_setting(ieee,
&(ieee->current_network));
else
ieee->ht_info->current_ht_support = false;
--
2.43.0
Coding style issue, checkpatch Avoid CamelCase,
rename it. HTInitializeBssDesc -> ht_initialize_bss_desc
Signed-off-by: Gary Rookard <[email protected]>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 0d57bcda33b4..edfc2c7461ee 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -543,7 +543,7 @@ void ht_initialize_ht_info(struct rtllib_device *ieee)
}
}
-void HTInitializeBssDesc(struct bss_ht *pBssHT)
+void ht_initialize_bss_desc(struct bss_ht *pBssHT)
{
pBssHT->bd_support_ht = false;
memset(pBssHT->bd_ht_cap_buf, 0, sizeof(pBssHT->bd_ht_cap_buf));
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 4df46eae6aa8..193b4a5a7c04 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1758,7 +1758,7 @@ void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee,
u8 *posRT2RTAgg, u8 *len);
void ht_on_assoc_rsp(struct rtllib_device *ieee);
void ht_initialize_ht_info(struct rtllib_device *ieee);
-void HTInitializeBssDesc(struct bss_ht *pBssHT);
+void ht_initialize_bss_desc(struct bss_ht *pBssHT);
void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,
struct rtllib_network *pNetwork);
void HT_update_self_and_peer_setting(struct rtllib_device *ieee,
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 196eacc7a768..5f219cfb65eb 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -2189,7 +2189,7 @@ static inline int rtllib_network_init(
network->RSSI = stats->SignalStrength;
network->CountryIeLen = 0;
memset(network->CountryIeBuf, 0, MAX_IE_LEN);
- HTInitializeBssDesc(&network->bssht);
+ ht_initialize_bss_desc(&network->bssht);
network->flags |= NETWORK_HAS_CCK;
network->wpa_ie_len = 0;
--
2.43.0
Coding style issue, checkpatch Avoid CamelCase,
rename it. HTCCheck -> ht_c_check
Signed-off-by: Gary Rookard <[email protected]>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_rx.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index a32f3553df93..5698b48fdcc9 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -622,7 +622,7 @@ void HT_update_self_and_peer_setting(struct rtllib_device *ieee,
}
EXPORT_SYMBOL(HT_update_self_and_peer_setting);
-u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame)
+u8 ht_c_check(struct rtllib_device *ieee, u8 *pFrame)
{
if (ieee->ht_info->current_ht_support) {
if ((IsQoSDataFrame(pFrame) && Frame_Order(pFrame)) == 1) {
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 78eae7daa351..341d9ddc9a1f 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1767,7 +1767,7 @@ u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet,
u8 *pMCSFilter);
extern u8 MCS_FILTER_ALL[];
extern u16 MCS_DATA_RATE[2][2][77];
-u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame);
+u8 ht_c_check(struct rtllib_device *ieee, u8 *pFrame);
void ht_reset_iot_setting(struct rt_hi_throughput *ht_info);
bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 5f219cfb65eb..595ec9af25ea 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -857,7 +857,7 @@ static size_t rtllib_rx_get_hdrlen(struct rtllib_device *ieee,
size_t hdrlen;
hdrlen = rtllib_get_hdrlen(fc);
- if (HTCCheck(ieee, skb->data)) {
+ if (ht_c_check(ieee, skb->data)) {
if (net_ratelimit())
netdev_info(ieee->dev, "%s: find HTCControl!\n",
__func__);
@@ -1401,7 +1401,7 @@ static int rtllib_rx_Monitor(struct rtllib_device *ieee, struct sk_buff *skb,
return 0;
}
- if (HTCCheck(ieee, skb->data)) {
+ if (ht_c_check(ieee, skb->data)) {
if (net_ratelimit())
netdev_info(ieee->dev, "%s: Find HTCControl!\n",
__func__);
--
2.43.0
Coding style issue, checkpatch Avoid CamelCase,
rename it. ePeerHTSpecVer -> peer_ht_spec_ver
Signed-off-by: Gary Rookard <[email protected]>
---
drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++---
drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
index 2911ea82dd17..68577bffb936 100644
--- a/drivers/staging/rtl8192e/rtl819x_HT.h
+++ b/drivers/staging/rtl8192e/rtl819x_HT.h
@@ -97,7 +97,7 @@ struct rt_hi_throughput {
u8 cur_bw_40mhz;
u8 cur_short_gi_40mhz;
u8 cur_short_gi_20mhz;
- enum ht_spec_ver ePeerHTSpecVer;
+ enum ht_spec_ver peer_ht_spec_ver;
struct ht_capab_ele SelfHTCap;
u8 PeerHTCapBuf[32];
u8 PeerHTInfoBuf[32];
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index ac17d510a2a5..6d0912f90198 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -240,7 +240,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap,
}
memset(pos_ht_cap, 0, *len);
- if ((assoc) && (ht->ePeerHTSpecVer == HT_SPEC_VER_EWC)) {
+ if ((assoc) && (ht->peer_ht_spec_ver == HT_SPEC_VER_EWC)) {
static const u8 EWC11NHTCap[] = { 0x00, 0x90, 0x4c, 0x33 };
memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap));
@@ -525,7 +525,7 @@ void ht_initialize_ht_info(struct rtllib_device *ieee)
ht_info->sw_bw_in_progress = false;
- ht_info->ePeerHTSpecVer = HT_SPEC_VER_IEEE;
+ ht_info->peer_ht_spec_ver = HT_SPEC_VER_IEEE;
ht_info->current_rt2rt_aggregation = false;
ht_info->current_rt2rt_long_slot_time = false;
@@ -569,7 +569,7 @@ void ht_reset_self_and_save_peer_setting(struct rtllib_device *ieee,
*/
if (pNetwork->bssht.bd_support_ht) {
ht_info->current_ht_support = true;
- ht_info->ePeerHTSpecVer = pNetwork->bssht.bd_ht_spec_ver;
+ ht_info->peer_ht_spec_ver = pNetwork->bssht.bd_ht_spec_ver;
if (pNetwork->bssht.bd_ht_cap_len > 0 &&
pNetwork->bssht.bd_ht_cap_len <= sizeof(ht_info->PeerHTCapBuf))
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 14f34e6a591a..953222d57f0e 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -866,7 +866,7 @@ rtllib_association_req(struct rtllib_network *beacon,
tag += osCcxVerNum.Length;
}
if (ieee->ht_info->current_ht_support && ieee->ht_info->enable_ht) {
- if (ieee->ht_info->ePeerHTSpecVer != HT_SPEC_VER_EWC) {
+ if (ieee->ht_info->peer_ht_spec_ver != HT_SPEC_VER_EWC) {
tag = skb_put(skb, ht_cap_len);
*tag++ = MFIE_TYPE_HT_CAP;
*tag++ = ht_cap_len - 2;
@@ -900,7 +900,7 @@ rtllib_association_req(struct rtllib_network *beacon,
}
if (ieee->ht_info->current_ht_support && ieee->ht_info->enable_ht) {
- if (ieee->ht_info->ePeerHTSpecVer == HT_SPEC_VER_EWC) {
+ if (ieee->ht_info->peer_ht_spec_ver == HT_SPEC_VER_EWC) {
tag = skb_put(skb, ht_cap_len);
*tag++ = MFIE_TYPE_GENERIC;
*tag++ = ht_cap_len - 2;
--
2.43.0
Coding style issue, checkpatch Avoid CamelCase,
rename it. HTSetConnectBwModeCallback -> ht_set_connect_bw_mode_callback
Signed-off-by: Gary Rookard <[email protected]>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 5698b48fdcc9..ac17d510a2a5 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -633,7 +633,7 @@ u8 ht_c_check(struct rtllib_device *ieee, u8 *pFrame)
return false;
}
-static void HTSetConnectBwModeCallback(struct rtllib_device *ieee)
+static void ht_set_connect_bw_mode_callback(struct rtllib_device *ieee)
{
struct rt_hi_throughput *ht_info = ieee->ht_info;
@@ -695,5 +695,5 @@ void ht_set_connect_bw_mode(struct rtllib_device *ieee,
ht_info->sw_bw_in_progress = true;
- HTSetConnectBwModeCallback(ieee);
+ ht_set_connect_bw_mode_callback(ieee);
}
--
2.43.0
On Wed, Dec 20, 2023 at 10:09:59PM -0500, Gary Rookard wrote:
> Hi,
>
> This patch series renames (5) different variables with
> the checkpatch coding style issue, Avoid CamelCase.
>
> Patch 1/5) rename variable HTInitializeBssDesc
> Patch 2/5) rename variable HTResetSelfAndSavePeerSetting
> Patch 3/5) rename variable HTCCheck
> Patch 4/5) rename variable HTSetConnectBwModeCallback
> Patch 5/5) rename variable ePeerHTSpecVer
>
> Signed-off-by: Gary Rookard <[email protected]>
>
> Gary Rookard (5):
> staging: rtl8192e: rename variable HTInitializeBssDesc
> staging: rtl8192e: rename variable HTResetSelfAndSavePeerSetting
> staging: rtl8192e: rename variable HTCCheck
> staging: rtl8192e: rename variable HTSetConnectBwModeCallback
> staging: rtl8192e: rename variable ePeerHTSpecVer
>
> drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 16 ++++++++--------
> drivers/staging/rtl8192e/rtllib.h | 6 +++---
> drivers/staging/rtl8192e/rtllib_rx.c | 6 +++---
> drivers/staging/rtl8192e/rtllib_softmac.c | 6 +++---
> 5 files changed, 18 insertions(+), 18 deletions(-)
I see 2 different patch series here sent to the list, both seeming to do
the same thing?
confused,
greg k-h
Greg KH <[email protected]> writes:
> On Wed, Dec 20, 2023 at 10:09:59PM -0500, Gary Rookard wrote:
>> Hi,
>>
>> This patch series renames (5) different variables with
>> the checkpatch coding style issue, Avoid CamelCase.
>>
>> Patch 1/5) rename variable HTInitializeBssDesc
>> Patch 2/5) rename variable HTResetSelfAndSavePeerSetting
>> Patch 3/5) rename variable HTCCheck
>> Patch 4/5) rename variable HTSetConnectBwModeCallback
>> Patch 5/5) rename variable ePeerHTSpecVer
>>
>> Signed-off-by: Gary Rookard <[email protected]>
>>
>> Gary Rookard (5):
>> staging: rtl8192e: rename variable HTInitializeBssDesc
>> staging: rtl8192e: rename variable HTResetSelfAndSavePeerSetting
>> staging: rtl8192e: rename variable HTCCheck
>> staging: rtl8192e: rename variable HTSetConnectBwModeCallback
>> staging: rtl8192e: rename variable ePeerHTSpecVer
>>
>> drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
>> drivers/staging/rtl8192e/rtl819x_HTProc.c | 16 ++++++++--------
>> drivers/staging/rtl8192e/rtllib.h | 6 +++---
>> drivers/staging/rtl8192e/rtllib_rx.c | 6 +++---
>> drivers/staging/rtl8192e/rtllib_softmac.c | 6 +++---
>> 5 files changed, 18 insertions(+), 18 deletions(-)
>
> I see 2 different patch series here sent to the list, both seeming to do
> the same thing?
>
> confused,
>
> greg k-h
Sorry that was caused by an address typo
so it got resent to linux-staging..
new setup on different distro
Regards,
Gary
--
Sent with my mu4e on Void Linux.
On Thu, Dec 21, 2023 at 08:06:13AM -0500, Gary Rookard wrote:
>
> Greg KH <[email protected]> writes:
>
> > On Wed, Dec 20, 2023 at 10:09:59PM -0500, Gary Rookard wrote:
> >> Hi,
> >>
> >> This patch series renames (5) different variables with
> >> the checkpatch coding style issue, Avoid CamelCase.
> >>
> >> Patch 1/5) rename variable HTInitializeBssDesc
> >> Patch 2/5) rename variable HTResetSelfAndSavePeerSetting
> >> Patch 3/5) rename variable HTCCheck
> >> Patch 4/5) rename variable HTSetConnectBwModeCallback
> >> Patch 5/5) rename variable ePeerHTSpecVer
> >>
> >> Signed-off-by: Gary Rookard <[email protected]>
> >>
> >> Gary Rookard (5):
> >> staging: rtl8192e: rename variable HTInitializeBssDesc
> >> staging: rtl8192e: rename variable HTResetSelfAndSavePeerSetting
> >> staging: rtl8192e: rename variable HTCCheck
> >> staging: rtl8192e: rename variable HTSetConnectBwModeCallback
> >> staging: rtl8192e: rename variable ePeerHTSpecVer
> >>
> >> drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
> >> drivers/staging/rtl8192e/rtl819x_HTProc.c | 16 ++++++++--------
> >> drivers/staging/rtl8192e/rtllib.h | 6 +++---
> >> drivers/staging/rtl8192e/rtllib_rx.c | 6 +++---
> >> drivers/staging/rtl8192e/rtllib_softmac.c | 6 +++---
> >> 5 files changed, 18 insertions(+), 18 deletions(-)
> >
> > I see 2 different patch series here sent to the list, both seeming to do
> > the same thing?
> >
> > confused,
> >
> > greg k-h
>
> Sorry that was caused by an address typo
> so it got resent to linux-staging..
> new setup on different distro
Please send a v2 of this then.
thanks,
greg k-h
Greg KH <[email protected]> writes:
> On Thu, Dec 21, 2023 at 08:06:13AM -0500, Gary Rookard wrote:
>>
>> Greg KH <[email protected]> writes:
>>
>> > On Wed, Dec 20, 2023 at 10:09:59PM -0500, Gary Rookard wrote:
>> >> Hi,
>> >>
>> >> This patch series renames (5) different variables with
>> >> the checkpatch coding style issue, Avoid CamelCase.
>> >>
>> >> Patch 1/5) rename variable HTInitializeBssDesc
>> >> Patch 2/5) rename variable HTResetSelfAndSavePeerSetting
>> >> Patch 3/5) rename variable HTCCheck
>> >> Patch 4/5) rename variable HTSetConnectBwModeCallback
>> >> Patch 5/5) rename variable ePeerHTSpecVer
>> >>
>> >> Signed-off-by: Gary Rookard <[email protected]>
>> >>
>> >> Gary Rookard (5):
>> >> staging: rtl8192e: rename variable HTInitializeBssDesc
>> >> staging: rtl8192e: rename variable HTResetSelfAndSavePeerSetting
>> >> staging: rtl8192e: rename variable HTCCheck
>> >> staging: rtl8192e: rename variable HTSetConnectBwModeCallback
>> >> staging: rtl8192e: rename variable ePeerHTSpecVer
>> >>
>> >> drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
>> >> drivers/staging/rtl8192e/rtl819x_HTProc.c | 16 ++++++++--------
>> >> drivers/staging/rtl8192e/rtllib.h | 6 +++---
>> >> drivers/staging/rtl8192e/rtllib_rx.c | 6 +++---
>> >> drivers/staging/rtl8192e/rtllib_softmac.c | 6 +++---
>> >> 5 files changed, 18 insertions(+), 18 deletions(-)
>> >
>> > I see 2 different patch series here sent to the list, both seeming to do
>> > the same thing?
>> >
>> > confused,
>> >
>> > greg k-h
>>
>> Sorry that was caused by an address typo
>> so it got resent to linux-staging..
>> new setup on different distro
>
> Please send a v2 of this then.
>
> thanks,
>
> greg k-h
Okay, will do.
Regards,
Gary
--
Sent with my mu4e on Void Linux.