2023-12-21 10:15:10

by Shenghao Ding

Subject: [PATCH v2 2/5] ASoC: tas2562: remove tas2563 into driver

Remove tas2563 from tas2562, it will be supported in tas2781 to better
support dsp mode.

Signed-off-by: Shenghao Ding <[email protected]>

---
Change in v2:
- remove tas2563, which will be move to tas2781 driver
---
sound/soc/codecs/tas2562.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
index 962c2cdfa017..54561ae598b8 100644
--- a/sound/soc/codecs/tas2562.c
+++ b/sound/soc/codecs/tas2562.c
@@ -59,7 +59,6 @@ struct tas2562_data {

enum tas256x_model {
TAS2562,
- TAS2563,
TAS2564,
TAS2110,
};
@@ -721,7 +720,6 @@ static int tas2562_parse_dt(struct tas2562_data *tas2562)

static const struct i2c_device_id tas2562_id[] = {
{ "tas2562", TAS2562 },
- { "tas2563", TAS2563 },
{ "tas2564", TAS2564 },
{ "tas2110", TAS2110 },
{ }
@@ -770,7 +768,6 @@ static int tas2562_probe(struct i2c_client *client)
#ifdef CONFIG_OF
static const struct of_device_id tas2562_of_match[] = {
{ .compatible = "ti,tas2562", },
- { .compatible = "ti,tas2563", },
{ .compatible = "ti,tas2564", },
{ .compatible = "ti,tas2110", },
{ },
--
2.34.1

2023-12-21 15:54:45

by Andy Shevchenko

Subject: Re: [PATCH v2 2/5] ASoC: tas2562: remove tas2563 into driver

On Thu, Dec 21, 2023 at 06:13:42PM +0800, Shenghao Ding wrote:
> Remove tas2563 from tas2562, it will be supported in tas2781 to better
> support dsp mode.

DSP

...

After this patch the support gone --> regression for the current users.
The commit message does not explain why it's not a problem.

--
With Best Regards,
Andy Shevchenko