2023-12-21 10:46:11

by MANISH PANDEY

[permalink] [raw]
Subject: [PATCH V2 2/2] arm64: dts: qcom: qcm6490: Add UFS nodes

Add UFS host controller and Phy nodes for
Qualcomm qcm6490 Board.

Signed-off-by: Manish Pandey <[email protected]>
---
arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index 03e97e27d16d..51efd46b576c 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -440,6 +440,25 @@
status = "okay";
};

+&ufs_mem_hc {
+ reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
+ vcc-supply = <&vreg_l7b_2p9>;
+ vcc-max-microamp = <800000>;
+ vccq-supply = <&vreg_l9b_1p2>;
+ vccq-max-microamp = <900000>;
+ vccq2-supply = <&vreg_l9b_1p2>;
+ vccq2-max-microamp = <900000>;
+
+ status = "okay";
+};
+
+&ufs_mem_phy {
+ vdda-phy-supply = <&vreg_l10c_0p8>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
+
+ status = "okay";
+};
+
&usb_1 {
status = "okay";
};
--
2.17.1



2023-12-21 15:17:44

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH V2 2/2] arm64: dts: qcom: qcm6490: Add UFS nodes

On 21.12.2023 11:45, Manish Pandey wrote:
> Add UFS host controller and Phy nodes for
> Qualcomm qcm6490 Board.
>
> Signed-off-by: Manish Pandey <[email protected]>
> ---
This still doesn't compile and only v2 made it to my inbox.

Please fix this.

Konrad

2023-12-21 15:33:12

by MANISH PANDEY

[permalink] [raw]
Subject: Re: [PATCH V2 2/2] arm64: dts: qcom: qcm6490: Add UFS nodes



On 12/21/2023 8:47 PM, Konrad Dybcio wrote:
> On 21.12.2023 11:45, Manish Pandey wrote:
>> Add UFS host controller and Phy nodes for
>> Qualcomm qcm6490 Board.
>>
>> Signed-off-by: Manish Pandey <[email protected]>
>> ---
> This still doesn't compile and only v2 made it to my inbox.
>
> Please fix this.
>
> Konrad

Hi Konrad,
Thanks for the quick review, We would wait for qcom regulator patches to
be merged first with regulator-allow-set-load added in required nodes.
Post that we would address the comments and share next patch-set.
Sorry for inconvenience.

Regards
Manish