2023-12-21 13:49:50

by Ruipeng Qi

Subject: [RFC PATCH 4/7] dt-bindings: reserved-memory: Support osdump module

From: qiruipeng <[email protected]>

Add bindings to allow osdump module to store dump in reserved-memory
region named "osdump".

Signed-off-by: qiruipeng <[email protected]>
---
.../bindings/reserved-memory/osdump.yaml | 45 +++++++++++++++++++
1 file changed, 45 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reserved-memory/osdump.yaml

diff --git a/Documentation/devicetree/bindings/reserved-memory/osdump.yaml b/Documentation/devicetree/bindings/reserved-memory/osdump.yaml
new file mode 100644
index 000000000000..149bf0204e68
--- /dev/null
+++ b/Documentation/devicetree/bindings/reserved-memory/osdump.yaml
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/reserved-memory/osdump.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: OS minidump module
+
+description: |
+ Specifies that the reserved memory region can be used for OS minidump
+ module.
+
+ The "osdump" node is named after the "OS minidump" module which
+ provides an implementation of a new crash dumping solutionin in Linux.
+
+maintainers:
+ - Ruipeng Qi <[email protected]>
+
+allOf:
+ - $ref: reserved-memory.yaml
+
+properties:
+ compatible:
+ const: osdump
+
+ reg:
+ description: region of memory that can be used for OS minidump module
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ reserved-memory {
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ osdump: osdump@64000000 {
+ compatible = "osdump";
+ reg = <0x64000000 0x01000000>;
+ };
+ };
--
2.17.1

2023-12-21 16:22:46

by Krzysztof Kozlowski

Subject: Re: [RFC PATCH 4/7] dt-bindings: reserved-memory: Support osdump module

On 21/12/2023 14:31, Ruipeng Qi wrote:
> From: qiruipeng <[email protected]>
>
> Add bindings to allow osdump module to store dump in reserved-memory
> region named "osdump".
>
> Signed-off-by: qiruipeng <[email protected]>

I have some doubts whether you used your name or just email address as
name...

> ---
> .../bindings/reserved-memory/osdump.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reserved-memory/osdump.yaml
>
> diff --git a/Documentation/devicetree/bindings/reserved-memory/osdump.yaml b/Documentation/devicetree/bindings/reserved-memory/osdump.yaml
> new file mode 100644
> index 000000000000..149bf0204e68
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reserved-memory/osdump.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reserved-memory/osdump.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OS minidump module
> +
> +description: |
> + Specifies that the reserved memory region can be used for OS minidump
> + module.

I don't see any explanation why this is needed and what you are
describing here. Use simply reserved memory.

If you need any osdump, then work with minidump series. Some time ago we
were asking people to come with their needs. I did not get any other
series, so no clue what you are doing, but just in case:
NAK for second "minidump" clone.


Best regards,
Krzysztof