"bmp085" is missing in bmp280_spi_id[] table, which leads to the next
warning in dmesg:
SPI driver bmp280 has no spi_device_id for bosch,bmp085
Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in
bmp280_of_spi_match[] table to fix the above warning.
Signed-off-by: Sam Protsenko <[email protected]>
Fixes: b26b4e91700f ("iio: pressure: bmp280: add SPI interface driver")
---
drivers/iio/pressure/bmp280-spi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/pressure/bmp280-spi.c b/drivers/iio/pressure/bmp280-spi.c
index 433d6fac83c4..e8a5fed07e88 100644
--- a/drivers/iio/pressure/bmp280-spi.c
+++ b/drivers/iio/pressure/bmp280-spi.c
@@ -87,6 +87,7 @@ static const struct of_device_id bmp280_of_spi_match[] = {
MODULE_DEVICE_TABLE(of, bmp280_of_spi_match);
static const struct spi_device_id bmp280_spi_id[] = {
+ { "bmp085", (kernel_ulong_t)&bmp180_chip_info },
{ "bmp180", (kernel_ulong_t)&bmp180_chip_info },
{ "bmp181", (kernel_ulong_t)&bmp180_chip_info },
{ "bmp280", (kernel_ulong_t)&bmp280_chip_info },
--
2.39.2
On Wed, Dec 20, 2023 at 12:47:53PM -0600, Sam Protsenko wrote:
> "bmp085" is missing in bmp280_spi_id[] table, which leads to the next
> warning in dmesg:
>
> SPI driver bmp280 has no spi_device_id for bosch,bmp085
>
> Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in
> bmp280_of_spi_match[] table to fix the above warning.
Good catch!
Reviewed-by: Andy Shevchenko <[email protected]>
--
With Best Regards,
Andy Shevchenko
On Wed, Dec 20, 2023 at 7:47 PM Sam Protsenko
<[email protected]> wrote:
> "bmp085" is missing in bmp280_spi_id[] table, which leads to the next
> warning in dmesg:
>
> SPI driver bmp280 has no spi_device_id for bosch,bmp085
>
> Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in
> bmp280_of_spi_match[] table to fix the above warning.
>
> Signed-off-by: Sam Protsenko <[email protected]>
> Fixes: b26b4e91700f ("iio: pressure: bmp280: add SPI interface driver")
Right! Thanks for fixing this Sam!
Reviewed-by: Linus Walleij <[email protected]>
Yours,
Linus Walleij
On Wed, 20 Dec 2023 20:07:57 +0100
Linus Walleij <[email protected]> wrote:
> On Wed, Dec 20, 2023 at 7:47 PM Sam Protsenko
> <[email protected]> wrote:
>
> > "bmp085" is missing in bmp280_spi_id[] table, which leads to the next
> > warning in dmesg:
> >
> > SPI driver bmp280 has no spi_device_id for bosch,bmp085
> >
> > Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in
> > bmp280_of_spi_match[] table to fix the above warning.
> >
> > Signed-off-by: Sam Protsenko <[email protected]>
> > Fixes: b26b4e91700f ("iio: pressure: bmp280: add SPI interface driver")
>
> Right! Thanks for fixing this Sam!
> Reviewed-by: Linus Walleij <[email protected]>
>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
J
> Yours,
> Linus Walleij