2023-12-22 06:19:37

by Randy Dunlap

Subject: [PATCH] tpm: cr50: fix kernel-doc warning and spelling

Fix kernel-doc notation to prevent a warning:
tpm_tis_i2c_cr50.c:681: warning: Excess function parameter 'id' description in 'tpm_cr50_i2c_probe'

and fix a spelling error reported by codespell.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Peter Huewe <[email protected]>
Cc: Jarkko Sakkinen <[email protected]>
Cc: Jason Gunthorpe <[email protected]>
Cc: [email protected]
---
drivers/char/tpm/tpm_tis_i2c_cr50.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff -- a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c
--- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
+++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
@@ -235,7 +235,7 @@ out:
* @len: Number of bytes to write.
*
* The provided address is prepended to the data in 'buffer', the
- * cobined address+data is sent to the TPM, then wait for TPM to
+ * combined address+data is sent to the TPM, then wait for TPM to
* indicate it is done writing.
*
* Return:
@@ -671,7 +671,6 @@ MODULE_DEVICE_TABLE(of, of_cr50_i2c_matc
/**
* tpm_cr50_i2c_probe() - Driver probe function.
* @client: I2C client information.
- * @id: I2C device id.
*
* Return:
* - 0: Success.

2024-01-03 13:43:50

by Jarkko Sakkinen

Subject: Re: [PATCH] tpm: cr50: fix kernel-doc warning and spelling

On Fri Dec 22, 2023 at 8:19 AM EET, Randy Dunlap wrote:
> Fix kernel-doc notation to prevent a warning:
> tpm_tis_i2c_cr50.c:681: warning: Excess function parameter 'id' description in 'tpm_cr50_i2c_probe'
>
> and fix a spelling error reported by codespell.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Peter Huewe <[email protected]>
> Cc: Jarkko Sakkinen <[email protected]>
> Cc: Jason Gunthorpe <[email protected]>
> Cc: [email protected]
> ---
> drivers/char/tpm/tpm_tis_i2c_cr50.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -- a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> --- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
> +++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> @@ -235,7 +235,7 @@ out:
> * @len: Number of bytes to write.
> *
> * The provided address is prepended to the data in 'buffer', the
> - * cobined address+data is sent to the TPM, then wait for TPM to
> + * combined address+data is sent to the TPM, then wait for TPM to
> * indicate it is done writing.
> *
> * Return:
> @@ -671,7 +671,6 @@ MODULE_DEVICE_TABLE(of, of_cr50_i2c_matc
> /**
> * tpm_cr50_i2c_probe() - Driver probe function.
> * @client: I2C client information.
> - * @id: I2C device id.
> *
> * Return:
> * - 0: Success.


Reviewed-by: Jarkko Sakkinen <[email protected]>

BR, Jarkko