LinuxLists.cc - linux-next: build warning after merge of the dmaengine tree

2023-12-22 03:30:30

Subject: linux-next: build warning after merge of the dmaengine tree

Hi all,

After merging the dmaengine tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/dma/xilinx/xdma.c:729:1: warning: no previous prototype for 'xdma_prep_interleaved_dma' [-Wmissing-prototypes]
729 | xdma_prep_interleaved_dma(struct dma_chan *chan,
| ^~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

01e6d9076561 ("dmaengine: xilinx: xdma: Implement interleaved DMA transfers")

It should probably be static.

--
Cheers,
Stephen Rothwell

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2023-12-22 09:45:17

by Vinod Koul

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the dmaengine tree

On 22-12-23, 14:29, Stephen Rothwell wrote:
> Hi all,
>
> After merging the dmaengine tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/dma/xilinx/xdma.c:729:1: warning: no previous prototype for 'xdma_prep_interleaved_dma' [-Wmissing-prototypes]
> 729 | xdma_prep_interleaved_dma(struct dma_chan *chan,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> 01e6d9076561 ("dmaengine: xilinx: xdma: Implement interleaved DMA transfers")
>
> It should probably be static.

Right, fixed and sent the patch

https://lore.kernel.org/all/[email protected]/

Thanks for the report

--
~Vinod