2023-12-22 23:17:57

by Jan Kuliga

[permalink] [raw]
Subject: [PATCH] dmaengine: xilinx: xdma: Fix kernel-doc warnings

Replace hyphens with colons where necessary.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Jan Kuliga <[email protected]>
---
drivers/dma/xilinx/xdma.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
index 4ebc90b41bdb..927c68ed6bbc 100644
--- a/drivers/dma/xilinx/xdma.c
+++ b/drivers/dma/xilinx/xdma.c
@@ -548,11 +548,11 @@ static void xdma_synchronize(struct dma_chan *chan)

/**
* xdma_fill_descs - Fill hardware descriptors with contiguous memory block addresses
- * @sw_desc - tx descriptor state container
- * @src_addr - Value for a ->src_addr field of a first descriptor
- * @dst_addr - Value for a ->dst_addr field of a first descriptor
- * @size - Total size of a contiguous memory block
- * @filled_descs_num - Number of filled hardware descriptors for corresponding sw_desc
+ * @sw_desc: tx descriptor state container
+ * @src_addr: Value for a ->src_addr field of a first descriptor
+ * @dst_addr: Value for a ->dst_addr field of a first descriptor
+ * @size: Total size of a contiguous memory block
+ * @filled_descs_num: Number of filled hardware descriptors for corresponding sw_desc
*/
static inline u32 xdma_fill_descs(struct xdma_desc *sw_desc, u64 src_addr,
u64 dst_addr, u32 size, u32 filled_descs_num)
--
2.34.1



2023-12-22 23:28:55

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: xilinx: xdma: Fix kernel-doc warnings



On 12/22/23 15:17, Jan Kuliga wrote:
> Replace hyphens with colons where necessary.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Jan Kuliga <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> drivers/dma/xilinx/xdma.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
> index 4ebc90b41bdb..927c68ed6bbc 100644
> --- a/drivers/dma/xilinx/xdma.c
> +++ b/drivers/dma/xilinx/xdma.c
> @@ -548,11 +548,11 @@ static void xdma_synchronize(struct dma_chan *chan)
>
> /**
> * xdma_fill_descs - Fill hardware descriptors with contiguous memory block addresses
> - * @sw_desc - tx descriptor state container
> - * @src_addr - Value for a ->src_addr field of a first descriptor
> - * @dst_addr - Value for a ->dst_addr field of a first descriptor
> - * @size - Total size of a contiguous memory block
> - * @filled_descs_num - Number of filled hardware descriptors for corresponding sw_desc
> + * @sw_desc: tx descriptor state container
> + * @src_addr: Value for a ->src_addr field of a first descriptor
> + * @dst_addr: Value for a ->dst_addr field of a first descriptor
> + * @size: Total size of a contiguous memory block
> + * @filled_descs_num: Number of filled hardware descriptors for corresponding sw_desc
> */
> static inline u32 xdma_fill_descs(struct xdma_desc *sw_desc, u64 src_addr,
> u64 dst_addr, u32 size, u32 filled_descs_num)

--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html

2024-01-19 12:52:32

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: xilinx: xdma: Fix kernel-doc warnings


On Sat, 23 Dec 2023 00:17:28 +0100, Jan Kuliga wrote:
> Replace hyphens with colons where necessary.
>
>

Applied, thanks!

[1/1] dmaengine: xilinx: xdma: Fix kernel-doc warnings
commit: f829bca2e294bc2953bd2dadb93d72a9987b3110

Best regards,
--
~Vinod