2023-12-23 05:08:11

by Randy Dunlap

Subject: [PATCH] media: media-entity.h: fix Excess kernel-doc description warnings

Remove the @major: and @minor: lines to prevent the kernel-doc warnings:

include/media/media-entity.h:376: warning: Excess struct member 'major' description in 'media_entity'
include/media/media-entity.h:376: warning: Excess struct member 'minor' description in 'media_entity'

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Sakari Ailus <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
---
include/media/media-entity.h | 4 ----
1 file changed, 4 deletions(-)

diff -- a/include/media/media-entity.h b/include/media/media-entity.h
--- a/include/media/media-entity.h
+++ b/include/media/media-entity.h
@@ -337,10 +337,6 @@ enum media_entity_type {
* @info.dev: Contains device major and minor info.
* @info.dev.major: device node major, if the device is a devnode.
* @info.dev.minor: device node minor, if the device is a devnode.
- * @major: Devnode major number (zero if not applicable). Kept just
- * for backward compatibility.
- * @minor: Devnode minor number (zero if not applicable). Kept just
- * for backward compatibility.
*
* .. note::
*

2023-12-23 14:13:01

by Laurent Pinchart

Subject: Re: [PATCH] media: media-entity.h: fix Excess kernel-doc description warnings

Hi Randy,

Thank you for the patch.

On Fri, Dec 22, 2023 at 09:07:07PM -0800, Randy Dunlap wrote:
> Remove the @major: and @minor: lines to prevent the kernel-doc warnings:
>
> include/media/media-entity.h:376: warning: Excess struct member 'major' description in 'media_entity'
> include/media/media-entity.h:376: warning: Excess struct member 'minor' description in 'media_entity'
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Sakari Ailus <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: [email protected]

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> include/media/media-entity.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff -- a/include/media/media-entity.h b/include/media/media-entity.h
> --- a/include/media/media-entity.h
> +++ b/include/media/media-entity.h
> @@ -337,10 +337,6 @@ enum media_entity_type {
> * @info.dev: Contains device major and minor info.
> * @info.dev.major: device node major, if the device is a devnode.
> * @info.dev.minor: device node minor, if the device is a devnode.
> - * @major: Devnode major number (zero if not applicable). Kept just
> - * for backward compatibility.
> - * @minor: Devnode minor number (zero if not applicable). Kept just
> - * for backward compatibility.
> *
> * .. note::
> *

--
Regards,

Laurent Pinchart