2023-12-28 21:09:14

by Malkoot Khan

Subject: [PATCH] drivers/accel/habanalabs: Remove unnecessary braces from if statement

The coding style in the Linux kernel prefers not to use
braces for single-statement if conditions.
This patch removes the unnecessary braces from an if statement
in the file drivers/accel/habanalabs/common/command_submission.c,
which also resolves a coding style warning.

Signed-off-by: Malkoot Khan <[email protected]>
---
drivers/accel/habanalabs/common/command_submission.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/accel/habanalabs/common/command_submission.c b/drivers/accel/habanalabs/common/command_submission.c
index 3aa6eeef443b..39e23d625a3c 100644
--- a/drivers/accel/habanalabs/common/command_submission.c
+++ b/drivers/accel/habanalabs/common/command_submission.c
@@ -1360,9 +1360,8 @@ static int hl_cs_sanity_checks(struct hl_fpriv *hpriv, union hl_cs_args *args)
return -EINVAL;
}

- if (!hl_device_operational(hdev, &status)) {
+ if (!hl_device_operational(hdev, &status))
return -EBUSY;
- }

if ((args->in.cs_flags & HL_CS_FLAGS_STAGED_SUBMISSION) &&
!hdev->supports_staged_submission) {
--
2.34.1

2024-01-03 15:43:04

by Oded Gabbay

Subject: Re: [PATCH] drivers/accel/habanalabs: Remove unnecessary braces from if statement

On 28/12/2023 23:08, Malkoot Khan wrote:
> The coding style in the Linux kernel prefers not to use
> braces for single-statement if conditions.
> This patch removes the unnecessary braces from an if statement
> in the file drivers/accel/habanalabs/common/command_submission.c,
> which also resolves a coding style warning.
>
> Signed-off-by: Malkoot Khan <[email protected]>
> ---
> drivers/accel/habanalabs/common/command_submission.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/accel/habanalabs/common/command_submission.c b/drivers/accel/habanalabs/common/command_submission.c
> index 3aa6eeef443b..39e23d625a3c 100644
> --- a/drivers/accel/habanalabs/common/command_submission.c
> +++ b/drivers/accel/habanalabs/common/command_submission.c
> @@ -1360,9 +1360,8 @@ static int hl_cs_sanity_checks(struct hl_fpriv *hpriv, union hl_cs_args *args)
> return -EINVAL;
> }
>
> - if (!hl_device_operational(hdev, &status)) {
> + if (!hl_device_operational(hdev, &status))
> return -EBUSY;
> - }
>
> if ((args->in.cs_flags & HL_CS_FLAGS_STAGED_SUBMISSION) &&
> !hdev->supports_staged_submission) {

Thanks for the patch.
Reviewed-by: Oded Gabbay <[email protected]>
Applied to -next.
Oded