MT8186 has 4 iommus in the list, to cope with this situation, adjust
the maxItems to 4 (instead of previous 2).
Add also minItems as 1 since iommus are mandatory, to avoid warning
on the example.
Signed-off-by: Eugen Hristev <[email protected]>
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
---
Changes in v2:
fixed typo in subject
.../devicetree/bindings/media/mediatek-jpeg-encoder.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
index 37800e1908cc..60c75b9312e8 100644
--- a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
@@ -38,7 +38,8 @@ properties:
maxItems: 1
iommus:
- maxItems: 2
+ minItems: 1
+ maxItems: 4
description: |
Points to the respective IOMMU block with master port as argument, see
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details.
--
2.34.1
From: Allen-KH Cheng <[email protected]>
Add JPEG encoder node.
Signed-off-by: Allen-KH Cheng <[email protected]>
Reviewed-by: Hsin-Yi Wang <[email protected]>
Reviewed-by: Max Staudt <[email protected]>
Tested-by: Max Staudt <[email protected]>
Reviewed-by: Ricardo Ribalda <[email protected]>
[[email protected]: minor cleanup]
Signed-off-by: Eugen Hristev <[email protected]>
---
Changes in v2:
- renamed node
- reordered props
arch/arm64/boot/dts/mediatek/mt8186.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
index e451b6c8cd9e..8e57a7be67ad 100644
--- a/arch/arm64/boot/dts/mediatek/mt8186.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
@@ -2054,6 +2054,19 @@ venc: video-encoder@17020000 {
mediatek,scp = <&scp>;
};
+ jpgenc: jpeg-encoder@17030000 {
+ compatible = "mediatek,mt8186-jpgenc", "mediatek,mtk-jpgenc";
+ reg = <0 0x17030000 0 0x10000>;
+ interrupts = <GIC_SPI 245 IRQ_TYPE_LEVEL_HIGH 0>;
+ clocks = <&vencsys CLK_VENC_CKE2_JPGENC>;
+ clock-names = "jpgenc";
+ iommus = <&iommu_mm IOMMU_PORT_L7_JPGENC_Y_RDMA>,
+ <&iommu_mm IOMMU_PORT_L7_JPGENC_C_RDMA>,
+ <&iommu_mm IOMMU_PORT_L7_JPGENC_Q_TABLE>,
+ <&iommu_mm IOMMU_PORT_L7_JPGENC_BSDMA>;
+ power-domains = <&spm MT8186_POWER_DOMAIN_VENC>;
+ };
+
camsys: clock-controller@1a000000 {
compatible = "mediatek,mt8186-camsys";
reg = <0 0x1a000000 0 0x1000>;
--
2.34.1
Il 02/01/24 11:38, Eugen Hristev ha scritto:
> From: Allen-KH Cheng <[email protected]>
>
> Add JPEG encoder node.
>
> Signed-off-by: Allen-KH Cheng <[email protected]>
> Reviewed-by: Hsin-Yi Wang <[email protected]>
> Reviewed-by: Max Staudt <[email protected]>
> Tested-by: Max Staudt <[email protected]>
> Reviewed-by: Ricardo Ribalda <[email protected]>
> [[email protected]: minor cleanup]
> Signed-off-by: Eugen Hristev <[email protected]>
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
On Tue, Jan 02, 2024 at 12:38:00PM +0200, Eugen Hristev wrote:
> MT8186 has 4 iommus in the list, to cope with this situation, adjust
> the maxItems to 4 (instead of previous 2).
> Add also minItems as 1 since iommus are mandatory, to avoid warning
> on the example.
maxItems alone means minItems is the same size. If IOMMU is required,
then 'required' is where that is defined. Is there a case where 1 IOMMU
is valid? If so, what h/w has this case.
Rob