2024-01-02 17:39:33

by Randy Dunlap

Subject: [PATCH] cxl/region: use %pap format to print resource_size_t

Use "%pap" to print a resource_size_t (phys_addr_t derived type)
to prevent build warnings on 32-bit arches (seen on i386 and
riscv-32).

../drivers/cxl/core/region.c: In function 'alloc_hpa':
../drivers/cxl/core/region.c:556:25: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
556 | "HPA allocation error (%ld) for size:%#llx in %s %pr\n",

Fixes: 7984d22f1315 ("cxl/region: Add dev_dbg() detail on failure to allocate HPA space")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Fan Ni <[email protected]>
Cc: Davidlohr Bueso <[email protected]>
Cc: Jonathan Cameron <[email protected]>
Cc: Dave Jiang <[email protected]>
Cc: Alison Schofield <[email protected]>
Cc: Vishal Verma <[email protected]>
Cc: Ira Weiny <[email protected]>
Cc: Dan Williams <[email protected]>
Cc: [email protected]
---
drivers/cxl/core/region.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff -- a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -553,8 +553,8 @@ static int alloc_hpa(struct cxl_region *
dev_name(&cxlr->dev));
if (IS_ERR(res)) {
dev_dbg(&cxlr->dev,
- "HPA allocation error (%ld) for size:%#llx in %s %pr\n",
- PTR_ERR(res), size, cxlrd->res->name, cxlrd->res);
+ "HPA allocation error (%ld) for size:%pap in %s %pr\n",
+ PTR_ERR(res), &size, cxlrd->res->name, cxlrd->res);
return PTR_ERR(res);
}

2024-01-02 19:06:02

by Dan Williams

Subject: RE: [PATCH] cxl/region: use %pap format to print resource_size_t

Randy Dunlap wrote:
> Use "%pap" to print a resource_size_t (phys_addr_t derived type)
> to prevent build warnings on 32-bit arches (seen on i386 and
> riscv-32).
>
> ../drivers/cxl/core/region.c: In function 'alloc_hpa':
> ../drivers/cxl/core/region.c:556:25: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
> 556 | "HPA allocation error (%ld) for size:%#llx in %s %pr\n",
>
> Fixes: 7984d22f1315 ("cxl/region: Add dev_dbg() detail on failure to allocate HPA space")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Fan Ni <[email protected]>
> Cc: Davidlohr Bueso <[email protected]>
> Cc: Jonathan Cameron <[email protected]>
> Cc: Dave Jiang <[email protected]>
> Cc: Alison Schofield <[email protected]>
> Cc: Vishal Verma <[email protected]>
> Cc: Ira Weiny <[email protected]>
> Cc: Dan Williams <[email protected]>
> Cc: [email protected]
> ---
> drivers/cxl/core/region.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks Randy.