2023-12-28 16:44:19

by Malkoot Khan

Subject: [PATCH] tcp: fixed whitespace trailing error

Corrected whitespaces trailing error

Signed-off-by: Malkoot Khan <[email protected]>
---
net/ipv4/tcp_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c
index 1f9f6c1c196b..b7d0f8aee7ff 100644
--- a/net/ipv4/tcp_timer.c
+++ b/net/ipv4/tcp_timer.c
@@ -542,7 +542,7 @@ void tcp_retransmit_timer(struct sock *sk)
struct inet_sock *inet = inet_sk(sk);
u32 rtx_delta;

- rtx_delta = tcp_time_stamp_ts(tp) - (tp->retrans_stamp ?:
+ rtx_delta = tcp_time_stamp_ts(tp) - (tp->retrans_stamp ? :
tcp_skb_timestamp_ts(tp->tcp_usec_ts, skb));
if (tp->tcp_usec_ts)
rtx_delta /= USEC_PER_MSEC;
--
2.34.1

2024-01-03 22:00:55

by Jakub Kicinski

Subject: Re: [PATCH] tcp: fixed whitespace trailing error

On Thu, 28 Dec 2023 16:42:50 +0000 Malkoot Khan wrote:
> - rtx_delta = tcp_time_stamp_ts(tp) - (tp->retrans_stamp ?:
> + rtx_delta = tcp_time_stamp_ts(tp) - (tp->retrans_stamp ? :

Don't insert the space between the ? and :, tho, please.
--
pw-bot: cr