2024-01-02 21:16:13

by Thomas Lange

Subject: [PATCH net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support

Commit 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW") added the new
socket option SO_TIMESTAMPING_NEW. However, it was never implemented in
__sock_cmsg_send thus breaking SO_TIMESTAMPING cmsg for platforms using
SO_TIMESTAMPING_NEW.

Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
Link: https://lore.kernel.org/netdev/[email protected]/
Signed-off-by: Thomas Lange <[email protected]>
---
net/core/sock.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/core/sock.c b/net/core/sock.c
index 51d52859e942..d02534c77413 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -2813,6 +2813,7 @@ int __sock_cmsg_send(struct sock *sk, struct cmsghdr *cmsg,
sockc->mark = *(u32 *)CMSG_DATA(cmsg);
break;
case SO_TIMESTAMPING_OLD:
+ case SO_TIMESTAMPING_NEW:
if (cmsg->cmsg_len != CMSG_LEN(sizeof(u32)))
return -EINVAL;

--
2.39.2

2024-01-02 21:22:09

by Arnd Bergmann

Subject: Re: [PATCH net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support

On Tue, Jan 2, 2024, at 22:13, Thomas Lange wrote:
> Commit 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW") added the new
> socket option SO_TIMESTAMPING_NEW. However, it was never implemented in
> __sock_cmsg_send thus breaking SO_TIMESTAMPING cmsg for platforms using
> SO_TIMESTAMPING_NEW.
>
> Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
> Link:
> https://lore.kernel.org/netdev/[email protected]/
> Signed-off-by: Thomas Lange <[email protected]>

Cc: [email protected]
Acked-by: Arnd Bergmann <[email protected]>

2024-01-02 22:04:30

by Willem de Bruijn

Subject: Re: [PATCH net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support

Arnd Bergmann wrote:
> On Tue, Jan 2, 2024, at 22:13, Thomas Lange wrote:
> > Commit 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW") added the new
> > socket option SO_TIMESTAMPING_NEW. However, it was never implemented in
> > __sock_cmsg_send thus breaking SO_TIMESTAMPING cmsg for platforms using
> > SO_TIMESTAMPING_NEW.
> >
> > Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
> > Link:
> > https://lore.kernel.org/netdev/[email protected]/
> > Signed-off-by: Thomas Lange <[email protected]>
>
> Cc: [email protected]
> Acked-by: Arnd Bergmann <[email protected]>

Reviewed-by: Willem de Bruijn <[email protected]>

2024-01-03 22:10:00

by Jakub Kicinski

Subject: Re: [PATCH net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support

On Tue, 2 Jan 2024 22:13:50 +0100 Thomas Lange wrote:
> Commit 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW") added the new
> socket option SO_TIMESTAMPING_NEW. However, it was never implemented in
> __sock_cmsg_send thus breaking SO_TIMESTAMPING cmsg for platforms using
> SO_TIMESTAMPING_NEW.
>
> Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
> Link: https://lore.kernel.org/netdev/[email protected]/
> Signed-off-by: Thomas Lange <[email protected]>

patch looks mangled, could you resend with git send-email?
There are multiple spaces at the start of the diff lines.
--
pw-bot: cr