2024-01-04 12:52:19

by Quentin Schulz

Subject: [PATCH 2/2] drm/panel: ltk050h3146w: use dev_err_probe wherever possible

From: Quentin Schulz <[email protected]>



This is only a cosmetic change.



This replaces a hand-crafted EPROBE_DEFER handling for deciding to print

an error message with dev_err_probe.



A side-effect is that dev_err_probe also adds a debug message when it's

not EPROBE_DEFER, but this is seen as an improvement.



Cc: Quentin Schulz <[email protected]>

Signed-off-by: Quentin Schulz <[email protected]>

---

drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 17 +++++------------

1 file changed, 5 insertions(+), 12 deletions(-)



diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c

index ecfa4181c4fd9..9d87cc1a357e3 100644

--- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c

+++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c

@@ -650,20 +650,13 @@ static int ltk050h3146w_probe(struct mipi_dsi_device *dsi)

return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), "cannot get reset gpio\n");



ctx->vci = devm_regulator_get(dev, "vci");

- if (IS_ERR(ctx->vci)) {

- ret = PTR_ERR(ctx->vci);

- if (ret != -EPROBE_DEFER)

- dev_err(dev, "Failed to request vci regulator: %d\n", ret);

- return ret;

- }

+ if (IS_ERR(ctx->vci))

+ return dev_err_probe(dev, PTR_ERR(ctx->vci), "Failed to request vci regulator\n");



ctx->iovcc = devm_regulator_get(dev, "iovcc");

- if (IS_ERR(ctx->iovcc)) {

- ret = PTR_ERR(ctx->iovcc);

- if (ret != -EPROBE_DEFER)

- dev_err(dev, "Failed to request iovcc regulator: %d\n", ret);

- return ret;

- }

+ if (IS_ERR(ctx->iovcc))

+ return dev_err_probe(dev, PTR_ERR(ctx->iovcc),

+ "Failed to request iovcc regulator\n");



mipi_dsi_set_drvdata(dsi, ctx);





--

2.43.0

2024-01-04 14:16:18

by Christophe JAILLET

Subject: Re: [PATCH 2/2] drm/panel: ltk050h3146w: use dev_err_probe wherever possible

Le 04/01/2024 à 13:41, Quentin Schulz a écrit :
> From: Quentin Schulz <[email protected]>
>
> This is only a cosmetic change.
>
> This replaces a hand-crafted EPROBE_DEFER handling for deciding to print
> an error message with dev_err_probe.
>
> A side-effect is that dev_err_probe also adds a debug message when it's
> not EPROBE_DEFER, but this is seen as an improvement.
>
> Cc: Quentin Schulz <[email protected]>
> Signed-off-by: Quentin Schulz <[email protected]>

Reviewed-by: Christophe JAILLET <[email protected]>

> ---
> drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 17 +++++------------
> 1 file changed, 5 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
> index ecfa4181c4fd9..9d87cc1a357e3 100644
> --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
> +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
> @@ -650,20 +650,13 @@ static int ltk050h3146w_probe(struct mipi_dsi_device *dsi)
> return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), "cannot get reset gpio\n");
>
> ctx->vci = devm_regulator_get(dev, "vci");
> - if (IS_ERR(ctx->vci)) {
> - ret = PTR_ERR(ctx->vci);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "Failed to request vci regulator: %d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(ctx->vci))
> + return dev_err_probe(dev, PTR_ERR(ctx->vci), "Failed to request vci regulator\n");
>
> ctx->iovcc = devm_regulator_get(dev, "iovcc");
> - if (IS_ERR(ctx->iovcc)) {
> - ret = PTR_ERR(ctx->iovcc);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "Failed to request iovcc regulator: %d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(ctx->iovcc))
> + return dev_err_probe(dev, PTR_ERR(ctx->iovcc),
> + "Failed to request iovcc regulator\n");
>
> mipi_dsi_set_drvdata(dsi, ctx);
>
>