2024-01-05 06:53:26

by Artur Weber

Subject: [PATCH v2 0/2] Fix panel polarity mixup in S6D7AA0 panel driver and Galaxy Tab 3 8.0 DTSI

Two small one-line patches to address a mixup in the Samsung S6D7AA0
panel driver and the Samsung Galaxy Tab 3 8.0 board it was initially
added for.

Signed-off-by: Artur Weber <[email protected]>
---
Changes in v2:
- Add "Fixes" tag to both commits.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Artur Weber (2):
ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd
drm/panel: samsung-s6d7aa0: drop DRM_BUS_FLAG_DE_HIGH for lsl080al02

arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 1 +
drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
---
base-commit: fa4131df22d181c0f721bfc6a68addb8fc62c03d
change-id: 20240101-tab3-display-fixes-6516f0b6a1a1

Best regards,
--
Artur Weber <[email protected]>

2024-01-05 06:53:39

by Artur Weber

Subject: [PATCH v2 1/2] ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd

After more investigation, I've found that it's not the panel driver
config that needs to be modified to invert the data polarity, but
the FIMD config.

Add the missing invert-vclk option that is required to get the display
to work correctly.

Fixes: ee37a457af1d ("ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards")
Signed-off-by: Artur Weber <[email protected]>
---
arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi
index d7954ff466b4..e5254e32aa8f 100644
--- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi
@@ -434,6 +434,7 @@ &exynos_usbphy {
};

&fimd {
+ samsung,invert-vclk;
status = "okay";
};


--
2.43.0

2024-01-12 09:29:11

by Neil Armstrong

Subject: Re: (subset) [PATCH v2 0/2] Fix panel polarity mixup in S6D7AA0 panel driver and Galaxy Tab 3 8.0 DTSI

Hi,

On Fri, 05 Jan 2024 07:53:00 +0100, Artur Weber wrote:
> Two small one-line patches to address a mixup in the Samsung S6D7AA0
> panel driver and the Samsung Galaxy Tab 3 8.0 board it was initially
> added for.
>
>

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)

[2/2] drm/panel: samsung-s6d7aa0: drop DRM_BUS_FLAG_DE_HIGH for lsl080al02
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=62b143b5ec4a14e1ae0dede5aabaf1832e3b0073

--
Neil

2024-01-22 11:44:00

by Krzysztof Kozlowski

Subject: Re: (subset) [PATCH v2 1/2] ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd

On Fri, 05 Jan 2024 07:53:01 +0100, Artur Weber wrote:
> After more investigation, I've found that it's not the panel driver
> config that needs to be modified to invert the data polarity, but
> the FIMD config.
>
> Add the missing invert-vclk option that is required to get the display
> to work correctly.
>
> [...]

Applied, thanks!

[1/2] ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd
https://git.kernel.org/krzk/linux/c/eab4f56d3e75dad697acf8dc2c8be3c341d6c63e

Best regards,
--
Krzysztof Kozlowski <[email protected]>