On ARM64 platforms, id->data is a 64-bit value and casting it to a
32-bit integer causes build errors. Cast it to uintptr_t instead.
The id->driver_data cast is unnecessary, so drop it.
Signed-off-by: Duje Mihanović <[email protected]>
---
This patch is necessary for my Marvell PXA1908 series to compile successfully
with allyesconfig:
https://lore.kernel.org/all/[email protected]/
Changes in v2:
- Change first cast to (uintptr_t)
- Drop second cast
- Link to v1: https://lore.kernel.org/[email protected]
---
drivers/soc/pxa/ssp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/pxa/ssp.c b/drivers/soc/pxa/ssp.c
index a1e8a07f7275..7af04e8b8163 100644
--- a/drivers/soc/pxa/ssp.c
+++ b/drivers/soc/pxa/ssp.c
@@ -152,11 +152,11 @@ static int pxa_ssp_probe(struct platform_device *pdev)
if (dev->of_node) {
const struct of_device_id *id =
of_match_device(of_match_ptr(pxa_ssp_of_ids), dev);
- ssp->type = (int) id->data;
+ ssp->type = (uintptr_t) id->data;
} else {
const struct platform_device_id *id =
platform_get_device_id(pdev);
- ssp->type = (int) id->driver_data;
+ ssp->type = id->driver_data;
/* PXA2xx/3xx SSP ports starts from 1 and the internal pdev->id
* starts from 0, do a translation here
---
base-commit: 610a9b8f49fbcf1100716370d3b5f6f884a2835a
change-id: 20240106-pxa-ssp-522745d42418
Best regards,
--
Duje Mihanović <[email protected]>
Hello Duje,
On Sat, Jan 06, 2024 at 03:11:33PM +0100, Duje Mihanović wrote:
> On ARM64 platforms, id->data is a 64-bit value and casting it to a
> 32-bit integer causes build errors. Cast it to uintptr_t instead.
>
> The id->driver_data cast is unnecessary, so drop it.
>
> Signed-off-by: Duje Mihanović <[email protected]>
Reviewed-by: Uwe Kleine-König <[email protected]>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |