Add support for the 1080x2408 Novatek NT36672E LCD DSI mode panel
found on the Qualcomm QCM6490 MTP board.
The driver will come with the uncompressed video mode support.
---
v2: Fixed review comments from Krzysztof
- renamed to novatek,nt36672e, since the driver is for the IC and
not the panel. Adjusted internal function names to reflect the same.
- updated dt-bindings.
---
Ritesh Kumar (2):
dt-bindings: display: panel: Add Novatek NT36672E LCD DSI
drm/panel: Add support for Novatek NT36672E panel driver
.../display/panel/novatek,nt36672e.yaml | 66 ++
drivers/gpu/drm/panel/Kconfig | 10 +
drivers/gpu/drm/panel/Makefile | 1 +
.../gpu/drm/panel/panel-novatek-nt36672e.c | 643 ++++++++++++++++++
4 files changed, 720 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt36672e.c
--
2.17.1
Add support for the 1080x2408 Novatek NT36672E video mode
DSI panel driver.
Signed-off-by: Ritesh Kumar <[email protected]>
---
v2: Fixed review comments from Krzysztof
- renamed the panel driver file to reflect that this is a novatek IC.
- adjusted internal function names to reflect the same.
- corrected compatible string accordingly.
- updated CONFIG for the same.
---
drivers/gpu/drm/panel/Kconfig | 10 +
drivers/gpu/drm/panel/Makefile | 1 +
.../gpu/drm/panel/panel-novatek-nt36672e.c | 643 ++++++++++++++++++
3 files changed, 654 insertions(+)
create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt36672e.c
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 99e14dc212ec..052aaef7d6a2 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -429,6 +429,16 @@ config DRM_PANEL_NOVATEK_NT36672A
around the Novatek NT36672A display controller, such as some
Tianma panels used in a few Xiaomi Poco F1 mobile phones.
+config DRM_PANEL_NOVATEK_NT36672E
+ tristate "Novatek NT36672E DSI panel"
+ depends on OF
+ depends on DRM_MIPI_DSI
+ depends on BACKLIGHT_CLASS_DEVICE
+ help
+ Say Y here if you want to enable support for Novatek NT36672E DSI Video Mode
+ LCD panel module. The panel has a resolution of 1080x2408 and uses 24 bit
+ RGB per pixel.
+
config DRM_PANEL_NOVATEK_NT39016
tristate "Novatek NT39016 RGB/SPI panel"
depends on OF && SPI
diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
index d10c3de51c6d..93a544a8937c 100644
--- a/drivers/gpu/drm/panel/Makefile
+++ b/drivers/gpu/drm/panel/Makefile
@@ -40,6 +40,7 @@ obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35560) += panel-novatek-nt35560.o
obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35950) += panel-novatek-nt35950.o
obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36523) += panel-novatek-nt36523.o
obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36672A) += panel-novatek-nt36672a.o
+obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36672E) += panel-novatek-nt36672e.o
obj-$(CONFIG_DRM_PANEL_NOVATEK_NT39016) += panel-novatek-nt39016.o
obj-$(CONFIG_DRM_PANEL_MANTIX_MLAF057WE51) += panel-mantix-mlaf057we51.o
obj-$(CONFIG_DRM_PANEL_OLIMEX_LCD_OLINUXINO) += panel-olimex-lcd-olinuxino.o
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c
new file mode 100644
index 000000000000..d4e85c2fc899
--- /dev/null
+++ b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c
@@ -0,0 +1,643 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
+
+#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include <linux/regulator/consumer.h>
+
+#include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modes.h>
+#include <drm/drm_panel.h>
+
+#include <video/mipi_display.h>
+
+static const char * const regulator_names[] = {
+ "vddi",
+ "avdd",
+ "avee",
+};
+
+static const unsigned long regulator_enable_loads[] = {
+ 62000,
+ 100000,
+ 100000,
+};
+
+static const unsigned long regulator_disable_loads[] = {
+ 80,
+ 100,
+ 100,
+};
+
+struct panel_desc {
+ const struct drm_display_mode *display_mode;
+ u32 width_mm;
+ u32 height_mm;
+ unsigned long mode_flags;
+ enum mipi_dsi_pixel_format format;
+ unsigned int lanes;
+ const char *panel_name;
+ int (*init_sequence)(struct mipi_dsi_device *dsi);
+};
+
+struct nt36672e_panel {
+ struct drm_panel panel;
+ struct mipi_dsi_device *dsi;
+ struct gpio_desc *reset_gpio;
+ struct regulator_bulk_data supplies[3];
+ const struct panel_desc *desc;
+};
+
+static inline struct nt36672e_panel *to_nt36672e_panel(struct drm_panel *panel)
+{
+ return container_of(panel, struct nt36672e_panel, panel);
+}
+
+static int nt36672e_1080x2408_60hz_init(struct mipi_dsi_device *dsi)
+{
+ mipi_dsi_dcs_write_seq(dsi, 0xff, 0x10);
+ mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0xb0, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0xc0, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0xc1, 0x89, 0x28, 0x00, 0x08, 0x00, 0xaa, 0x02,
+ 0x0e, 0x00, 0x2b, 0x00, 0x07, 0x0d, 0xb7, 0x0c, 0xb7);
+
+ mipi_dsi_dcs_write_seq(dsi, 0xc2, 0x1b, 0xa0);
+ mipi_dsi_dcs_write_seq(dsi, 0xff, 0x20);
+ mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x01, 0x66);
+ mipi_dsi_dcs_write_seq(dsi, 0x06, 0x40);
+ mipi_dsi_dcs_write_seq(dsi, 0x07, 0x38);
+ mipi_dsi_dcs_write_seq(dsi, 0x2f, 0x83);
+ mipi_dsi_dcs_write_seq(dsi, 0x69, 0x91);
+ mipi_dsi_dcs_write_seq(dsi, 0x95, 0xd1);
+ mipi_dsi_dcs_write_seq(dsi, 0x96, 0xd1);
+ mipi_dsi_dcs_write_seq(dsi, 0xf2, 0x64);
+ mipi_dsi_dcs_write_seq(dsi, 0xf3, 0x54);
+ mipi_dsi_dcs_write_seq(dsi, 0xf4, 0x64);
+ mipi_dsi_dcs_write_seq(dsi, 0xf5, 0x54);
+ mipi_dsi_dcs_write_seq(dsi, 0xf6, 0x64);
+ mipi_dsi_dcs_write_seq(dsi, 0xf7, 0x54);
+ mipi_dsi_dcs_write_seq(dsi, 0xf8, 0x64);
+ mipi_dsi_dcs_write_seq(dsi, 0xf9, 0x54);
+ mipi_dsi_dcs_write_seq(dsi, 0xff, 0x24);
+ mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x01, 0x0f);
+ mipi_dsi_dcs_write_seq(dsi, 0x03, 0x0c);
+ mipi_dsi_dcs_write_seq(dsi, 0x05, 0x1d);
+ mipi_dsi_dcs_write_seq(dsi, 0x08, 0x2f);
+ mipi_dsi_dcs_write_seq(dsi, 0x09, 0x2e);
+ mipi_dsi_dcs_write_seq(dsi, 0x0a, 0x2d);
+ mipi_dsi_dcs_write_seq(dsi, 0x0b, 0x2c);
+ mipi_dsi_dcs_write_seq(dsi, 0x11, 0x17);
+ mipi_dsi_dcs_write_seq(dsi, 0x12, 0x13);
+ mipi_dsi_dcs_write_seq(dsi, 0x13, 0x15);
+ mipi_dsi_dcs_write_seq(dsi, 0x15, 0x14);
+ mipi_dsi_dcs_write_seq(dsi, 0x16, 0x16);
+ mipi_dsi_dcs_write_seq(dsi, 0x17, 0x18);
+ mipi_dsi_dcs_write_seq(dsi, 0x1b, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x1d, 0x1d);
+ mipi_dsi_dcs_write_seq(dsi, 0x20, 0x2f);
+ mipi_dsi_dcs_write_seq(dsi, 0x21, 0x2e);
+ mipi_dsi_dcs_write_seq(dsi, 0x22, 0x2d);
+ mipi_dsi_dcs_write_seq(dsi, 0x23, 0x2c);
+ mipi_dsi_dcs_write_seq(dsi, 0x29, 0x17);
+ mipi_dsi_dcs_write_seq(dsi, 0x2a, 0x13);
+ mipi_dsi_dcs_write_seq(dsi, 0x2b, 0x15);
+ mipi_dsi_dcs_write_seq(dsi, 0x2f, 0x14);
+ mipi_dsi_dcs_write_seq(dsi, 0x30, 0x16);
+ mipi_dsi_dcs_write_seq(dsi, 0x31, 0x18);
+ mipi_dsi_dcs_write_seq(dsi, 0x32, 0x04);
+ mipi_dsi_dcs_write_seq(dsi, 0x34, 0x10);
+ mipi_dsi_dcs_write_seq(dsi, 0x35, 0x1f);
+ mipi_dsi_dcs_write_seq(dsi, 0x36, 0x1f);
+ mipi_dsi_dcs_write_seq(dsi, 0x4d, 0x14);
+ mipi_dsi_dcs_write_seq(dsi, 0x4e, 0x36);
+ mipi_dsi_dcs_write_seq(dsi, 0x4f, 0x36);
+ mipi_dsi_dcs_write_seq(dsi, 0x53, 0x36);
+ mipi_dsi_dcs_write_seq(dsi, 0x71, 0x30);
+ mipi_dsi_dcs_write_seq(dsi, 0x79, 0x11);
+ mipi_dsi_dcs_write_seq(dsi, 0x7a, 0x82);
+ mipi_dsi_dcs_write_seq(dsi, 0x7b, 0x8f);
+ mipi_dsi_dcs_write_seq(dsi, 0x7d, 0x04);
+ mipi_dsi_dcs_write_seq(dsi, 0x80, 0x04);
+ mipi_dsi_dcs_write_seq(dsi, 0x81, 0x04);
+ mipi_dsi_dcs_write_seq(dsi, 0x82, 0x13);
+ mipi_dsi_dcs_write_seq(dsi, 0x84, 0x31);
+ mipi_dsi_dcs_write_seq(dsi, 0x85, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x86, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x87, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x90, 0x13);
+ mipi_dsi_dcs_write_seq(dsi, 0x92, 0x31);
+ mipi_dsi_dcs_write_seq(dsi, 0x93, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x94, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x95, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x9c, 0xf4);
+ mipi_dsi_dcs_write_seq(dsi, 0x9d, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0xa0, 0x0f);
+ mipi_dsi_dcs_write_seq(dsi, 0xa2, 0x0f);
+ mipi_dsi_dcs_write_seq(dsi, 0xa3, 0x02);
+ mipi_dsi_dcs_write_seq(dsi, 0xa4, 0x04);
+ mipi_dsi_dcs_write_seq(dsi, 0xa5, 0x04);
+ mipi_dsi_dcs_write_seq(dsi, 0xc6, 0xc0);
+ mipi_dsi_dcs_write_seq(dsi, 0xc9, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0xd9, 0x80);
+ mipi_dsi_dcs_write_seq(dsi, 0xe9, 0x02);
+ mipi_dsi_dcs_write_seq(dsi, 0xff, 0x25);
+ mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x18, 0x22);
+ mipi_dsi_dcs_write_seq(dsi, 0x19, 0xe4);
+ mipi_dsi_dcs_write_seq(dsi, 0x21, 0x40);
+ mipi_dsi_dcs_write_seq(dsi, 0x66, 0xd8);
+ mipi_dsi_dcs_write_seq(dsi, 0x68, 0x50);
+ mipi_dsi_dcs_write_seq(dsi, 0x69, 0x10);
+ mipi_dsi_dcs_write_seq(dsi, 0x6b, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x6d, 0x0d);
+ mipi_dsi_dcs_write_seq(dsi, 0x6e, 0x48);
+ mipi_dsi_dcs_write_seq(dsi, 0x72, 0x41);
+ mipi_dsi_dcs_write_seq(dsi, 0x73, 0x4a);
+ mipi_dsi_dcs_write_seq(dsi, 0x74, 0xd0);
+ mipi_dsi_dcs_write_seq(dsi, 0x77, 0x62);
+ mipi_dsi_dcs_write_seq(dsi, 0x79, 0x7e);
+ mipi_dsi_dcs_write_seq(dsi, 0x7d, 0x03);
+ mipi_dsi_dcs_write_seq(dsi, 0x7e, 0x15);
+ mipi_dsi_dcs_write_seq(dsi, 0x7f, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x84, 0x4d);
+ mipi_dsi_dcs_write_seq(dsi, 0xcf, 0x80);
+ mipi_dsi_dcs_write_seq(dsi, 0xd6, 0x80);
+ mipi_dsi_dcs_write_seq(dsi, 0xd7, 0x80);
+ mipi_dsi_dcs_write_seq(dsi, 0xef, 0x20);
+ mipi_dsi_dcs_write_seq(dsi, 0xf0, 0x84);
+ mipi_dsi_dcs_write_seq(dsi, 0xff, 0x26);
+ mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x81, 0x0f);
+ mipi_dsi_dcs_write_seq(dsi, 0x83, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x84, 0x03);
+ mipi_dsi_dcs_write_seq(dsi, 0x85, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x86, 0x03);
+ mipi_dsi_dcs_write_seq(dsi, 0x87, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x88, 0x05);
+ mipi_dsi_dcs_write_seq(dsi, 0x8a, 0x1a);
+ mipi_dsi_dcs_write_seq(dsi, 0x8b, 0x11);
+ mipi_dsi_dcs_write_seq(dsi, 0x8c, 0x24);
+ mipi_dsi_dcs_write_seq(dsi, 0x8e, 0x42);
+ mipi_dsi_dcs_write_seq(dsi, 0x8f, 0x11);
+ mipi_dsi_dcs_write_seq(dsi, 0x90, 0x11);
+ mipi_dsi_dcs_write_seq(dsi, 0x91, 0x11);
+ mipi_dsi_dcs_write_seq(dsi, 0x9a, 0x80);
+ mipi_dsi_dcs_write_seq(dsi, 0x9b, 0x04);
+ mipi_dsi_dcs_write_seq(dsi, 0x9c, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x9d, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x9e, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0xff, 0x27);
+ mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x01, 0x68);
+ mipi_dsi_dcs_write_seq(dsi, 0x20, 0x81);
+ mipi_dsi_dcs_write_seq(dsi, 0x21, 0x6a);
+ mipi_dsi_dcs_write_seq(dsi, 0x25, 0x81);
+ mipi_dsi_dcs_write_seq(dsi, 0x26, 0x94);
+ mipi_dsi_dcs_write_seq(dsi, 0x6e, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x6f, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x70, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x71, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x72, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x75, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x76, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x77, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0x7d, 0x09);
+ mipi_dsi_dcs_write_seq(dsi, 0x7e, 0x67);
+ mipi_dsi_dcs_write_seq(dsi, 0x80, 0x23);
+ mipi_dsi_dcs_write_seq(dsi, 0x82, 0x09);
+ mipi_dsi_dcs_write_seq(dsi, 0x83, 0x67);
+ mipi_dsi_dcs_write_seq(dsi, 0x88, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x89, 0x10);
+ mipi_dsi_dcs_write_seq(dsi, 0xa5, 0x10);
+ mipi_dsi_dcs_write_seq(dsi, 0xa6, 0x23);
+ mipi_dsi_dcs_write_seq(dsi, 0xa7, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0xb6, 0x40);
+ mipi_dsi_dcs_write_seq(dsi, 0xe5, 0x02);
+ mipi_dsi_dcs_write_seq(dsi, 0xe6, 0xd3);
+ mipi_dsi_dcs_write_seq(dsi, 0xeb, 0x03);
+ mipi_dsi_dcs_write_seq(dsi, 0xec, 0x28);
+ mipi_dsi_dcs_write_seq(dsi, 0xff, 0x2a);
+ mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x00, 0x91);
+ mipi_dsi_dcs_write_seq(dsi, 0x03, 0x20);
+ mipi_dsi_dcs_write_seq(dsi, 0x07, 0x50);
+ mipi_dsi_dcs_write_seq(dsi, 0x0a, 0x70);
+ mipi_dsi_dcs_write_seq(dsi, 0x0c, 0x04);
+ mipi_dsi_dcs_write_seq(dsi, 0x0d, 0x40);
+ mipi_dsi_dcs_write_seq(dsi, 0x0f, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x11, 0xe0);
+ mipi_dsi_dcs_write_seq(dsi, 0x15, 0x0f);
+ mipi_dsi_dcs_write_seq(dsi, 0x16, 0xa4);
+ mipi_dsi_dcs_write_seq(dsi, 0x19, 0x0f);
+ mipi_dsi_dcs_write_seq(dsi, 0x1a, 0x78);
+ mipi_dsi_dcs_write_seq(dsi, 0x1b, 0x23);
+ mipi_dsi_dcs_write_seq(dsi, 0x1d, 0x36);
+ mipi_dsi_dcs_write_seq(dsi, 0x1e, 0x3e);
+ mipi_dsi_dcs_write_seq(dsi, 0x1f, 0x3e);
+ mipi_dsi_dcs_write_seq(dsi, 0x20, 0x3e);
+ mipi_dsi_dcs_write_seq(dsi, 0x28, 0xfd);
+ mipi_dsi_dcs_write_seq(dsi, 0x29, 0x12);
+ mipi_dsi_dcs_write_seq(dsi, 0x2a, 0xe1);
+ mipi_dsi_dcs_write_seq(dsi, 0x2d, 0x0a);
+ mipi_dsi_dcs_write_seq(dsi, 0x30, 0x49);
+ mipi_dsi_dcs_write_seq(dsi, 0x33, 0x96);
+ mipi_dsi_dcs_write_seq(dsi, 0x34, 0xff);
+ mipi_dsi_dcs_write_seq(dsi, 0x35, 0x40);
+ mipi_dsi_dcs_write_seq(dsi, 0x36, 0xde);
+ mipi_dsi_dcs_write_seq(dsi, 0x37, 0xf9);
+ mipi_dsi_dcs_write_seq(dsi, 0x38, 0x45);
+ mipi_dsi_dcs_write_seq(dsi, 0x39, 0xd9);
+ mipi_dsi_dcs_write_seq(dsi, 0x3a, 0x49);
+ mipi_dsi_dcs_write_seq(dsi, 0x4a, 0xf0);
+ mipi_dsi_dcs_write_seq(dsi, 0x7a, 0x09);
+ mipi_dsi_dcs_write_seq(dsi, 0x7b, 0x40);
+ mipi_dsi_dcs_write_seq(dsi, 0x7f, 0xf0);
+ mipi_dsi_dcs_write_seq(dsi, 0x83, 0x0f);
+ mipi_dsi_dcs_write_seq(dsi, 0x84, 0xa4);
+ mipi_dsi_dcs_write_seq(dsi, 0x87, 0x0f);
+ mipi_dsi_dcs_write_seq(dsi, 0x88, 0x78);
+ mipi_dsi_dcs_write_seq(dsi, 0x89, 0x23);
+ mipi_dsi_dcs_write_seq(dsi, 0x8b, 0x36);
+ mipi_dsi_dcs_write_seq(dsi, 0x8c, 0x7d);
+ mipi_dsi_dcs_write_seq(dsi, 0x8d, 0x7d);
+ mipi_dsi_dcs_write_seq(dsi, 0x8e, 0x7d);
+ mipi_dsi_dcs_write_seq(dsi, 0xff, 0x20);
+ mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0xb0, 0x00, 0x00, 0x00, 0x17, 0x00, 0x49, 0x00,
+ 0x6a, 0x00, 0x89, 0x00, 0x9f, 0x00, 0xb6, 0x00, 0xc8);
+ mipi_dsi_dcs_write_seq(dsi, 0xb1, 0x00, 0xd9, 0x01, 0x10, 0x01, 0x3a, 0x01,
+ 0x7a, 0x01, 0xa9, 0x01, 0xf2, 0x02, 0x2d, 0x02, 0x2e);
+ mipi_dsi_dcs_write_seq(dsi, 0xb2, 0x02, 0x64, 0x02, 0xa3, 0x02, 0xca, 0x03,
+ 0x00, 0x03, 0x1e, 0x03, 0x4a, 0x03, 0x59, 0x03, 0x6a);
+ mipi_dsi_dcs_write_seq(dsi, 0xb3, 0x03, 0x7d, 0x03, 0x93, 0x03, 0xab, 0x03,
+ 0xc8, 0x03, 0xec, 0x03, 0xfe, 0x00, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0xb4, 0x00, 0x00, 0x00, 0x1b, 0x00, 0x51, 0x00,
+ 0x71, 0x00, 0x90, 0x00, 0xa7, 0x00, 0xbf, 0x00, 0xd1);
+ mipi_dsi_dcs_write_seq(dsi, 0xb5, 0x00, 0xe2, 0x01, 0x1a, 0x01, 0x43, 0x01,
+ 0x83, 0x01, 0xb2, 0x01, 0xfa, 0x02, 0x34, 0x02, 0x36);
+ mipi_dsi_dcs_write_seq(dsi, 0xb6, 0x02, 0x6b, 0x02, 0xa8, 0x02, 0xd0, 0x03,
+ 0x03, 0x03, 0x21, 0x03, 0x4d, 0x03, 0x5b, 0x03, 0x6b);
+ mipi_dsi_dcs_write_seq(dsi, 0xb7, 0x03, 0x7e, 0x03, 0x94, 0x03, 0xac, 0x03,
+ 0xc8, 0x03, 0xec, 0x03, 0xfe, 0x00, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0xb8, 0x00, 0x00, 0x00, 0x1b, 0x00, 0x51, 0x00,
+ 0x72, 0x00, 0x92, 0x00, 0xa8, 0x00, 0xbf, 0x00, 0xd1);
+ mipi_dsi_dcs_write_seq(dsi, 0xb9, 0x00, 0xe2, 0x01, 0x18, 0x01, 0x42, 0x01,
+ 0x81, 0x01, 0xaf, 0x01, 0xf5, 0x02, 0x2f, 0x02, 0x31);
+ mipi_dsi_dcs_write_seq(dsi, 0xba, 0x02, 0x68, 0x02, 0xa6, 0x02, 0xcd, 0x03,
+ 0x01, 0x03, 0x1f, 0x03, 0x4a, 0x03, 0x59, 0x03, 0x6a);
+ mipi_dsi_dcs_write_seq(dsi, 0xbb, 0x03, 0x7d, 0x03, 0x93, 0x03, 0xab, 0x03,
+ 0xc8, 0x03, 0xec, 0x03, 0xfe, 0x00, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0xff, 0x21);
+ mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0xb0, 0x00, 0x00, 0x00, 0x17, 0x00, 0x49, 0x00,
+ 0x6a, 0x00, 0x89, 0x00, 0x9f, 0x00, 0xb6, 0x00, 0xc8);
+ mipi_dsi_dcs_write_seq(dsi, 0xb1, 0x00, 0xd9, 0x01, 0x10, 0x01, 0x3a, 0x01,
+ 0x7a, 0x01, 0xa9, 0x01, 0xf2, 0x02, 0x2d, 0x02, 0x2e);
+ mipi_dsi_dcs_write_seq(dsi, 0xb2, 0x02, 0x64, 0x02, 0xa3, 0x02, 0xca, 0x03,
+ 0x00, 0x03, 0x1e, 0x03, 0x4a, 0x03, 0x59, 0x03, 0x6a);
+ mipi_dsi_dcs_write_seq(dsi, 0xb3, 0x03, 0x7d, 0x03, 0x93, 0x03, 0xab, 0x03,
+ 0xc8, 0x03, 0xec, 0x03, 0xfe, 0x00, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0xb4, 0x00, 0x00, 0x00, 0x1b, 0x00, 0x51, 0x00,
+ 0x71, 0x00, 0x90, 0x00, 0xa7, 0x00, 0xbf, 0x00, 0xd1);
+ mipi_dsi_dcs_write_seq(dsi, 0xb5, 0x00, 0xe2, 0x01, 0x1a, 0x01, 0x43, 0x01,
+ 0x83, 0x01, 0xb2, 0x01, 0xfa, 0x02, 0x34, 0x02, 0x36);
+ mipi_dsi_dcs_write_seq(dsi, 0xb6, 0x02, 0x6b, 0x02, 0xa8, 0x02, 0xd0, 0x03,
+ 0x03, 0x03, 0x21, 0x03, 0x4d, 0x03, 0x5b, 0x03, 0x6b);
+ mipi_dsi_dcs_write_seq(dsi, 0xb7, 0x03, 0x7e, 0x03, 0x94, 0x03, 0xac, 0x03,
+ 0xc8, 0x03, 0xec, 0x03, 0xfe, 0x00, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0xb8, 0x00, 0x00, 0x00, 0x1b, 0x00, 0x51, 0x00,
+ 0x72, 0x00, 0x92, 0x00, 0xa8, 0x00, 0xbf, 0x00, 0xd1);
+ mipi_dsi_dcs_write_seq(dsi, 0xb9, 0x00, 0xe2, 0x01, 0x18, 0x01, 0x42, 0x01,
+ 0x81, 0x01, 0xaf, 0x01, 0xf5, 0x02, 0x2f, 0x02, 0x31);
+ mipi_dsi_dcs_write_seq(dsi, 0xba, 0x02, 0x68, 0x02, 0xa6, 0x02, 0xcd, 0x03,
+ 0x01, 0x03, 0x1f, 0x03, 0x4a, 0x03, 0x59, 0x03, 0x6a);
+ mipi_dsi_dcs_write_seq(dsi, 0xbb, 0x03, 0x7d, 0x03, 0x93, 0x03, 0xab, 0x03,
+ 0xc8, 0x03, 0xec, 0x03, 0xfe, 0x00, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0xff, 0x2c);
+ mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x61, 0x1f);
+ mipi_dsi_dcs_write_seq(dsi, 0x62, 0x1f);
+ mipi_dsi_dcs_write_seq(dsi, 0x7e, 0x03);
+ mipi_dsi_dcs_write_seq(dsi, 0x6a, 0x14);
+ mipi_dsi_dcs_write_seq(dsi, 0x6b, 0x36);
+ mipi_dsi_dcs_write_seq(dsi, 0x6c, 0x36);
+ mipi_dsi_dcs_write_seq(dsi, 0x6d, 0x36);
+ mipi_dsi_dcs_write_seq(dsi, 0x53, 0x04);
+ mipi_dsi_dcs_write_seq(dsi, 0x54, 0x04);
+ mipi_dsi_dcs_write_seq(dsi, 0x55, 0x04);
+ mipi_dsi_dcs_write_seq(dsi, 0x56, 0x0f);
+ mipi_dsi_dcs_write_seq(dsi, 0x58, 0x0f);
+ mipi_dsi_dcs_write_seq(dsi, 0x59, 0x0f);
+ mipi_dsi_dcs_write_seq(dsi, 0xff, 0xf0);
+ mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x5a, 0x00);
+
+ mipi_dsi_dcs_write_seq(dsi, 0xff, 0x10);
+ mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
+ mipi_dsi_dcs_write_seq(dsi, 0x51, 0xff);
+ mipi_dsi_dcs_write_seq(dsi, 0x53, 0x24);
+ mipi_dsi_dcs_write_seq(dsi, 0x55, 0x01);
+
+ return 0;
+}
+
+static int nt36672e_power_on(struct nt36672e_panel *ctx)
+{
+ struct mipi_dsi_device *dsi = ctx->dsi;
+ int ret, i;
+
+ for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) {
+ ret = regulator_set_load(ctx->supplies[i].consumer,
+ regulator_enable_loads[i]);
+ if (ret) {
+ dev_err(&dsi->dev, "regulator set load failed for supply %s: %d\n",
+ ctx->supplies[i].supply, ret);
+ return ret;
+ }
+ }
+
+ ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
+ if (ret < 0) {
+ dev_err(&dsi->dev, "regulator bulk enable failed: %d\n", ret);
+ return ret;
+ }
+
+ /*
+ * Reset sequence of nt36672e panel requires the panel to be out of reset
+ * for 10ms, followed by being held in reset for 10ms and then out again.
+ */
+ gpiod_set_value(ctx->reset_gpio, 1);
+ usleep_range(10000, 20000);
+ gpiod_set_value(ctx->reset_gpio, 0);
+ usleep_range(10000, 20000);
+ gpiod_set_value(ctx->reset_gpio, 1);
+ usleep_range(10000, 20000);
+
+ return 0;
+}
+
+static int nt36672e_power_off(struct nt36672e_panel *ctx)
+{
+ struct mipi_dsi_device *dsi = ctx->dsi;
+ int ret = 0;
+ int i;
+
+ gpiod_set_value(ctx->reset_gpio, 0);
+
+ for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) {
+ ret = regulator_set_load(ctx->supplies[i].consumer,
+ regulator_disable_loads[i]);
+ if (ret) {
+ dev_err(&dsi->dev, "regulator set load failed for supply %s: %d\n",
+ ctx->supplies[i].supply, ret);
+ return ret;
+ }
+ }
+
+ ret = regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
+ if (ret)
+ dev_err(&dsi->dev, "regulator bulk disable failed: %d\n", ret);
+
+ return ret;
+}
+
+static int nt36672e_on(struct nt36672e_panel *ctx)
+{
+ struct mipi_dsi_device *dsi = ctx->dsi;
+ const struct panel_desc *desc = ctx->desc;
+ int ret = 0;
+
+ dsi->mode_flags |= MIPI_DSI_MODE_LPM;
+
+ if (desc->init_sequence) {
+ ret = desc->init_sequence(dsi);
+ if (ret < 0) {
+ dev_err(&dsi->dev, "panel init sequence failed: %d\n", ret);
+ return ret;
+ }
+ }
+
+ ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
+ if (ret < 0) {
+ dev_err(&dsi->dev, "Failed to exit sleep mode: %d\n", ret);
+ return ret;
+ }
+ msleep(120);
+
+ ret = mipi_dsi_dcs_set_display_on(dsi);
+ if (ret < 0) {
+ dev_err(&dsi->dev, "Failed to set display on: %d\n", ret);
+ return ret;
+ }
+ msleep(100);
+
+ return 0;
+}
+
+static int nt36672e_off(struct nt36672e_panel *ctx)
+{
+ struct mipi_dsi_device *dsi = ctx->dsi;
+ int ret = 0;
+
+ dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
+
+ ret = mipi_dsi_dcs_set_display_off(dsi);
+ if (ret < 0) {
+ dev_err(&dsi->dev, "Failed to set display off: %d\n", ret);
+ return ret;
+ }
+ msleep(20);
+
+ ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
+ if (ret < 0) {
+ dev_err(&dsi->dev, "Failed to enter sleep mode: %d\n", ret);
+ return ret;
+ }
+ msleep(60);
+
+ return 0;
+}
+
+static int nt36672e_panel_prepare(struct drm_panel *panel)
+{
+ struct nt36672e_panel *ctx = to_nt36672e_panel(panel);
+ struct mipi_dsi_device *dsi = ctx->dsi;
+ int ret = 0;
+
+ ret = nt36672e_power_on(ctx);
+ if (ret < 0)
+ return ret;
+
+ ret = nt36672e_on(ctx);
+ if (ret < 0) {
+ dev_err(&dsi->dev, "Failed to initialize panel: %d\n", ret);
+ if (nt36672e_power_off(ctx))
+ dev_err(&dsi->dev, "power off failed\n");
+ return ret;
+ }
+
+ return 0;
+}
+
+static int nt36672e_panel_unprepare(struct drm_panel *panel)
+{
+ struct nt36672e_panel *ctx = to_nt36672e_panel(panel);
+ struct mipi_dsi_device *dsi = ctx->dsi;
+ int ret = 0;
+
+ ret = nt36672e_off(ctx);
+ if (ret < 0)
+ dev_err(&dsi->dev, "Failed to un-initialize panel: %d\n", ret);
+
+ ret = nt36672e_power_off(ctx);
+ if (ret < 0)
+ dev_err(&dsi->dev, "power off failed: %d\n", ret);
+
+ return 0;
+}
+
+static const struct drm_display_mode nt36672e_1080x2408_60hz = {
+ .name = "1080x2408",
+ .clock = 181690,
+ .hdisplay = 1080,
+ .hsync_start = 1080 + 76,
+ .hsync_end = 1080 + 76 + 12,
+ .htotal = 1080 + 76 + 12 + 56,
+ .vdisplay = 2408,
+ .vsync_start = 2408 + 46,
+ .vsync_end = 2408 + 46 + 10,
+ .vtotal = 2408 + 46 + 10 + 10,
+ .flags = 0,
+};
+
+static const struct panel_desc nt36672e_panel_desc = {
+ .display_mode = &nt36672e_1080x2408_60hz,
+ .width_mm = 74,
+ .height_mm = 131,
+ .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS,
+ .format = MIPI_DSI_FMT_RGB888,
+ .lanes = 4,
+ .panel_name = "nt36672e fhd plus panel",
+ .init_sequence = nt36672e_1080x2408_60hz_init,
+};
+
+static int nt36672e_panel_get_modes(struct drm_panel *panel, struct drm_connector *connector)
+{
+ struct nt36672e_panel *ctx = to_nt36672e_panel(panel);
+ struct drm_display_mode *mode;
+
+ mode = drm_mode_duplicate(connector->dev, ctx->desc->display_mode);
+ if (!mode)
+ return -ENOMEM;
+
+ drm_mode_set_name(mode);
+
+ mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
+ connector->display_info.width_mm = ctx->desc->width_mm;
+ connector->display_info.height_mm = ctx->desc->height_mm;
+ drm_mode_probed_add(connector, mode);
+
+ return 1;
+}
+
+static const struct drm_panel_funcs nt36672e_drm_funcs = {
+ .prepare = nt36672e_panel_prepare,
+ .unprepare = nt36672e_panel_unprepare,
+ .get_modes = nt36672e_panel_get_modes,
+};
+
+static int nt36672e_panel_probe(struct mipi_dsi_device *dsi)
+{
+ struct device *dev = &dsi->dev;
+ struct nt36672e_panel *ctx;
+ int i, ret = 0;
+
+ ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
+ if (!ctx)
+ return -ENOMEM;
+
+ ctx->desc = of_device_get_match_data(dev);
+ if (!ctx->desc) {
+ dev_err(dev, "missing device configuration\n");
+ return -ENODEV;
+ }
+
+ for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++)
+ ctx->supplies[i].supply = regulator_names[i];
+
+ ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies),
+ ctx->supplies);
+ if (ret < 0)
+ return ret;
+
+ ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
+ if (IS_ERR(ctx->reset_gpio))
+ return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), "Failed to get reset-gpios\n");
+
+ ctx->dsi = dsi;
+ mipi_dsi_set_drvdata(dsi, ctx);
+
+ dsi->lanes = ctx->desc->lanes;
+ dsi->format = ctx->desc->format;
+ dsi->mode_flags = ctx->desc->mode_flags;
+
+ drm_panel_init(&ctx->panel, dev, &nt36672e_drm_funcs, DRM_MODE_CONNECTOR_DSI);
+
+ ret = drm_panel_of_backlight(&ctx->panel);
+ if (ret)
+ return dev_err_probe(dev, ret, "Failed to get backlight\n");
+
+ ctx->panel.prepare_prev_first = true;
+
+ drm_panel_add(&ctx->panel);
+
+ ret = mipi_dsi_attach(dsi);
+ if (ret < 0) {
+ dev_err(dev, "Failed to attach to DSI host: %d\n", ret);
+ goto err_dsi_attach;
+ }
+
+ return 0;
+
+err_dsi_attach:
+ drm_panel_remove(&ctx->panel);
+ return ret;
+}
+
+static void nt36672e_panel_remove(struct mipi_dsi_device *dsi)
+{
+ struct nt36672e_panel *ctx = mipi_dsi_get_drvdata(dsi);
+
+ mipi_dsi_detach(ctx->dsi);
+ mipi_dsi_device_unregister(ctx->dsi);
+
+ drm_panel_remove(&ctx->panel);
+}
+
+static const struct of_device_id nt36672e_of_match[] = {
+ {
+ .compatible = "novatek,nt36672e",
+ .data = &nt36672e_panel_desc,
+ },
+ { }
+};
+MODULE_DEVICE_TABLE(of, nt36672e_of_match);
+
+static struct mipi_dsi_driver nt36672e_panel_driver = {
+ .driver = {
+ .name = "panel-novatek-nt36672e",
+ .of_match_table = nt36672e_of_match,
+ },
+ .probe = nt36672e_panel_probe,
+ .remove = nt36672e_panel_remove,
+};
+module_mipi_dsi_driver(nt36672e_panel_driver);
+
+MODULE_AUTHOR("Ritesh Kumar <[email protected]>");
+MODULE_DESCRIPTION("Novatek NT36672E DSI Panel Driver");
+MODULE_LICENSE("GPL");
--
2.17.1
Document Novatek NT36672E FHD+ LCD DSI panel.
Signed-off-by: Ritesh Kumar <[email protected]>
---
v2: Fixed review comments from Krzysztof
- renamed to novatek,nt36672e, since the binding is for the IC and
not the panel.
- moved additionalProperties after required.
---
.../display/panel/novatek,nt36672e.yaml | 66 +++++++++++++++++++
1 file changed, 66 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
new file mode 100644
index 000000000000..dc4672f3d01d
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/novatek,nt36672e.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Novatek NT36672E LCD DSI Panel
+
+maintainers:
+ - Ritesh Kumar <[email protected]>
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ const: novatek,nt36672e
+
+ reg:
+ maxItems: 1
+ description: DSI virtual channel
+
+ vddi-supply: true
+ avdd-supply: true
+ avee-supply: true
+ port: true
+ reset-gpios: true
+ backlight: true
+
+required:
+ - compatible
+ - reg
+ - vddi-supply
+ - avdd-supply
+ - avee-supply
+ - reset-gpios
+ - port
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ panel@0 {
+ compatible = "novatek,nt36672e";
+ reg = <0>;
+
+ reset-gpios = <&tlmm 44 GPIO_ACTIVE_HIGH>;
+
+ vddi-supply = <&vreg_l8c_1p8>;
+ avdd-supply = <&disp_avdd>;
+ avee-supply = <&disp_avee>;
+
+ backlight = <&pwm_backlight>;
+
+ port {
+ panel0_in: endpoint {
+ remote-endpoint = <&dsi0_out>;
+ };
+ };
+ };
+ };
+...
--
2.17.1
On 08/01/2024 10:59, Ritesh Kumar wrote:
> Document Novatek NT36672E FHD+ LCD DSI panel.
>
> Signed-off-by: Ritesh Kumar <[email protected]>
>
> ---
> v2: Fixed review comments from Krzysztof
Please use standard email subjects, so with the PATCH keyword in the
title. `git format-patch` helps here to create proper versioned patches.
Another useful tool is b4. Skipping the PATCH keyword makes filtering of
emails more difficult thus making the review process less convenient.
> - renamed to novatek,nt36672e, since the binding is for the IC and
> not the panel.
> - moved additionalProperties after required.
> ---
> .../display/panel/novatek,nt36672e.yaml | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
> new file mode 100644
> index 000000000000..dc4672f3d01d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/novatek,nt36672e.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Novatek NT36672E LCD DSI Panel
> +
> +maintainers:
> + - Ritesh Kumar <[email protected]>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: novatek,nt36672e
> +
> + reg:
> + maxItems: 1
> + description: DSI virtual channel
> +
> + vddi-supply: true
> + avdd-supply: true
> + avee-supply: true
Are these names of pins? Somehow I have troubles believing that NT36672A
and NT36672E have entirely different names for these...
Best regards,
Krzysztof
>-----Original Message-----
>From: Krzysztof Kozlowski <[email protected]>
>Sent: Monday, January 8, 2024 3:38 PM
>To: Ritesh Kumar (QUIC) <[email protected]>; dri-
>[email protected]; [email protected]; linux-
>[email protected]
>Cc: [email protected]; Jessica Zhang (QUIC)
><[email protected]>; [email protected];
>[email protected]; [email protected];
>[email protected]; [email protected]; [email protected];
>[email protected]; [email protected]; [email protected];
>Abhinav Kumar (QUIC) <[email protected]>; Rajeev Nandan (QUIC)
><[email protected]>; Vishnuvardhan Prodduturi (QUIC)
><[email protected]>; [email protected]
>Subject: Re: [v2 1/2] dt-bindings: display: panel: Add Novatek NT36672E LCD
>DSI
>
>On 08/01/2024 10:59, Ritesh Kumar wrote:
>> Document Novatek NT36672E FHD+ LCD DSI panel.
>>
>> Signed-off-by: Ritesh Kumar <[email protected]>
>>
>> ---
>> v2: Fixed review comments from Krzysztof
>
>Please use standard email subjects, so with the PATCH keyword in the title. `git
>format-patch` helps here to create proper versioned patches.
>Another useful tool is b4. Skipping the PATCH keyword makes filtering of emails
>more difficult thus making the review process less convenient.
I am using git format-patch only. I think the name of series is changed causing the trouble.
>
>> - renamed to novatek,nt36672e, since the binding is for the IC and
>> not the panel.
>> - moved additionalProperties after required.
>> ---
>> .../display/panel/novatek,nt36672e.yaml | 66 +++++++++++++++++++
>> 1 file changed, 66 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
>>
>> diff --git
>>
>a/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yam
>> l
>>
>b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yam
>> l
>> new file mode 100644
>> index 000000000000..dc4672f3d01d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e
>> +++ .yaml
>> @@ -0,0 +1,66 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
>> +---
>> +$id:
>> +http://devicetree.org/schemas/display/panel/novatek,nt36672e.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Novatek NT36672E LCD DSI Panel
>> +
>> +maintainers:
>> + - Ritesh Kumar <[email protected]>
>> +
>> +allOf:
>> + - $ref: panel-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + const: novatek,nt36672e
>> +
>> + reg:
>> + maxItems: 1
>> + description: DSI virtual channel
>> +
>> + vddi-supply: true
>> + avdd-supply: true
>> + avee-supply: true
>
>Are these names of pins? Somehow I have troubles believing that NT36672A
>and NT36672E have entirely different names for these...
Yes, these are name of pins.
Below is the Pin Description from NT36672E Datasheet:
vddi - Power supply to the I/O.
avdd - Positive input analog power for driver IC use.
avee - Negative input analog power for driver IC use.
I could not find datasheet of NT36672A online to compare the names.
Thanks,
Ritesh
On 08/01/2024 11:07, Krzysztof Kozlowski wrote:
> On 08/01/2024 10:59, Ritesh Kumar wrote:
>> Document Novatek NT36672E FHD+ LCD DSI panel.
>>
>> Signed-off-by: Ritesh Kumar <[email protected]>
>>
>> ---
>> v2: Fixed review comments from Krzysztof
>
> Please use standard email subjects, so with the PATCH keyword in the
> title. `git format-patch` helps here to create proper versioned patches.
> Another useful tool is b4. Skipping the PATCH keyword makes filtering of
> emails more difficult thus making the review process less convenient.
That was for the future (I understand making that mistake once with your
v1, but that's v2), no need to resend only for this.
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
Best regards,
Krzysztof
On 1/8/2024 1:59 AM, Ritesh Kumar wrote:
> Add support for the 1080x2408 Novatek NT36672E video mode
> DSI panel driver.
>
> Signed-off-by: Ritesh Kumar <[email protected]>
Reviewed-by: Jessica Zhang <[email protected]>
>
> ---
> v2: Fixed review comments from Krzysztof
> - renamed the panel driver file to reflect that this is a novatek IC.
> - adjusted internal function names to reflect the same.
> - corrected compatible string accordingly.
> - updated CONFIG for the same.
> ---
> drivers/gpu/drm/panel/Kconfig | 10 +
> drivers/gpu/drm/panel/Makefile | 1 +
> .../gpu/drm/panel/panel-novatek-nt36672e.c | 643 ++++++++++++++++++
> 3 files changed, 654 insertions(+)
> create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt36672e.c
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 99e14dc212ec..052aaef7d6a2 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -429,6 +429,16 @@ config DRM_PANEL_NOVATEK_NT36672A
> around the Novatek NT36672A display controller, such as some
> Tianma panels used in a few Xiaomi Poco F1 mobile phones.
>
> +config DRM_PANEL_NOVATEK_NT36672E
> + tristate "Novatek NT36672E DSI panel"
> + depends on OF
> + depends on DRM_MIPI_DSI
> + depends on BACKLIGHT_CLASS_DEVICE
> + help
> + Say Y here if you want to enable support for Novatek NT36672E DSI Video Mode
> + LCD panel module. The panel has a resolution of 1080x2408 and uses 24 bit
> + RGB per pixel.
> +
> config DRM_PANEL_NOVATEK_NT39016
> tristate "Novatek NT39016 RGB/SPI panel"
> depends on OF && SPI
> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
> index d10c3de51c6d..93a544a8937c 100644
> --- a/drivers/gpu/drm/panel/Makefile
> +++ b/drivers/gpu/drm/panel/Makefile
> @@ -40,6 +40,7 @@ obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35560) += panel-novatek-nt35560.o
> obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35950) += panel-novatek-nt35950.o
> obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36523) += panel-novatek-nt36523.o
> obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36672A) += panel-novatek-nt36672a.o
> +obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36672E) += panel-novatek-nt36672e.o
> obj-$(CONFIG_DRM_PANEL_NOVATEK_NT39016) += panel-novatek-nt39016.o
> obj-$(CONFIG_DRM_PANEL_MANTIX_MLAF057WE51) += panel-mantix-mlaf057we51.o
> obj-$(CONFIG_DRM_PANEL_OLIMEX_LCD_OLINUXINO) += panel-olimex-lcd-olinuxino.o
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c
> new file mode 100644
> index 000000000000..d4e85c2fc899
> --- /dev/null
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c
> @@ -0,0 +1,643 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +// Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
> +
> +#include <linux/delay.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/regulator/consumer.h>
> +
> +#include <drm/drm_mipi_dsi.h>
> +#include <drm/drm_modes.h>
> +#include <drm/drm_panel.h>
> +
> +#include <video/mipi_display.h>
> +
> +static const char * const regulator_names[] = {
> + "vddi",
> + "avdd",
> + "avee",
> +};
> +
> +static const unsigned long regulator_enable_loads[] = {
> + 62000,
> + 100000,
> + 100000,
> +};
> +
> +static const unsigned long regulator_disable_loads[] = {
> + 80,
> + 100,
> + 100,
> +};
> +
> +struct panel_desc {
> + const struct drm_display_mode *display_mode;
> + u32 width_mm;
> + u32 height_mm;
> + unsigned long mode_flags;
> + enum mipi_dsi_pixel_format format;
> + unsigned int lanes;
> + const char *panel_name;
> + int (*init_sequence)(struct mipi_dsi_device *dsi);
> +};
> +
> +struct nt36672e_panel {
> + struct drm_panel panel;
> + struct mipi_dsi_device *dsi;
> + struct gpio_desc *reset_gpio;
> + struct regulator_bulk_data supplies[3];
> + const struct panel_desc *desc;
> +};
> +
> +static inline struct nt36672e_panel *to_nt36672e_panel(struct drm_panel *panel)
> +{
> + return container_of(panel, struct nt36672e_panel, panel);
> +}
> +
> +static int nt36672e_1080x2408_60hz_init(struct mipi_dsi_device *dsi)
> +{
> + mipi_dsi_dcs_write_seq(dsi, 0xff, 0x10);
> + mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0xb0, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0xc0, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0xc1, 0x89, 0x28, 0x00, 0x08, 0x00, 0xaa, 0x02,
> + 0x0e, 0x00, 0x2b, 0x00, 0x07, 0x0d, 0xb7, 0x0c, 0xb7);
> +
> + mipi_dsi_dcs_write_seq(dsi, 0xc2, 0x1b, 0xa0);
> + mipi_dsi_dcs_write_seq(dsi, 0xff, 0x20);
> + mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x01, 0x66);
> + mipi_dsi_dcs_write_seq(dsi, 0x06, 0x40);
> + mipi_dsi_dcs_write_seq(dsi, 0x07, 0x38);
> + mipi_dsi_dcs_write_seq(dsi, 0x2f, 0x83);
> + mipi_dsi_dcs_write_seq(dsi, 0x69, 0x91);
> + mipi_dsi_dcs_write_seq(dsi, 0x95, 0xd1);
> + mipi_dsi_dcs_write_seq(dsi, 0x96, 0xd1);
> + mipi_dsi_dcs_write_seq(dsi, 0xf2, 0x64);
> + mipi_dsi_dcs_write_seq(dsi, 0xf3, 0x54);
> + mipi_dsi_dcs_write_seq(dsi, 0xf4, 0x64);
> + mipi_dsi_dcs_write_seq(dsi, 0xf5, 0x54);
> + mipi_dsi_dcs_write_seq(dsi, 0xf6, 0x64);
> + mipi_dsi_dcs_write_seq(dsi, 0xf7, 0x54);
> + mipi_dsi_dcs_write_seq(dsi, 0xf8, 0x64);
> + mipi_dsi_dcs_write_seq(dsi, 0xf9, 0x54);
> + mipi_dsi_dcs_write_seq(dsi, 0xff, 0x24);
> + mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x01, 0x0f);
> + mipi_dsi_dcs_write_seq(dsi, 0x03, 0x0c);
> + mipi_dsi_dcs_write_seq(dsi, 0x05, 0x1d);
> + mipi_dsi_dcs_write_seq(dsi, 0x08, 0x2f);
> + mipi_dsi_dcs_write_seq(dsi, 0x09, 0x2e);
> + mipi_dsi_dcs_write_seq(dsi, 0x0a, 0x2d);
> + mipi_dsi_dcs_write_seq(dsi, 0x0b, 0x2c);
> + mipi_dsi_dcs_write_seq(dsi, 0x11, 0x17);
> + mipi_dsi_dcs_write_seq(dsi, 0x12, 0x13);
> + mipi_dsi_dcs_write_seq(dsi, 0x13, 0x15);
> + mipi_dsi_dcs_write_seq(dsi, 0x15, 0x14);
> + mipi_dsi_dcs_write_seq(dsi, 0x16, 0x16);
> + mipi_dsi_dcs_write_seq(dsi, 0x17, 0x18);
> + mipi_dsi_dcs_write_seq(dsi, 0x1b, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x1d, 0x1d);
> + mipi_dsi_dcs_write_seq(dsi, 0x20, 0x2f);
> + mipi_dsi_dcs_write_seq(dsi, 0x21, 0x2e);
> + mipi_dsi_dcs_write_seq(dsi, 0x22, 0x2d);
> + mipi_dsi_dcs_write_seq(dsi, 0x23, 0x2c);
> + mipi_dsi_dcs_write_seq(dsi, 0x29, 0x17);
> + mipi_dsi_dcs_write_seq(dsi, 0x2a, 0x13);
> + mipi_dsi_dcs_write_seq(dsi, 0x2b, 0x15);
> + mipi_dsi_dcs_write_seq(dsi, 0x2f, 0x14);
> + mipi_dsi_dcs_write_seq(dsi, 0x30, 0x16);
> + mipi_dsi_dcs_write_seq(dsi, 0x31, 0x18);
> + mipi_dsi_dcs_write_seq(dsi, 0x32, 0x04);
> + mipi_dsi_dcs_write_seq(dsi, 0x34, 0x10);
> + mipi_dsi_dcs_write_seq(dsi, 0x35, 0x1f);
> + mipi_dsi_dcs_write_seq(dsi, 0x36, 0x1f);
> + mipi_dsi_dcs_write_seq(dsi, 0x4d, 0x14);
> + mipi_dsi_dcs_write_seq(dsi, 0x4e, 0x36);
> + mipi_dsi_dcs_write_seq(dsi, 0x4f, 0x36);
> + mipi_dsi_dcs_write_seq(dsi, 0x53, 0x36);
> + mipi_dsi_dcs_write_seq(dsi, 0x71, 0x30);
> + mipi_dsi_dcs_write_seq(dsi, 0x79, 0x11);
> + mipi_dsi_dcs_write_seq(dsi, 0x7a, 0x82);
> + mipi_dsi_dcs_write_seq(dsi, 0x7b, 0x8f);
> + mipi_dsi_dcs_write_seq(dsi, 0x7d, 0x04);
> + mipi_dsi_dcs_write_seq(dsi, 0x80, 0x04);
> + mipi_dsi_dcs_write_seq(dsi, 0x81, 0x04);
> + mipi_dsi_dcs_write_seq(dsi, 0x82, 0x13);
> + mipi_dsi_dcs_write_seq(dsi, 0x84, 0x31);
> + mipi_dsi_dcs_write_seq(dsi, 0x85, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x86, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x87, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x90, 0x13);
> + mipi_dsi_dcs_write_seq(dsi, 0x92, 0x31);
> + mipi_dsi_dcs_write_seq(dsi, 0x93, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x94, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x95, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x9c, 0xf4);
> + mipi_dsi_dcs_write_seq(dsi, 0x9d, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0xa0, 0x0f);
> + mipi_dsi_dcs_write_seq(dsi, 0xa2, 0x0f);
> + mipi_dsi_dcs_write_seq(dsi, 0xa3, 0x02);
> + mipi_dsi_dcs_write_seq(dsi, 0xa4, 0x04);
> + mipi_dsi_dcs_write_seq(dsi, 0xa5, 0x04);
> + mipi_dsi_dcs_write_seq(dsi, 0xc6, 0xc0);
> + mipi_dsi_dcs_write_seq(dsi, 0xc9, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0xd9, 0x80);
> + mipi_dsi_dcs_write_seq(dsi, 0xe9, 0x02);
> + mipi_dsi_dcs_write_seq(dsi, 0xff, 0x25);
> + mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x18, 0x22);
> + mipi_dsi_dcs_write_seq(dsi, 0x19, 0xe4);
> + mipi_dsi_dcs_write_seq(dsi, 0x21, 0x40);
> + mipi_dsi_dcs_write_seq(dsi, 0x66, 0xd8);
> + mipi_dsi_dcs_write_seq(dsi, 0x68, 0x50);
> + mipi_dsi_dcs_write_seq(dsi, 0x69, 0x10);
> + mipi_dsi_dcs_write_seq(dsi, 0x6b, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x6d, 0x0d);
> + mipi_dsi_dcs_write_seq(dsi, 0x6e, 0x48);
> + mipi_dsi_dcs_write_seq(dsi, 0x72, 0x41);
> + mipi_dsi_dcs_write_seq(dsi, 0x73, 0x4a);
> + mipi_dsi_dcs_write_seq(dsi, 0x74, 0xd0);
> + mipi_dsi_dcs_write_seq(dsi, 0x77, 0x62);
> + mipi_dsi_dcs_write_seq(dsi, 0x79, 0x7e);
> + mipi_dsi_dcs_write_seq(dsi, 0x7d, 0x03);
> + mipi_dsi_dcs_write_seq(dsi, 0x7e, 0x15);
> + mipi_dsi_dcs_write_seq(dsi, 0x7f, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x84, 0x4d);
> + mipi_dsi_dcs_write_seq(dsi, 0xcf, 0x80);
> + mipi_dsi_dcs_write_seq(dsi, 0xd6, 0x80);
> + mipi_dsi_dcs_write_seq(dsi, 0xd7, 0x80);
> + mipi_dsi_dcs_write_seq(dsi, 0xef, 0x20);
> + mipi_dsi_dcs_write_seq(dsi, 0xf0, 0x84);
> + mipi_dsi_dcs_write_seq(dsi, 0xff, 0x26);
> + mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x81, 0x0f);
> + mipi_dsi_dcs_write_seq(dsi, 0x83, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x84, 0x03);
> + mipi_dsi_dcs_write_seq(dsi, 0x85, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x86, 0x03);
> + mipi_dsi_dcs_write_seq(dsi, 0x87, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x88, 0x05);
> + mipi_dsi_dcs_write_seq(dsi, 0x8a, 0x1a);
> + mipi_dsi_dcs_write_seq(dsi, 0x8b, 0x11);
> + mipi_dsi_dcs_write_seq(dsi, 0x8c, 0x24);
> + mipi_dsi_dcs_write_seq(dsi, 0x8e, 0x42);
> + mipi_dsi_dcs_write_seq(dsi, 0x8f, 0x11);
> + mipi_dsi_dcs_write_seq(dsi, 0x90, 0x11);
> + mipi_dsi_dcs_write_seq(dsi, 0x91, 0x11);
> + mipi_dsi_dcs_write_seq(dsi, 0x9a, 0x80);
> + mipi_dsi_dcs_write_seq(dsi, 0x9b, 0x04);
> + mipi_dsi_dcs_write_seq(dsi, 0x9c, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x9d, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x9e, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0xff, 0x27);
> + mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x01, 0x68);
> + mipi_dsi_dcs_write_seq(dsi, 0x20, 0x81);
> + mipi_dsi_dcs_write_seq(dsi, 0x21, 0x6a);
> + mipi_dsi_dcs_write_seq(dsi, 0x25, 0x81);
> + mipi_dsi_dcs_write_seq(dsi, 0x26, 0x94);
> + mipi_dsi_dcs_write_seq(dsi, 0x6e, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x6f, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x70, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x71, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x72, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x75, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x76, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x77, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0x7d, 0x09);
> + mipi_dsi_dcs_write_seq(dsi, 0x7e, 0x67);
> + mipi_dsi_dcs_write_seq(dsi, 0x80, 0x23);
> + mipi_dsi_dcs_write_seq(dsi, 0x82, 0x09);
> + mipi_dsi_dcs_write_seq(dsi, 0x83, 0x67);
> + mipi_dsi_dcs_write_seq(dsi, 0x88, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x89, 0x10);
> + mipi_dsi_dcs_write_seq(dsi, 0xa5, 0x10);
> + mipi_dsi_dcs_write_seq(dsi, 0xa6, 0x23);
> + mipi_dsi_dcs_write_seq(dsi, 0xa7, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0xb6, 0x40);
> + mipi_dsi_dcs_write_seq(dsi, 0xe5, 0x02);
> + mipi_dsi_dcs_write_seq(dsi, 0xe6, 0xd3);
> + mipi_dsi_dcs_write_seq(dsi, 0xeb, 0x03);
> + mipi_dsi_dcs_write_seq(dsi, 0xec, 0x28);
> + mipi_dsi_dcs_write_seq(dsi, 0xff, 0x2a);
> + mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x00, 0x91);
> + mipi_dsi_dcs_write_seq(dsi, 0x03, 0x20);
> + mipi_dsi_dcs_write_seq(dsi, 0x07, 0x50);
> + mipi_dsi_dcs_write_seq(dsi, 0x0a, 0x70);
> + mipi_dsi_dcs_write_seq(dsi, 0x0c, 0x04);
> + mipi_dsi_dcs_write_seq(dsi, 0x0d, 0x40);
> + mipi_dsi_dcs_write_seq(dsi, 0x0f, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x11, 0xe0);
> + mipi_dsi_dcs_write_seq(dsi, 0x15, 0x0f);
> + mipi_dsi_dcs_write_seq(dsi, 0x16, 0xa4);
> + mipi_dsi_dcs_write_seq(dsi, 0x19, 0x0f);
> + mipi_dsi_dcs_write_seq(dsi, 0x1a, 0x78);
> + mipi_dsi_dcs_write_seq(dsi, 0x1b, 0x23);
> + mipi_dsi_dcs_write_seq(dsi, 0x1d, 0x36);
> + mipi_dsi_dcs_write_seq(dsi, 0x1e, 0x3e);
> + mipi_dsi_dcs_write_seq(dsi, 0x1f, 0x3e);
> + mipi_dsi_dcs_write_seq(dsi, 0x20, 0x3e);
> + mipi_dsi_dcs_write_seq(dsi, 0x28, 0xfd);
> + mipi_dsi_dcs_write_seq(dsi, 0x29, 0x12);
> + mipi_dsi_dcs_write_seq(dsi, 0x2a, 0xe1);
> + mipi_dsi_dcs_write_seq(dsi, 0x2d, 0x0a);
> + mipi_dsi_dcs_write_seq(dsi, 0x30, 0x49);
> + mipi_dsi_dcs_write_seq(dsi, 0x33, 0x96);
> + mipi_dsi_dcs_write_seq(dsi, 0x34, 0xff);
> + mipi_dsi_dcs_write_seq(dsi, 0x35, 0x40);
> + mipi_dsi_dcs_write_seq(dsi, 0x36, 0xde);
> + mipi_dsi_dcs_write_seq(dsi, 0x37, 0xf9);
> + mipi_dsi_dcs_write_seq(dsi, 0x38, 0x45);
> + mipi_dsi_dcs_write_seq(dsi, 0x39, 0xd9);
> + mipi_dsi_dcs_write_seq(dsi, 0x3a, 0x49);
> + mipi_dsi_dcs_write_seq(dsi, 0x4a, 0xf0);
> + mipi_dsi_dcs_write_seq(dsi, 0x7a, 0x09);
> + mipi_dsi_dcs_write_seq(dsi, 0x7b, 0x40);
> + mipi_dsi_dcs_write_seq(dsi, 0x7f, 0xf0);
> + mipi_dsi_dcs_write_seq(dsi, 0x83, 0x0f);
> + mipi_dsi_dcs_write_seq(dsi, 0x84, 0xa4);
> + mipi_dsi_dcs_write_seq(dsi, 0x87, 0x0f);
> + mipi_dsi_dcs_write_seq(dsi, 0x88, 0x78);
> + mipi_dsi_dcs_write_seq(dsi, 0x89, 0x23);
> + mipi_dsi_dcs_write_seq(dsi, 0x8b, 0x36);
> + mipi_dsi_dcs_write_seq(dsi, 0x8c, 0x7d);
> + mipi_dsi_dcs_write_seq(dsi, 0x8d, 0x7d);
> + mipi_dsi_dcs_write_seq(dsi, 0x8e, 0x7d);
> + mipi_dsi_dcs_write_seq(dsi, 0xff, 0x20);
> + mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0xb0, 0x00, 0x00, 0x00, 0x17, 0x00, 0x49, 0x00,
> + 0x6a, 0x00, 0x89, 0x00, 0x9f, 0x00, 0xb6, 0x00, 0xc8);
> + mipi_dsi_dcs_write_seq(dsi, 0xb1, 0x00, 0xd9, 0x01, 0x10, 0x01, 0x3a, 0x01,
> + 0x7a, 0x01, 0xa9, 0x01, 0xf2, 0x02, 0x2d, 0x02, 0x2e);
> + mipi_dsi_dcs_write_seq(dsi, 0xb2, 0x02, 0x64, 0x02, 0xa3, 0x02, 0xca, 0x03,
> + 0x00, 0x03, 0x1e, 0x03, 0x4a, 0x03, 0x59, 0x03, 0x6a);
> + mipi_dsi_dcs_write_seq(dsi, 0xb3, 0x03, 0x7d, 0x03, 0x93, 0x03, 0xab, 0x03,
> + 0xc8, 0x03, 0xec, 0x03, 0xfe, 0x00, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0xb4, 0x00, 0x00, 0x00, 0x1b, 0x00, 0x51, 0x00,
> + 0x71, 0x00, 0x90, 0x00, 0xa7, 0x00, 0xbf, 0x00, 0xd1);
> + mipi_dsi_dcs_write_seq(dsi, 0xb5, 0x00, 0xe2, 0x01, 0x1a, 0x01, 0x43, 0x01,
> + 0x83, 0x01, 0xb2, 0x01, 0xfa, 0x02, 0x34, 0x02, 0x36);
> + mipi_dsi_dcs_write_seq(dsi, 0xb6, 0x02, 0x6b, 0x02, 0xa8, 0x02, 0xd0, 0x03,
> + 0x03, 0x03, 0x21, 0x03, 0x4d, 0x03, 0x5b, 0x03, 0x6b);
> + mipi_dsi_dcs_write_seq(dsi, 0xb7, 0x03, 0x7e, 0x03, 0x94, 0x03, 0xac, 0x03,
> + 0xc8, 0x03, 0xec, 0x03, 0xfe, 0x00, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0xb8, 0x00, 0x00, 0x00, 0x1b, 0x00, 0x51, 0x00,
> + 0x72, 0x00, 0x92, 0x00, 0xa8, 0x00, 0xbf, 0x00, 0xd1);
> + mipi_dsi_dcs_write_seq(dsi, 0xb9, 0x00, 0xe2, 0x01, 0x18, 0x01, 0x42, 0x01,
> + 0x81, 0x01, 0xaf, 0x01, 0xf5, 0x02, 0x2f, 0x02, 0x31);
> + mipi_dsi_dcs_write_seq(dsi, 0xba, 0x02, 0x68, 0x02, 0xa6, 0x02, 0xcd, 0x03,
> + 0x01, 0x03, 0x1f, 0x03, 0x4a, 0x03, 0x59, 0x03, 0x6a);
> + mipi_dsi_dcs_write_seq(dsi, 0xbb, 0x03, 0x7d, 0x03, 0x93, 0x03, 0xab, 0x03,
> + 0xc8, 0x03, 0xec, 0x03, 0xfe, 0x00, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0xff, 0x21);
> + mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0xb0, 0x00, 0x00, 0x00, 0x17, 0x00, 0x49, 0x00,
> + 0x6a, 0x00, 0x89, 0x00, 0x9f, 0x00, 0xb6, 0x00, 0xc8);
> + mipi_dsi_dcs_write_seq(dsi, 0xb1, 0x00, 0xd9, 0x01, 0x10, 0x01, 0x3a, 0x01,
> + 0x7a, 0x01, 0xa9, 0x01, 0xf2, 0x02, 0x2d, 0x02, 0x2e);
> + mipi_dsi_dcs_write_seq(dsi, 0xb2, 0x02, 0x64, 0x02, 0xa3, 0x02, 0xca, 0x03,
> + 0x00, 0x03, 0x1e, 0x03, 0x4a, 0x03, 0x59, 0x03, 0x6a);
> + mipi_dsi_dcs_write_seq(dsi, 0xb3, 0x03, 0x7d, 0x03, 0x93, 0x03, 0xab, 0x03,
> + 0xc8, 0x03, 0xec, 0x03, 0xfe, 0x00, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0xb4, 0x00, 0x00, 0x00, 0x1b, 0x00, 0x51, 0x00,
> + 0x71, 0x00, 0x90, 0x00, 0xa7, 0x00, 0xbf, 0x00, 0xd1);
> + mipi_dsi_dcs_write_seq(dsi, 0xb5, 0x00, 0xe2, 0x01, 0x1a, 0x01, 0x43, 0x01,
> + 0x83, 0x01, 0xb2, 0x01, 0xfa, 0x02, 0x34, 0x02, 0x36);
> + mipi_dsi_dcs_write_seq(dsi, 0xb6, 0x02, 0x6b, 0x02, 0xa8, 0x02, 0xd0, 0x03,
> + 0x03, 0x03, 0x21, 0x03, 0x4d, 0x03, 0x5b, 0x03, 0x6b);
> + mipi_dsi_dcs_write_seq(dsi, 0xb7, 0x03, 0x7e, 0x03, 0x94, 0x03, 0xac, 0x03,
> + 0xc8, 0x03, 0xec, 0x03, 0xfe, 0x00, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0xb8, 0x00, 0x00, 0x00, 0x1b, 0x00, 0x51, 0x00,
> + 0x72, 0x00, 0x92, 0x00, 0xa8, 0x00, 0xbf, 0x00, 0xd1);
> + mipi_dsi_dcs_write_seq(dsi, 0xb9, 0x00, 0xe2, 0x01, 0x18, 0x01, 0x42, 0x01,
> + 0x81, 0x01, 0xaf, 0x01, 0xf5, 0x02, 0x2f, 0x02, 0x31);
> + mipi_dsi_dcs_write_seq(dsi, 0xba, 0x02, 0x68, 0x02, 0xa6, 0x02, 0xcd, 0x03,
> + 0x01, 0x03, 0x1f, 0x03, 0x4a, 0x03, 0x59, 0x03, 0x6a);
> + mipi_dsi_dcs_write_seq(dsi, 0xbb, 0x03, 0x7d, 0x03, 0x93, 0x03, 0xab, 0x03,
> + 0xc8, 0x03, 0xec, 0x03, 0xfe, 0x00, 0x00);
> + mipi_dsi_dcs_write_seq(dsi, 0xff, 0x2c);
> + mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x61, 0x1f);
> + mipi_dsi_dcs_write_seq(dsi, 0x62, 0x1f);
> + mipi_dsi_dcs_write_seq(dsi, 0x7e, 0x03);
> + mipi_dsi_dcs_write_seq(dsi, 0x6a, 0x14);
> + mipi_dsi_dcs_write_seq(dsi, 0x6b, 0x36);
> + mipi_dsi_dcs_write_seq(dsi, 0x6c, 0x36);
> + mipi_dsi_dcs_write_seq(dsi, 0x6d, 0x36);
> + mipi_dsi_dcs_write_seq(dsi, 0x53, 0x04);
> + mipi_dsi_dcs_write_seq(dsi, 0x54, 0x04);
> + mipi_dsi_dcs_write_seq(dsi, 0x55, 0x04);
> + mipi_dsi_dcs_write_seq(dsi, 0x56, 0x0f);
> + mipi_dsi_dcs_write_seq(dsi, 0x58, 0x0f);
> + mipi_dsi_dcs_write_seq(dsi, 0x59, 0x0f);
> + mipi_dsi_dcs_write_seq(dsi, 0xff, 0xf0);
> + mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x5a, 0x00);
> +
> + mipi_dsi_dcs_write_seq(dsi, 0xff, 0x10);
> + mipi_dsi_dcs_write_seq(dsi, 0xfb, 0x01);
> + mipi_dsi_dcs_write_seq(dsi, 0x51, 0xff);
> + mipi_dsi_dcs_write_seq(dsi, 0x53, 0x24);
> + mipi_dsi_dcs_write_seq(dsi, 0x55, 0x01);
> +
> + return 0;
> +}
> +
> +static int nt36672e_power_on(struct nt36672e_panel *ctx)
> +{
> + struct mipi_dsi_device *dsi = ctx->dsi;
> + int ret, i;
> +
> + for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) {
> + ret = regulator_set_load(ctx->supplies[i].consumer,
> + regulator_enable_loads[i]);
> + if (ret) {
> + dev_err(&dsi->dev, "regulator set load failed for supply %s: %d\n",
> + ctx->supplies[i].supply, ret);
> + return ret;
> + }
> + }
> +
> + ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
> + if (ret < 0) {
> + dev_err(&dsi->dev, "regulator bulk enable failed: %d\n", ret);
> + return ret;
> + }
> +
> + /*
> + * Reset sequence of nt36672e panel requires the panel to be out of reset
> + * for 10ms, followed by being held in reset for 10ms and then out again.
> + */
> + gpiod_set_value(ctx->reset_gpio, 1);
> + usleep_range(10000, 20000);
> + gpiod_set_value(ctx->reset_gpio, 0);
> + usleep_range(10000, 20000);
> + gpiod_set_value(ctx->reset_gpio, 1);
> + usleep_range(10000, 20000);
> +
> + return 0;
> +}
> +
> +static int nt36672e_power_off(struct nt36672e_panel *ctx)
> +{
> + struct mipi_dsi_device *dsi = ctx->dsi;
> + int ret = 0;
> + int i;
> +
> + gpiod_set_value(ctx->reset_gpio, 0);
> +
> + for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) {
> + ret = regulator_set_load(ctx->supplies[i].consumer,
> + regulator_disable_loads[i]);
> + if (ret) {
> + dev_err(&dsi->dev, "regulator set load failed for supply %s: %d\n",
> + ctx->supplies[i].supply, ret);
> + return ret;
> + }
> + }
> +
> + ret = regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
> + if (ret)
> + dev_err(&dsi->dev, "regulator bulk disable failed: %d\n", ret);
> +
> + return ret;
> +}
> +
> +static int nt36672e_on(struct nt36672e_panel *ctx)
> +{
> + struct mipi_dsi_device *dsi = ctx->dsi;
> + const struct panel_desc *desc = ctx->desc;
> + int ret = 0;
> +
> + dsi->mode_flags |= MIPI_DSI_MODE_LPM;
> +
> + if (desc->init_sequence) {
> + ret = desc->init_sequence(dsi);
> + if (ret < 0) {
> + dev_err(&dsi->dev, "panel init sequence failed: %d\n", ret);
> + return ret;
> + }
> + }
> +
> + ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
> + if (ret < 0) {
> + dev_err(&dsi->dev, "Failed to exit sleep mode: %d\n", ret);
> + return ret;
> + }
> + msleep(120);
> +
> + ret = mipi_dsi_dcs_set_display_on(dsi);
> + if (ret < 0) {
> + dev_err(&dsi->dev, "Failed to set display on: %d\n", ret);
> + return ret;
> + }
> + msleep(100);
> +
> + return 0;
> +}
> +
> +static int nt36672e_off(struct nt36672e_panel *ctx)
> +{
> + struct mipi_dsi_device *dsi = ctx->dsi;
> + int ret = 0;
> +
> + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
> +
> + ret = mipi_dsi_dcs_set_display_off(dsi);
> + if (ret < 0) {
> + dev_err(&dsi->dev, "Failed to set display off: %d\n", ret);
> + return ret;
> + }
> + msleep(20);
> +
> + ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
> + if (ret < 0) {
> + dev_err(&dsi->dev, "Failed to enter sleep mode: %d\n", ret);
> + return ret;
> + }
> + msleep(60);
> +
> + return 0;
> +}
> +
> +static int nt36672e_panel_prepare(struct drm_panel *panel)
> +{
> + struct nt36672e_panel *ctx = to_nt36672e_panel(panel);
> + struct mipi_dsi_device *dsi = ctx->dsi;
> + int ret = 0;
> +
> + ret = nt36672e_power_on(ctx);
> + if (ret < 0)
> + return ret;
> +
> + ret = nt36672e_on(ctx);
> + if (ret < 0) {
> + dev_err(&dsi->dev, "Failed to initialize panel: %d\n", ret);
> + if (nt36672e_power_off(ctx))
> + dev_err(&dsi->dev, "power off failed\n");
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static int nt36672e_panel_unprepare(struct drm_panel *panel)
> +{
> + struct nt36672e_panel *ctx = to_nt36672e_panel(panel);
> + struct mipi_dsi_device *dsi = ctx->dsi;
> + int ret = 0;
> +
> + ret = nt36672e_off(ctx);
> + if (ret < 0)
> + dev_err(&dsi->dev, "Failed to un-initialize panel: %d\n", ret);
> +
> + ret = nt36672e_power_off(ctx);
> + if (ret < 0)
> + dev_err(&dsi->dev, "power off failed: %d\n", ret);
> +
> + return 0;
> +}
> +
> +static const struct drm_display_mode nt36672e_1080x2408_60hz = {
> + .name = "1080x2408",
> + .clock = 181690,
> + .hdisplay = 1080,
> + .hsync_start = 1080 + 76,
> + .hsync_end = 1080 + 76 + 12,
> + .htotal = 1080 + 76 + 12 + 56,
> + .vdisplay = 2408,
> + .vsync_start = 2408 + 46,
> + .vsync_end = 2408 + 46 + 10,
> + .vtotal = 2408 + 46 + 10 + 10,
> + .flags = 0,
> +};
> +
> +static const struct panel_desc nt36672e_panel_desc = {
> + .display_mode = &nt36672e_1080x2408_60hz,
> + .width_mm = 74,
> + .height_mm = 131,
> + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS,
> + .format = MIPI_DSI_FMT_RGB888,
> + .lanes = 4,
> + .panel_name = "nt36672e fhd plus panel",
> + .init_sequence = nt36672e_1080x2408_60hz_init,
> +};
> +
> +static int nt36672e_panel_get_modes(struct drm_panel *panel, struct drm_connector *connector)
> +{
> + struct nt36672e_panel *ctx = to_nt36672e_panel(panel);
> + struct drm_display_mode *mode;
> +
> + mode = drm_mode_duplicate(connector->dev, ctx->desc->display_mode);
> + if (!mode)
> + return -ENOMEM;
> +
> + drm_mode_set_name(mode);
> +
> + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
> + connector->display_info.width_mm = ctx->desc->width_mm;
> + connector->display_info.height_mm = ctx->desc->height_mm;
> + drm_mode_probed_add(connector, mode);
> +
> + return 1;
> +}
> +
> +static const struct drm_panel_funcs nt36672e_drm_funcs = {
> + .prepare = nt36672e_panel_prepare,
> + .unprepare = nt36672e_panel_unprepare,
> + .get_modes = nt36672e_panel_get_modes,
> +};
> +
> +static int nt36672e_panel_probe(struct mipi_dsi_device *dsi)
> +{
> + struct device *dev = &dsi->dev;
> + struct nt36672e_panel *ctx;
> + int i, ret = 0;
> +
> + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
> + if (!ctx)
> + return -ENOMEM;
> +
> + ctx->desc = of_device_get_match_data(dev);
> + if (!ctx->desc) {
> + dev_err(dev, "missing device configuration\n");
> + return -ENODEV;
> + }
> +
> + for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++)
> + ctx->supplies[i].supply = regulator_names[i];
> +
> + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies),
> + ctx->supplies);
> + if (ret < 0)
> + return ret;
> +
> + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> + if (IS_ERR(ctx->reset_gpio))
> + return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), "Failed to get reset-gpios\n");
> +
> + ctx->dsi = dsi;
> + mipi_dsi_set_drvdata(dsi, ctx);
> +
> + dsi->lanes = ctx->desc->lanes;
> + dsi->format = ctx->desc->format;
> + dsi->mode_flags = ctx->desc->mode_flags;
> +
> + drm_panel_init(&ctx->panel, dev, &nt36672e_drm_funcs, DRM_MODE_CONNECTOR_DSI);
> +
> + ret = drm_panel_of_backlight(&ctx->panel);
> + if (ret)
> + return dev_err_probe(dev, ret, "Failed to get backlight\n");
> +
> + ctx->panel.prepare_prev_first = true;
> +
> + drm_panel_add(&ctx->panel);
> +
> + ret = mipi_dsi_attach(dsi);
> + if (ret < 0) {
> + dev_err(dev, "Failed to attach to DSI host: %d\n", ret);
> + goto err_dsi_attach;
> + }
> +
> + return 0;
> +
> +err_dsi_attach:
> + drm_panel_remove(&ctx->panel);
> + return ret;
> +}
> +
> +static void nt36672e_panel_remove(struct mipi_dsi_device *dsi)
> +{
> + struct nt36672e_panel *ctx = mipi_dsi_get_drvdata(dsi);
> +
> + mipi_dsi_detach(ctx->dsi);
> + mipi_dsi_device_unregister(ctx->dsi);
> +
> + drm_panel_remove(&ctx->panel);
> +}
> +
> +static const struct of_device_id nt36672e_of_match[] = {
> + {
> + .compatible = "novatek,nt36672e",
> + .data = &nt36672e_panel_desc,
> + },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, nt36672e_of_match);
> +
> +static struct mipi_dsi_driver nt36672e_panel_driver = {
> + .driver = {
> + .name = "panel-novatek-nt36672e",
> + .of_match_table = nt36672e_of_match,
> + },
> + .probe = nt36672e_panel_probe,
> + .remove = nt36672e_panel_remove,
> +};
> +module_mipi_dsi_driver(nt36672e_panel_driver);
> +
> +MODULE_AUTHOR("Ritesh Kumar <[email protected]>");
> +MODULE_DESCRIPTION("Novatek NT36672E DSI Panel Driver");
> +MODULE_LICENSE("GPL");
> --
> 2.17.1
>
Hi,
On Mon, 08 Jan 2024 15:29:00 +0530, Ritesh Kumar wrote:
> Add support for the 1080x2408 Novatek NT36672E LCD DSI mode panel
> found on the Qualcomm QCM6490 MTP board.
>
> The driver will come with the uncompressed video mode support.
>
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/2] dt-bindings: display: panel: Add Novatek NT36672E LCD DSI
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=30cc664f0962ed1e62d9009a34bf04b48e1a5a4a
[2/2] drm/panel: Add support for Novatek NT36672E panel driver
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=ea4f9975625af861c2795c557b8fab2b492ff749
--
Neil