2024-01-08 13:12:39

by Krzysztof Kozlowski

Subject: [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios

Bindings allow a "wake", not "enable", GPIO. Schematics also use WAKE
name for the pin:

sdm845-db845c.dtb: pcie@1c00000: Unevaluated properties are not allowed ('enable-gpio' was unexpected)

Fixes: 4a657c264b78 ("arm64: dts: qcom: db845c: Enable PCIe controllers")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index ab6220456513..1f517328199b 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -580,7 +580,7 @@ &mss_pil {
&pcie0 {
status = "okay";
perst-gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
- enable-gpio = <&tlmm 134 GPIO_ACTIVE_HIGH>;
+ wake-gpios = <&tlmm 134 GPIO_ACTIVE_HIGH>;

vddpe-3v3-supply = <&pcie0_3p3v_dual>;

--
2.34.1

2024-01-08 13:12:51

by Krzysztof Kozlowski

Subject: [PATCH 2/2] arm64: dts: qcom: sm8150: correct PCIe wake-gpios

Bindings allow a "wake", not "enable", GPIO. Schematics also use WAKE
name for the pin:

sa8155p-adp.dtb: pcie@1c00000: Unevaluated properties are not allowed ('enable-gpio' was unexpected)

Fixes: a1c86c680533 ("arm64: dts: qcom: sm8150: Add PCIe nodes")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 031acef259e9..53c78c126ded 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1881,7 +1881,7 @@ pcie0: pcie@1c00000 {
phy-names = "pciephy";

perst-gpios = <&tlmm 35 GPIO_ACTIVE_HIGH>;
- enable-gpio = <&tlmm 37 GPIO_ACTIVE_HIGH>;
+ wake-gpios = <&tlmm 37 GPIO_ACTIVE_HIGH>;

pinctrl-names = "default";
pinctrl-0 = <&pcie0_default_state>;
--
2.34.1

2024-01-08 13:15:58

by Konrad Dybcio

Subject: Re: [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios

On 8.01.2024 14:12, Krzysztof Kozlowski wrote:
> Bindings allow a "wake", not "enable", GPIO. Schematics also use WAKE
> name for the pin:
>
> sdm845-db845c.dtb: pcie@1c00000: Unevaluated properties are not allowed ('enable-gpio' was unexpected)
>
> Fixes: 4a657c264b78 ("arm64: dts: qcom: db845c: Enable PCIe controllers")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2024-01-08 13:16:09

by Konrad Dybcio

Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8150: correct PCIe wake-gpios

On 8.01.2024 14:12, Krzysztof Kozlowski wrote:
> Bindings allow a "wake", not "enable", GPIO. Schematics also use WAKE
> name for the pin:
>
> sa8155p-adp.dtb: pcie@1c00000: Unevaluated properties are not allowed ('enable-gpio' was unexpected)
>
> Fixes: a1c86c680533 ("arm64: dts: qcom: sm8150: Add PCIe nodes")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2024-02-16 23:31:40

by Bjorn Andersson

Subject: Re: (subset) [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios

On Mon, 08 Jan 2024 14:12:15 +0100, Krzysztof Kozlowski wrote:
> Bindings allow a "wake", not "enable", GPIO. Schematics also use WAKE
> name for the pin:
>
> sdm845-db845c.dtb: pcie@1c00000: Unevaluated properties are not allowed ('enable-gpio' was unexpected)
>
>

Applied, thanks!

[1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios
commit: 584a327c5cffc36369b2a8953d9448826240f1ac
[2/2] arm64: dts: qcom: sm8150: correct PCIe wake-gpios
commit: 7c38989d0f7a35c83e7c4781271d42662903fa8d

Best regards,
--
Bjorn Andersson <[email protected]>