2024-01-09 18:07:47

by Conor Dooley

[permalink] [raw]

Subject: Re: [DO NOT MERGE v6 27/37] dt-bindings: ata: ata-generic: Add new targets

---

On Tue, Jan 09, 2024 at 05:23:24PM +0900, Yoshinori Sato wrote:
> Added new ata-generic target.
> - iodata,usl-5p-ata
> - renesas,rts7751r2d-ata
>
> Each boards have simple IDE Interface. Use ATA generic driver.
>
> Signed-off-by: Yoshinori Sato <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Cheers,
Conor.

> ---
> Documentation/devicetree/bindings/ata/ata-generic.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/ata-generic.yaml b/Documentation/devicetree/bindings/ata/ata-generic.yaml
> index 0697927f3d7e..1025b3b351d0 100644
> --- a/Documentation/devicetree/bindings/ata/ata-generic.yaml
> +++ b/Documentation/devicetree/bindings/ata/ata-generic.yaml
> @@ -18,6 +18,8 @@ properties:
> - enum:
> - arm,vexpress-cf
> - fsl,mpc8349emitx-pata
> + - iodata,usl-5p-ata
> + - renesas,rts7751r2d-ata
> - const: ata-generic
>
> reg:
> --
> 2.39.2
>

---

Attachments:

(No filename) (1.01 kB)
signature.asc (235.00 B)
Download all attachments

2024-01-09 18:10:05

by Conor Dooley

[permalink] [raw]

Subject: Re: [DO NOT MERGE v6 27/37] dt-bindings: ata: ata-generic: Add new targets

---

On Tue, Jan 09, 2024 at 06:07:19PM +0000, Conor Dooley wrote:
> On Tue, Jan 09, 2024 at 05:23:24PM +0900, Yoshinori Sato wrote:
> > Added new ata-generic target.
> > - iodata,usl-5p-ata
> > - renesas,rts7751r2d-ata
> >
> > Each boards have simple IDE Interface. Use ATA generic driver.
> >
> > Signed-off-by: Yoshinori Sato <[email protected]>
>
> Acked-by: Conor Dooley <[email protected]>

That said, a bullet point list in the commit message of what
compatibles you added isn't really achieving anything, you can drop that
from the commit message if/when you resend the series.


>
> Cheers,
> Conor.
>
> > ---
> > Documentation/devicetree/bindings/ata/ata-generic.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/ata/ata-generic.yaml b/Documentation/devicetree/bindings/ata/ata-generic.yaml
> > index 0697927f3d7e..1025b3b351d0 100644
> > --- a/Documentation/devicetree/bindings/ata/ata-generic.yaml
> > +++ b/Documentation/devicetree/bindings/ata/ata-generic.yaml
> > @@ -18,6 +18,8 @@ properties:
> > - enum:
> > - arm,vexpress-cf
> > - fsl,mpc8349emitx-pata
> > + - iodata,usl-5p-ata
> > + - renesas,rts7751r2d-ata
> > - const: ata-generic
> >
> > reg:
> > --
> > 2.39.2
> >

---

Attachments:

(No filename) (1.34 kB)
signature.asc (235.00 B)
Download all attachments