The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
It can be drived by Raspberry Pi panel's process but it needs different
timing from Raspberry Pi panel. Add compatible property for it.
Signed-off-by: Keith Zhao <[email protected]>
Signed-off-by: Shengyang Chen <[email protected]>
---
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 11422af3477e..02f6b1b2ddc9 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -335,6 +335,8 @@ properties:
- vivax,tpc9150-panel
# VXT 800x480 color TFT LCD panel
- vxt,vl050-8048nt-c01
+ # Waveshare 7" (800x480) touchscreen LCD panel
+ - waveshare,7inch-touchscreen
# Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
- winstar,wf35ltiacd
# Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
--
2.17.1
On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
> It can be drived by Raspberry Pi panel's process but it needs different
> timing from Raspberry Pi panel. Add compatible property for it.
>
> Signed-off-by: Keith Zhao <[email protected]>
> Signed-off-by: Shengyang Chen <[email protected]>
> ---
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 11422af3477e..02f6b1b2ddc9 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -335,6 +335,8 @@ properties:
> - vivax,tpc9150-panel
> # VXT 800x480 color TFT LCD panel
> - vxt,vl050-8048nt-c01
> + # Waveshare 7" (800x480) touchscreen LCD panel
> + - waveshare,7inch-touchscreen
Is "7inch-touchscreen" really a specific enough identifier for this
device?
> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
> - winstar,wf35ltiacd
> # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
> --
> 2.17.1
>
On 09/01/2024 17:32, Conor Dooley wrote:
> On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
>> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
>> It can be drived by Raspberry Pi panel's process but it needs different
>> timing from Raspberry Pi panel. Add compatible property for it.
>>
>> Signed-off-by: Keith Zhao <[email protected]>
>> Signed-off-by: Shengyang Chen <[email protected]>
>> ---
>> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> index 11422af3477e..02f6b1b2ddc9 100644
>> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> @@ -335,6 +335,8 @@ properties:
>> - vivax,tpc9150-panel
>> # VXT 800x480 color TFT LCD panel
>> - vxt,vl050-8048nt-c01
>> + # Waveshare 7" (800x480) touchscreen LCD panel
>> + - waveshare,7inch-touchscreen
>
> Is "7inch-touchscreen" really a specific enough identifier for this
> device?
Waveshare has very precise SKUs, this should be something like waveshare,7inch-dsi-sku19885 perhaps
Neil
>
>> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
>> - winstar,wf35ltiacd
>> # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
>> --
>> 2.17.1
>>
Hi, Conor
Thanks for comment.
> -----Original Message-----
> From: Conor Dooley <[email protected]>
> Sent: 2024??1??10?? 0:32
> To: Shengyang Chen <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; Changhuang
> Liang <[email protected]>; Keith Zhao
> <[email protected]>; Jack Zhu <[email protected]>;
> [email protected]
> Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add
> compatible property for waveshare 7inch touchscreen panel
>
> On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480
> > panel It can be drived by Raspberry Pi panel's process but it needs
> > different timing from Raspberry Pi panel. Add compatible property for it.
> >
> > Signed-off-by: Keith Zhao <[email protected]>
> > Signed-off-by: Shengyang Chen <[email protected]>
> > ---
> > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > index 11422af3477e..02f6b1b2ddc9 100644
> > ---
> > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yam
> > +++ l
> > @@ -335,6 +335,8 @@ properties:
> > - vivax,tpc9150-panel
> > # VXT 800x480 color TFT LCD panel
> > - vxt,vl050-8048nt-c01
> > + # Waveshare 7" (800x480) touchscreen LCD panel
> > + - waveshare,7inch-touchscreen
>
> Is "7inch-touchscreen" really a specific enough identifier for this device?
>
Referring to official website[1] and Neil's suggestion, maybe I should change to
"7inch-touchscreen-dsi-lcd" or "waveshare,7inch-dsi-sku19885" if the next patch version is needed.
[1]: https://www.waveshare.com/7inch-dsi-lcd.htm
> > # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
> > - winstar,wf35ltiacd
> > # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
> > --
> > 2.17.1
> >
Best Regards,
Shengyang
> -----Original Message-----
> From: [email protected] <[email protected]>
> Sent: 2024年1月10日 17:06
> To: Conor Dooley <[email protected]>; Shengyang Chen
> <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; Changhuang
> Liang <[email protected]>; Keith Zhao
> <[email protected]>; Jack Zhu <[email protected]>;
> [email protected]
> Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add
> compatible property for waveshare 7inch touchscreen panel
>
> On 09/01/2024 17:32, Conor Dooley wrote:
> > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> >> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480
> >> panel It can be drived by Raspberry Pi panel's process but it needs
> >> different timing from Raspberry Pi panel. Add compatible property for it.
> >>
> >> Signed-off-by: Keith Zhao <[email protected]>
> >> Signed-off-by: Shengyang Chen <[email protected]>
> >> ---
> >> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git
> >> a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> >> b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> >> index 11422af3477e..02f6b1b2ddc9 100644
> >> ---
> >> a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> >> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.ya
> >> +++ ml
> >> @@ -335,6 +335,8 @@ properties:
> >> - vivax,tpc9150-panel
> >> # VXT 800x480 color TFT LCD panel
> >> - vxt,vl050-8048nt-c01
> >> + # Waveshare 7" (800x480) touchscreen LCD panel
> >> + - waveshare,7inch-touchscreen
> >
> > Is "7inch-touchscreen" really a specific enough identifier for this
> > device?
>
> Waveshare has very precise SKUs, this should be something like
> waveshare,7inch-dsi-sku19885 perhaps
>
> Neil
thanks for mention, It will be checked if next version is needed.
>
> >
> >> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD
> panel
> >> - winstar,wf35ltiacd
> >> # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
> >> --
> >> 2.17.1
> >>
On Tue, Jan 16, 2024 at 09:40:21AM +0000, Shengyang Chen wrote:
> Hi, Conor
>
> Thanks for comment.
>
> > -----Original Message-----
> > From: Conor Dooley <[email protected]>
> > Sent: 2024年1月10日 0:32
> > To: Shengyang Chen <[email protected]>
> > Cc: [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; Changhuang
> > Liang <[email protected]>; Keith Zhao
> > <[email protected]>; Jack Zhu <[email protected]>;
> > [email protected]
> > Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add
> > compatible property for waveshare 7inch touchscreen panel
> >
> > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> > > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480
> > > panel It can be drived by Raspberry Pi panel's process but it needs
> > > different timing from Raspberry Pi panel. Add compatible property for it.
> > >
> > > Signed-off-by: Keith Zhao <[email protected]>
> > > Signed-off-by: Shengyang Chen <[email protected]>
> > > ---
> > > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > > index 11422af3477e..02f6b1b2ddc9 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yam
> > > +++ l
> > > @@ -335,6 +335,8 @@ properties:
> > > - vivax,tpc9150-panel
> > > # VXT 800x480 color TFT LCD panel
> > > - vxt,vl050-8048nt-c01
> > > + # Waveshare 7" (800x480) touchscreen LCD panel
> > > + - waveshare,7inch-touchscreen
> >
> > Is "7inch-touchscreen" really a specific enough identifier for this device?
> >
>
> Referring to official website[1] and Neil's suggestion, maybe I should change to
> "7inch-touchscreen-dsi-lcd" or "waveshare,7inch-dsi-sku19885" if the next patch version is needed.
The one with the sku certainly seems more specific, if a next version is
needed I would use that.
Thanks,
Conor.