2024-01-09 07:58:14

by Chancel Liu

[permalink] [raw]

Subject: [PATCH 3/3] ASoC: dt-bindings: fsl,micfil: Add compatible string for i.MX95 platform

---

Add compatible string "fsl,imx95-micfil" for i.MX95 platform.

Signed-off-by: Chancel Liu <[email protected]>
---
.../devicetree/bindings/sound/fsl,micfil.yaml | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/fsl,micfil.yaml b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
index b7e605835639..f0d3d11d07d2 100644
--- a/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
+++ b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
@@ -15,10 +15,17 @@ description: |

properties:
compatible:
- enum:
- - fsl,imx8mm-micfil
- - fsl,imx8mp-micfil
- - fsl,imx93-micfil
+ oneOf:
+ - items:
+ - enum:
+ - fsl,imx95-micfil
+ - const: fsl,imx93-micfil
+
+ - items:
+ - enum:
+ - fsl,imx8mm-micfil
+ - fsl,imx8mp-micfil
+ - fsl,imx93-micfil

reg:
maxItems: 1
--
2.42.0

2024-01-09 14:16:33

by Daniel Baluta

[permalink] [raw]

Subject: Re: [PATCH 3/3] ASoC: dt-bindings: fsl,micfil: Add compatible string for i.MX95 platform

---

On Tue, Jan 9, 2024 at 9:58 AM Chancel Liu <[email protected]> wrote:
>
> Add compatible string "fsl,imx95-micfil" for i.MX95 platform.
>
> Signed-off-by: Chancel Liu <[email protected]>
> ---
> .../devicetree/bindings/sound/fsl,micfil.yaml | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,micfil.yaml b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> index b7e605835639..f0d3d11d07d2 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> @@ -15,10 +15,17 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - fsl,imx8mm-micfil
> - - fsl,imx8mp-micfil
> - - fsl,imx93-micfil
> + oneOf:
> + - items:
> + - enum:
> + - fsl,imx95-micfil
> + - const: fsl,imx93-micfil
> +
> + - items:
> + - enum:
> + - fsl,imx8mm-micfil
> + - fsl,imx8mp-micfil
> + - fsl,imx93-micfil

My yaml knowledge is very limited. Can you describe in natural
language in the commit what exactly we are doing here.

Why something like this:


> compatible:
> enum:
> - fsl,imx8mm-micfil
> - fsl,imx8mp-micfil
> - fsl,imx93-micfil
+ - fsl,imx95-micfil

Isn't enough?

2024-01-10 09:10:30

by Chancel Liu

[permalink] [raw]

Subject: RE: Re: [PATCH 3/3] ASoC: dt-bindings: fsl,micfil: Add compatible string for i.MX95 platform

---

> On Tue, Jan 9, 2024 at 9:58 AM Chancel Liu <[email protected]> wrote:
> >
> > Add compatible string "fsl,imx95-micfil" for i.MX95 platform.
> >
> > Signed-off-by: Chancel Liu <[email protected]>
> > ---
> > .../devicetree/bindings/sound/fsl,micfil.yaml | 15 +++++++++++----
> > 1 file changed, 11 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> > index b7e605835639..f0d3d11d07d2 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> > +++ b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> > @@ -15,10 +15,17 @@ description: |
> >
> > properties:
> > compatible:
> > - enum:
> > - - fsl,imx8mm-micfil
> > - - fsl,imx8mp-micfil
> > - - fsl,imx93-micfil
> > + oneOf:
> > + - items:
> > + - enum:
> > + - fsl,imx95-micfil
> > + - const: fsl,imx93-micfil
> > +
> > + - items:
> > + - enum:
> > + - fsl,imx8mm-micfil
> > + - fsl,imx8mp-micfil
> > + - fsl,imx93-micfil
>
> My yaml knowledge is very limited. Can you describe in natural
> language in the commit what exactly we are doing here.
>
> Why something like this:
>
>
> > compatible:
> > enum:
> > - fsl,imx8mm-micfil
> > - fsl,imx8mp-micfil
> > - fsl,imx93-micfil
> + - fsl,imx95-micfil
>
> Isn't enough?

No. This shows MICFIL on i.MX95 is different from it on I.MX93.

However i.MX95 MICFIL is compatible with i.MX93 MICFIL.
The DT node of MICFIL on i.MX95 looks like:
micfil: micfil@44520000 {
compatible = "fsl,imx95-micfil", "fsl,imx93-micfil";
...
};

Regards,
Chancel Liu

2024-01-10 10:56:29

by Conor Dooley

[permalink] [raw]

Subject: Re: [PATCH 3/3] ASoC: dt-bindings: fsl,micfil: Add compatible string for i.MX95 platform

---

On Tue, Jan 09, 2024 at 04:55:51PM +0900, Chancel Liu wrote:
> Add compatible string "fsl,imx95-micfil" for i.MX95 platform.
>
> Signed-off-by: Chancel Liu <[email protected]>
> ---
> .../devicetree/bindings/sound/fsl,micfil.yaml | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,micfil.yaml b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> index b7e605835639..f0d3d11d07d2 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> @@ -15,10 +15,17 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - fsl,imx8mm-micfil
> - - fsl,imx8mp-micfil
> - - fsl,imx93-micfil
> + oneOf:
> + - items:
> + - enum:
> + - fsl,imx95-micfil
> + - const: fsl,imx93-micfil
> +

> + - items:

This items is not needed, as the only item in the list is the enum.
You can just do
properties:
compatible:
oneOf:
- items:
- enum:
- fsl,imx95-micfil
- const: fsl,imx93-micfil

- enum:
- fsl,imx8mm-micfil
- fsl,imx8mp-micfil
- fsl,imx93-micfil

Cheers,
Conor.

> + - enum:
> + - fsl,imx8mm-micfil
> + - fsl,imx8mp-micfil
> + - fsl,imx93-micfil
>
> reg:
> maxItems: 1
> --
> 2.42.0
>

---

Attachments:

(No filename) (1.48 kB)
signature.asc (235.00 B)
Download all attachments