Change mediatek,gce-events property to reference mediatek,gce-props.yaml
instead of defining itself.
Signed-off-by: Jason-JH.Lin <[email protected]>
---
.../bindings/media/mediatek,mdp3-rdma.yaml | 11 +++--------
.../devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 12 ++++--------
.../bindings/media/mediatek,mdp3-wrot.yaml | 12 ++++--------
3 files changed, 11 insertions(+), 24 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
index 59db8306485b..1ba70b9a5843 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
@@ -44,13 +44,6 @@ properties:
4 arguments defined in this property. Each GCE subsys id is mapping to
a client defined in the header include/dt-bindings/gce/<chip>-gce.h.
- mediatek,gce-events:
- description:
- The event id which is mapping to the specific hardware event signal
- to gce. The event id is defined in the gce header
- include/dt-bindings/gce/<chip>-gce.h of each chips.
- $ref: /schemas/types.yaml#/definitions/uint32-array
-
mediatek,scp:
$ref: /schemas/types.yaml#/definitions/phandle
description:
@@ -96,6 +89,8 @@ required:
- '#dma-cells'
allOf:
+ - $ref: ../mailbox/mediatek,gce-props.yaml
+
- if:
properties:
compatible:
@@ -142,7 +137,7 @@ allOf:
clocks:
maxItems: 1
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
index f5676bec4326..13219cc946a9 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
@@ -38,13 +38,6 @@ properties:
4 arguments defined in this property. Each GCE subsys id is mapping to
a client defined in the header include/dt-bindings/gce/<chip>-gce.h.
- mediatek,gce-events:
- description:
- The event id which is mapping to the specific hardware event signal
- to gce. The event id is defined in the gce header
- include/dt-bindings/gce/<chip>-gce.h of each chips.
- $ref: /schemas/types.yaml#/definitions/uint32-array
-
clocks:
minItems: 1
@@ -55,7 +48,10 @@ required:
- mediatek,gce-events
- clocks
-additionalProperties: false
+allOf:
+ - $ref: ../mailbox/mediatek,gce-props.yaml
+
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
index 53a679338402..40da895800e7 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
@@ -38,13 +38,6 @@ properties:
4 arguments defined in this property. Each GCE subsys id is mapping to
a client defined in the header include/dt-bindings/gce/<chip>-gce.h.
- mediatek,gce-events:
- description:
- The event id which is mapping to the specific hardware event signal
- to gce. The event id is defined in the gce header
- include/dt-bindings/gce/<chip>-gce.h of each chips.
- $ref: /schemas/types.yaml#/definitions/uint32-array
-
power-domains:
maxItems: 1
@@ -67,7 +60,10 @@ required:
- iommus
- '#dma-cells'
-additionalProperties: false
+allOf:
+ - $ref: ../mailbox/mediatek,gce-props.yaml
+
+unevaluatedProperties: false
examples:
- |
--
2.18.0
On 10/01/2024 07:35, Jason-JH.Lin wrote:
> Change mediatek,gce-events property to reference mediatek,gce-props.yaml
> instead of defining itself.
>
> Signed-off-by: Jason-JH.Lin <[email protected]>
> ---
> .../bindings/media/mediatek,mdp3-rdma.yaml | 11 +++--------
> .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 12 ++++--------
> .../bindings/media/mediatek,mdp3-wrot.yaml | 12 ++++--------
> 3 files changed, 11 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> index 59db8306485b..1ba70b9a5843 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> @@ -44,13 +44,6 @@ properties:
> 4 arguments defined in this property. Each GCE subsys id is mapping to
> a client defined in the header include/dt-bindings/gce/<chip>-gce.h.
>
> - mediatek,gce-events:
> - description:
> - The event id which is mapping to the specific hardware event signal
> - to gce. The event id is defined in the gce header
> - include/dt-bindings/gce/<chip>-gce.h of each chips.
> - $ref: /schemas/types.yaml#/definitions/uint32-array
> -
> mediatek,scp:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> @@ -96,6 +89,8 @@ required:
> - '#dma-cells'
>
> allOf:
> + - $ref: ../mailbox/mediatek,gce-props.yaml
You need full path, so /schemas/mailbox/
Applies to all the patches.
Best regards,
Krzysztof
Hi Krzysztof,
Thanks for the reivews.
On Fri, 2024-01-12 at 08:22 +0100, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 10/01/2024 07:35, Jason-JH.Lin wrote:
> > Change mediatek,gce-events property to reference mediatek,gce-
> props.yaml
> > instead of defining itself.
> >
> > Signed-off-by: Jason-JH.Lin <[email protected]>
> > ---
> > .../bindings/media/mediatek,mdp3-rdma.yaml | 11 +++-----
> ---
> > .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 12 ++++--
> ------
> > .../bindings/media/mediatek,mdp3-wrot.yaml | 12 ++++--
> ------
> > 3 files changed, 11 insertions(+), 24 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> > index 59db8306485b..1ba70b9a5843 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> > @@ -44,13 +44,6 @@ properties:
> > 4 arguments defined in this property. Each GCE subsys id is
> mapping to
> > a client defined in the header include/dt-
> bindings/gce/<chip>-gce.h.
> >
> > - mediatek,gce-events:
> > - description:
> > - The event id which is mapping to the specific hardware event
> signal
> > - to gce. The event id is defined in the gce header
> > - include/dt-bindings/gce/<chip>-gce.h of each chips.
> > - $ref: /schemas/types.yaml#/definitions/uint32-array
> > -
> > mediatek,scp:
> > $ref: /schemas/types.yaml#/definitions/phandle
> > description:
> > @@ -96,6 +89,8 @@ required:
> > - '#dma-cells'
> >
> > allOf:
> > + - $ref: ../mailbox/mediatek,gce-props.yaml
>
> You need full path, so /schemas/mailbox/
>
> Applies to all the patches.
>
OK, I'll apply it to all the patches.
Regards,
Jason-JH.Lin
> Best regards,
> Krzysztof
>