2024-01-10 02:58:45

by Sergey Senozhatsky

Subject: [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version

GCC is expected to implement this feature in version 15,
so bump the version.

Signed-off-by: Sergey Senozhatsky <[email protected]>
---
include/linux/compiler_attributes.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
index 28566624f008..215882a1341a 100644
--- a/include/linux/compiler_attributes.h
+++ b/include/linux/compiler_attributes.h
@@ -95,7 +95,7 @@
#endif

/*
- * Optional: only supported since gcc >= 14
+ * Optional: only supported since gcc >= 15
* Optional: only supported since clang >= 18
*
* gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896
--
2.43.0.472.g3155946c3a-goog

2024-01-10 02:59:04

by Sergey Senozhatsky

Subject: [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL

The URL in question 404 now, fix it up (and switch to github).

Signed-off-by: Sergey Senozhatsky <[email protected]>
---
include/linux/compiler_attributes.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
index 215882a1341a..289810685fc5 100644
--- a/include/linux/compiler_attributes.h
+++ b/include/linux/compiler_attributes.h
@@ -99,7 +99,7 @@
* Optional: only supported since clang >= 18
*
* gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896
- * clang: https://reviews.llvm.org/D148381
+ * clang: https://github.com/llvm/llvm-project/pull/76348
*/
#if __has_attribute(__counted_by__)
# define __counted_by(member) __attribute__((__counted_by__(member)))
--
2.43.0.472.g3155946c3a-goog

2024-01-10 03:01:37

by Nathan Chancellor

Subject: Re: [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version

On Wed, Jan 10, 2024 at 11:58:17AM +0900, Sergey Senozhatsky wrote:
> GCC is expected to implement this feature in version 15,
> so bump the version.
>
> Signed-off-by: Sergey Senozhatsky <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

> ---
> include/linux/compiler_attributes.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
> index 28566624f008..215882a1341a 100644
> --- a/include/linux/compiler_attributes.h
> +++ b/include/linux/compiler_attributes.h
> @@ -95,7 +95,7 @@
> #endif
>
> /*
> - * Optional: only supported since gcc >= 14
> + * Optional: only supported since gcc >= 15
> * Optional: only supported since clang >= 18
> *
> * gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896
> --
> 2.43.0.472.g3155946c3a-goog
>

2024-01-10 03:03:08

by Nathan Chancellor

Subject: Re: [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL

On Wed, Jan 10, 2024 at 11:58:18AM +0900, Sergey Senozhatsky wrote:
> The URL in question 404 now, fix it up (and switch to github).
>
> Signed-off-by: Sergey Senozhatsky <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

I sent a patch series today for the rest of the tree, which includes a
link to what happened here:

https://lore.kernel.org/[email protected]/
https://lore.kernel.org/[email protected]/

> ---
> include/linux/compiler_attributes.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
> index 215882a1341a..289810685fc5 100644
> --- a/include/linux/compiler_attributes.h
> +++ b/include/linux/compiler_attributes.h
> @@ -99,7 +99,7 @@
> * Optional: only supported since clang >= 18
> *
> * gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896
> - * clang: https://reviews.llvm.org/D148381
> + * clang: https://github.com/llvm/llvm-project/pull/76348
> */
> #if __has_attribute(__counted_by__)
> # define __counted_by(member) __attribute__((__counted_by__(member)))
> --
> 2.43.0.472.g3155946c3a-goog
>

2024-01-10 03:08:44

by Sergey Senozhatsky

Subject: Re: [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL

On (24/01/09 20:02), Nathan Chancellor wrote:
> On Wed, Jan 10, 2024 at 11:58:18AM +0900, Sergey Senozhatsky wrote:
> > The URL in question 404 now, fix it up (and switch to github).
> >
> > Signed-off-by: Sergey Senozhatsky <[email protected]>
>
> Reviewed-by: Nathan Chancellor <[email protected]>
>
> I sent a patch series today for the rest of the tree, which includes a
> link to what happened here:

Thanks!

2024-01-11 00:46:53

by Kees Cook

Subject: Re: [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version

On Wed, Jan 10, 2024 at 11:58:17AM +0900, Sergey Senozhatsky wrote:
> GCC is expected to implement this feature in version 15,
> so bump the version.
>
> Signed-off-by: Sergey Senozhatsky <[email protected]>

Yup, this is good. Miguel, I can take these patches if you want?

Reviewed-by: Kees Cook <[email protected]>

--
Kees Cook

2024-01-11 00:47:07

by Kees Cook

Subject: Re: [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL

On Wed, Jan 10, 2024 at 11:58:18AM +0900, Sergey Senozhatsky wrote:
> The URL in question 404 now, fix it up (and switch to github).
>
> Signed-off-by: Sergey Senozhatsky <[email protected]>

Thanks!

Reviewed-by: Kees Cook <[email protected]>

--
Kees Cook

2024-01-23 20:38:57

by Miguel Ojeda

Subject: Re: [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version

On Thu, Jan 11, 2024 at 1:46 AM Kees Cook <[email protected]> wrote:
>
> Yup, this is good. Miguel, I can take these patches if you want?
>
> Reviewed-by: Kees Cook <[email protected]>

Thanks Kees -- just applied them on top of v6.8-rc1 so they should be
in -next soon, but if you need to pick them up for another reason,
please go ahead.

Cheers,
Miguel